test: fix pmempool check tests

As we are clearing shutdown state incompat feature by pmemspoil
we must reset SDS to 0 otherwise pmempool check will detect a pool
corruption.

src/test/pmempool_check/TEST1

 #!/usr/bin/env bash
 #
-# Copyright 2014-2018, Intel Corporation
+# Copyright 2014-2019, Intel Corporation
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions
@@ -53,6 +53,9 @@ $PMEMSPOIL -v $POOL pool_hdr.major=0x0\
 			pool_hdr.features.compat=0xfe\
 			pool_hdr.features.incompat=0xfb\
 			pool_hdr.features.ro_compat=0xff\
+			pool_hdr.shutdown_state.usc=0\
+			pool_hdr.shutdown_state.uuid=0\
+			'pool_hdr.shutdown_state.checksum_gen()'\
 			pool_hdr.unused=ERROR >> $LOG
 expect_normal_exit $PMEMPOOL$EXESUFFIX check -vry $POOL >> $LOG
 

src/test/pmempool_check/TEST1.PS1

 #
-# Copyright 2014-2018, Intel Corporation
+# Copyright 2014-2019, Intel Corporation
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions
@@ -47,11 +47,8 @@ $LOG="out$Env:UNITTEST_NUM.log"
 echo "PMEMLOG: pool_hdr" > $LOG
 expect_normal_exit $PMEMPOOL create log $POOL
 check_file $POOL
-# pool_hdr.features.incompat on Windows has to have SHUTDOWN_STATE feature enabled
-# otherwise pmempool check will fail because of dirty shutdown state structures
-# which are expected to be zeroed if SHUTDOWN_STATE feature is disabled
-# 0xfe == 0xfb | SHUTDOWN_STATE
-Invoke-Expression "$PMEMSPOIL -v $POOL pool_hdr.major=0x0 pool_hdr.features.compat=0xfe pool_hdr.features.incompat=0xfe pool_hdr.features.ro_compat=0xff pool_hdr.unused=ERROR >> $LOG"
+
+Invoke-Expression "$PMEMSPOIL -v $POOL pool_hdr.major=0x0 pool_hdr.features.compat=0xfe pool_hdr.features.incompat=0xfe pool_hdr.features.ro_compat=0xfb pool_hdr.shutdown_state.usc=0 pool_hdr.shutdown_state.uuid=0 'pool_hdr.shutdown_state.checksum_gen()' pool_hdr.unused=ERROR >> $LOG"
 expect_normal_exit $PMEMPOOL check -vry $POOL >> $LOG
 
 echo "PMEMLOG: pmemlog" >> $LOG

src/test/pmempool_check/TEST9

 #!/usr/bin/env bash
 #
-# Copyright 2014-2018, Intel Corporation
+# Copyright 2014-2019, Intel Corporation
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions
@@ -54,6 +54,9 @@ $PMEMSPOIL -v $POOL pool_hdr.major=0x0\
 			pool_hdr.features.compat=0xfe\
 			pool_hdr.features.incompat=0xfb\
 			pool_hdr.features.ro_compat=0xff\
+			pool_hdr.shutdown_state.usc=0\
+			pool_hdr.shutdown_state.uuid=0\
+			'pool_hdr.shutdown_state.checksum_gen()'\
 			pool_hdr.unused=ERROR >> $LOG
 
 expect_abnormal_exit $PMEMPOOL$EXESUFFIX check -vyr $POOL >> $LOG

src/test/pmempool_check/TEST9.PS1

 #
-# Copyright 2017-2018, Intel Corporation
+# Copyright 2017-2019, Intel Corporation
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions
@@ -48,15 +48,14 @@ expect_normal_exit $PMEMPOOL create obj $POOL
 
 expect_normal_exit $PMEMPOOL check -vyr $POOL >> $LOG
 
-# pool_hdr.features.incompat on Windows has to have SHUTDOWN_STATE feature enabled
-# otherwise pmempool check will fail because of dirty shutdown state structures
-# which are expected to be zeroed if SHUTDOWN_STATE feature is disabled
-# 0xfe == 0xfb | SHUTDOWN_STATE
 &$PMEMSPOIL -v $POOL `
 	pool_hdr.major=0x0 `
 	pool_hdr.features.compat=0xfe `
 	pool_hdr.features.incompat=0xfe `
 	pool_hdr.features.ro_compat=0xff `
+	pool_hdr.shutdown_state.usc=0 `
+	pool_hdr.shutdown_state.uuid=0 `
+	'pool_hdr.shutdown_state.checksum_gen()' `
 	pool_hdr.unused=ERROR `
 	>> $LOG
 

src/test/pmempool_check/out1.log.match

@@ -3,6 +3,9 @@ $(nW): spoil: pool_hdr.major=$(*)
 $(nW): spoil: pool_hdr.features.compat=$(*)
 $(nW): spoil: pool_hdr.features.incompat=$(*)
 $(nW): spoil: pool_hdr.features.ro_compat=$(*)
+$(nW): spoil: pool_hdr.shutdown_state.usc=0
+$(nW): spoil: pool_hdr.shutdown_state.uuid=0
+$(nW): spoil: pool_hdr.shutdown_state.checksum_gen()
 $(nW): spoil: pool_hdr.unused=$(*)
 checking shutdown state
 shutdown state correct

src/test/pmempool_check/out9.log.match

@@ -8,6 +8,9 @@ $(nW)file.pool: spoil: pool_hdr.features.compat=0xfe
 $(OPT)$(nW)file.pool: spoil: pool_hdr.features.incompat=0xfb
 $(OPX)$(nW)file.pool: spoil: pool_hdr.features.incompat=0xfe
 $(nW)file.pool: spoil: pool_hdr.features.ro_compat=0xff
+$(nW): spoil: pool_hdr.shutdown_state.usc=0
+$(nW): spoil: pool_hdr.shutdown_state.uuid=0
+$(nW): spoil: pool_hdr.shutdown_state.checksum_gen()
 $(nW)file.pool: spoil: pool_hdr.unused=ERROR
 checking shutdown state
 shutdown state correct