Skip to content
Snippets Groups Projects
Code owners
Assign users and groups as approvers for specific file changes. Learn more.
TODO 3.28 KiB
memory leak 

tbse.mint valgrind  --M_1 50 --M_2 30 --orbital_period 0 --separation 2
----


fix the comment in binary_c_buffered_printf which is out of date.

Implement http://articles.adsabs.harvard.edu/pdf/1999MNRAS.306..307C

------------------------------------------------------------

Change fixed-length strings, where possible, to C99 flexible array members
https://en.wikipedia.org/wiki/Flexible_array_member

------------------------------------------------------------

gravitational waves

https://ui.adsabs.harvard.edu/abs/2019MNRAS.488...99G/abstract
------------------------------------------------------------

Magnetic braking for remannts (NS,WD)

mechanism for preventing events within events

macros to check we're in events

fix RK4: gives very different results

------------------------------------------------------------

fix TPAGB for new solvers:

counting of pulses etc. will break, should be done with a derivative

Note: Natalie will fix this.

------------------------------------------------------------
use prefetch on tight loops


need to change the step size when calling the hybrid solver


Discs:

When we have no stable disc (because there is insufficient angular 
momentum) does it make sense to remove material at the current
specific angular momentum? Indeed, if any material is lost it is
likely from the outer edge - at least, from the inner edge has so 
little angular momentum compared to the outer edge - which just 
reduces the disc's angular momentum and makes it even less stable.

Can some analytic arguments be made regarding this problem?

-----

* Xion should be used to calculate the recombination energies.

* Check that the accretion efficiencies are really working
* NSNS magnetic interaction rate

fix various SN tripping mechanisms:
* Marietta + 2000
* CCNSNe : Hirai + 2014 for RGBs
* CCSNe : Liu 2015 for MS stars 
* SNIa : Liu 2012
* update Tauris&Takens to cope with eccentric orbits : Dutch paper?
comenv lightcurves?
* http://adsabs.harvard.edu/abs/2017ApJS..229...36G

CSJ project
* strip RGB companions to SNe
* Zheng-Wei's stripping fraction from Ia explosions
* look for single (stripped) He cores with a Ia (or CC) companion
* look for those that go on to ignite He (sdO/B) 

MS project
* irradiation (Prialnik, Shara +)
* http://iopscience.iop.org/article/10.3847/0004-637X/817/1/69/meta

* perhaps have an accretion directory devoted to accretion?


   
* replace mcheif with a lookup table: all its
   arguments depend only on phase_start_mass and metallicity


* FIRST DO THIS WITH CALC LUM AND EVOL TIME
* automatically map the parameter space of BSE functions to lookup tables
* automatically generate functions to mimic the BSE function 
* replace calls to BSE functions with macros which can either call the
   original BSE functions, or tables
* replace BSE tables with new tables based on newer stellar evolution models 

------------------------------------------------------------

* add AMCVN stars to the ensemble, fix SDB (it's wrong!)
* use cmake
* binary_grid::C segfault catcher?
* s-process yields in COWDs ejecting material
* SNIa yields as f(Z)
* fix MATTSSON mass loss so that it actually works
* fix Monte Carlo in binary_grid so it actually works
* check FORTRAN API
* python wrapper?
* mass lost at AIC should be gravitational, not actually yielded to the ISM!