fix login infinite loop bug

UserMicroservice/Controllers/UserController.cs

@@ -47,7 +47,7 @@ namespace UserMicroservice.Controllers
         {
             string? refreshToken = Request.Cookies["RefreshToken"];
             if (string.IsNullOrEmpty(refreshToken))
-                return BadRequest("Refresh token is missing.");
+                return Unauthorized("Refresh token is missing.");
 
             if (!_authService.ValidateRefreshToken(refreshToken))
                 return Unauthorized("Invalid or expired refresh token.");

client/src/components/Login/Login.tsx

@@ -23,16 +23,20 @@ export function Login() {
 
     try {
       const result = await loginUser(formValue);
-      giveAuth();
-      updateUser(result.data);
-      navigate(`/${userToDashboard(result.data)}`);
+      if (result) {
+        giveAuth();
+        updateUser(result.data);
+        navigate(`/${userToDashboard(result.data)}`);
+      } else {
+        throw new Error();
+      }
     } catch (error) {
       const errorMessage = (error as AxiosError).response?.data;
 
       if (typeof errorMessage == 'string') {
         setError(errorMessage);
       } else {
-        setError('An unexpected error has occurred');
+        setError('An unexpected error has occurred, most likely incorrect credentials');
       }
     }
   };

client/src/helpers/Api.ts

@@ -6,11 +6,19 @@ const Api = axios.create({
   baseURL: 'http://localhost:5267/api/'
 });
 
+const isAlreadyAuthUrl = (error: AxiosError) => {
+  const full = error.request.responseURL as string;
+  return full.endsWith('User/authorize');
+};
+
 Api.interceptors.response.use(
   (response) => response, // Normal success logic
   (error: AxiosError) => {
-    if (error.request.status === 401) { // If 401 (Unauthorized)
-      AuthoriseUser().then(() => { // Re-auth
+    if (error.request.status === 401 && !isAlreadyAuthUrl(error)) { // If 401 (Unauthorized)
+      AuthoriseUser().then((response: any) => { // Re-auth
+        if (!response) // If no response then just return
+          return;
+
         return Api.request(error.config as AxiosRequestConfig); // Redo the request
       });
     } else {