Skip to content
Snippets Groups Projects
Commit b0c842c3 authored by Butler, Alexis (UG - Computer Science)'s avatar Butler, Alexis (UG - Computer Science)
Browse files

Update Marking.md

parent 81f7e523
Branches master
No related tags found
No related merge requests found
| Question | Comment |
|----------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| Are the routes tailored | routes.rb |
| use of GIT | gitlab repo: https://gitlab.eps.surrey.ac.uk/ab02259/com2025-coursework github repo: https://github.com/Abutler101/Com2025-Coursework |
| use of Localised strings | All views and config/locales/en.yml |
| Commenting | All models, and controller methods have intro comment |
| Models and associations | Model files Orders belong to users and have many order entries Order entries belong to a product and an order Products belong to a section and have many reviews Reviews belong to a product and a user Sections have many products Users have many reviews and many orders |
| Validation of models | Uniqueness of fields is validated where appropriate user passwords are validated using bcrypt Not Null-ness is validated where necessary |
| Testing | Model tests are all written and pass |
| Advanced features | Scopes and local model methods were not implemented |
| How is the mailer | Mailer included with basic aesthetic modifications |
| Client side validation | Mailer form and signup form are validated client side with JS - application.js |
| Appropriate error messages | Validations provide guidance as to required correct content |
| Testing of Mailer | Mailer test and preview included - test/mailers |
| Controllers included | All controllers are present with un-needed methods removed and strong params are used where necessary |
| Testing | Controller tests are all written and pass |
| Advanced features | Helper methods and inheritance used to DRY admin and user authentication |
| View tailoring | All views are present and differ from defaults in an attempt to clearly layout content |
| Partials | Partials are used to populate tables such as the product display on the home page |
| Best Practice | Bootstrap is used for the navbar along with product focus page. The project uses a html5 boilerplate template |
| Responsive design | Navbar responds to window size switching to a drop down pain when small enough. Product focus page makes use of bootstrap grid system |
| Advanced Views | JS is used to validate forms but nothing more. Views are fairly simplistic |
\ No newline at end of file
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment