From b1c1cba975e2d6978d74a35016609eb50b2d1556 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcin=20=C5=9Alusarz?= <marcin.slusarz@intel.com> Date: Fri, 18 Oct 2019 18:34:59 +0200 Subject: [PATCH] common: remove duplicated empty lines --- CONTRIBUTING.md | 1 - LICENSE | 1 - README.md | 6 ------ doc/Makefile | 4 ---- doc/daxio/daxio.1.md | 5 ----- doc/libpmem/libpmem.7.md | 10 ---------- doc/libpmem/pmem_flush.3.md | 6 ------ doc/libpmem/pmem_is_pmem.3.md | 6 ------ doc/libpmem/pmem_memmove_persist.3.md | 5 ----- doc/libpmem2/libpmem2.7.md | 6 ------ doc/libpmem2/pmem2_config.3.md | 4 ---- doc/libpmem2/pmem2_errormsg.3.md | 5 ----- doc/libpmem2/pmem2_mapping.3.md | 4 ---- doc/libpmemblk/libpmemblk.7.md | 11 ----------- doc/libpmemblk/pmemblk_bsize.3.md | 5 ----- doc/libpmemblk/pmemblk_create.3.md | 6 ------ doc/libpmemblk/pmemblk_ctl_get.3.md | 5 ----- doc/libpmemblk/pmemblk_read.3.md | 4 ---- doc/libpmemblk/pmemblk_set_zero.3.md | 5 ----- doc/libpmemlog/libpmemlog.7.md | 11 ----------- doc/libpmemlog/pmemlog_append.3.md | 6 ------ doc/libpmemlog/pmemlog_create.3.md | 6 ------ doc/libpmemlog/pmemlog_ctl_get.3.md | 4 ---- doc/libpmemlog/pmemlog_nbyte.3.md | 4 ---- doc/libpmemlog/pmemlog_tell.3.md | 4 ---- doc/libpmemobj/libpmemobj.7.md | 7 ------- doc/libpmemobj/oid_is_null.3.md | 3 --- doc/libpmemobj/pmemobj_action.3.md | 2 -- doc/libpmemobj/pmemobj_alloc.3.md | 5 ----- doc/libpmemobj/pmemobj_ctl_get.3.md | 5 ----- doc/libpmemobj/pmemobj_first.3.md | 4 ---- doc/libpmemobj/pmemobj_list_insert.3.md | 5 ----- doc/libpmemobj/pmemobj_memcpy_persist.3.md | 4 ---- doc/libpmemobj/pmemobj_mutex_zero.3.md | 5 ----- doc/libpmemobj/pmemobj_open.3.md | 5 ----- doc/libpmemobj/pmemobj_root.3.md | 5 ----- doc/libpmemobj/pmemobj_tx_add_range.3.md | 5 ----- doc/libpmemobj/pmemobj_tx_alloc.3.md | 4 ---- doc/libpmemobj/pmemobj_tx_begin.3.md | 4 ---- doc/libpmemobj/pobj_layout_begin.3.md | 5 ----- doc/libpmemobj/pobj_list_head.3.md | 4 ---- doc/libpmemobj/toid_declare.3.md | 4 ---- doc/libpmempool/libpmempool.7.md | 8 -------- doc/libpmempool/pmempool_check_init.3.md | 7 ------- doc/libpmempool/pmempool_feature_query.3.md | 3 --- doc/libpmempool/pmempool_rm.3.md | 5 ----- doc/libpmempool/pmempool_sync.3.md | 8 -------- doc/librpmem/librpmem.7.md | 13 ------------- doc/librpmem/rpmem_create.3.md | 7 ------- doc/librpmem/rpmem_persist.3.md | 6 ------ doc/pmem_ctl/pmem_ctl.5.md | 2 -- doc/pmempool/pmempool-check.1.md | 5 ----- doc/pmempool/pmempool-convert.1.md | 1 - doc/pmempool/pmempool-create.1.md | 7 ------- doc/pmempool/pmempool-dump.1.md | 6 ------ doc/pmempool/pmempool-feature.1.md | 7 ------- doc/pmempool/pmempool-info.1.md | 12 ------------ doc/pmempool/pmempool-rm.1.md | 6 ------ doc/pmempool/pmempool-sync.1.md | 2 -- doc/pmempool/pmempool-transform.1.md | 6 ------ doc/pmempool/pmempool.1.md | 5 ----- doc/pmreorder/pmreorder.1.md | 10 ---------- doc/poolset/poolset.5.md | 6 ------ doc/rpmemd/rpmemd.1.md | 8 -------- src/common/ctl.c | 2 -- src/common/os_auto_flush_linux.c | 1 - src/common/os_auto_flush_windows.h | 3 +-- src/common/os_dimm_ndctl.c | 1 - src/common/os_thread.h | 3 +-- src/common/os_windows.c | 2 -- src/common/rand.c | 1 - src/common/set.c | 2 -- src/common/util.h | 1 - src/common/vec.h | 1 - src/examples/libpmemobj/hashmap/hashmap_tx.c | 3 +-- src/examples/libpmemobj/libart/art.c | 3 +-- src/examples/libpmemobj/libart/art.h | 2 +- src/examples/libpmemobj/map/mapcli.c | 3 +-- src/examples/libpmemobj/pi.c | 3 +-- src/examples/libpmemobj/pmemblk/obj_pmemblk.c | 3 +-- src/examples/libpmemobj/pmemlog/obj_pmemlog.c | 3 +-- .../libpmemobj/pmemlog/obj_pmemlog_macros.c | 3 +-- src/examples/libpmemobj/pmemobjfs/Makefile | 3 +-- src/examples/libpmemobj/pmemobjfs/pmemobjfs.c | 4 ---- src/examples/libpmemobj/pminvaders/Makefile | 3 +-- src/examples/libpmemobj/pminvaders/pminvaders.c | 3 +-- src/examples/libpmemobj/pminvaders/pminvaders2.c | 5 +---- src/examples/libpmemobj/string_store/layout.h | 3 +-- src/examples/libpmemobj/string_store_tx/layout.h | 3 +-- src/examples/libpmemobj/tree_map/btree_map.c | 5 +---- src/examples/libpmemobj/tree_map/ctree_map.c | 4 +--- src/examples/libpmemobj/tree_map/rbtree_map.c | 4 +--- src/examples/libpmemobj/tree_map/rtree_map.c | 5 +---- src/include/libpmemobj/base.h | 1 - src/include/libpmemobj/iterator.h | 3 +-- src/include/libpmemobj/iterator_base.h | 3 +-- src/include/libpmemobj/tx.h | 1 - src/include/libpmempool.h | 3 --- src/libpmemblk/blk.c | 1 - src/libpmemblk/blk.h | 1 - src/libpmemblk/btt.c | 1 - src/libpmemobj/alloc_class.h | 3 +-- src/libpmemobj/critnib.c | 1 - src/libpmemobj/list.c | 1 - src/libpmemobj/obj.c | 1 - src/libpmemobj/pmalloc.c | 1 - src/libpmemobj/tx.c | 4 ---- src/libpmempool/check_write.c | 1 - src/libpmempool/replica.c | 2 -- src/libpmempool/replica.h | 3 +-- src/libpmempool/sync.c | 4 +--- src/libpmempool/transform.c | 1 - src/librpmem/rpmem_fip.c | 2 -- src/librpmem/rpmem_obc.c | 3 +-- src/librpmem/rpmem_ssh.c | 1 - src/test/README | 2 -- src/test/RUNTESTLIB.PS1 | 3 +-- src/test/RUNTESTS.PS1 | 4 +--- src/test/blk_nblock/TEST0w.PS1 | 1 - src/test/blk_pool/README | 1 - src/test/blk_pool_win/blk_pool_win.c | 3 +-- src/test/blk_rw/TEST7 | 1 - src/test/common_badblock.sh | 3 --- src/test/compat_incompat_features/TEST0 | 3 +-- src/test/ctl_prefault/TEST0 | 1 - src/test/ctl_prefault/TEST1 | 1 - src/test/ctl_prefault/TEST2 | 1 - src/test/ex_libpmem/TEST0.PS1 | 1 - src/test/ex_libpmem/TEST1.PS1 | 1 - src/test/ex_libpmemobj/Makefile | 4 +--- src/test/ex_linkedlist/TEST0 | 1 - src/test/ex_linkedlist/TEST1 | 1 - src/test/libpmempool_rm/TEST5 | 3 +-- src/test/libpmempool_rm/libpmempool_rm.c | 3 +-- src/test/libpmempool_rm_win/libpmempool_rm_win.c | 3 +-- src/test/libpmempool_sync/libpmempool_sync.c | 3 +-- src/test/log_basic/README | 5 ----- src/test/log_pool_win/log_pool_win.c | 3 +-- src/test/obj_action/obj_action.c | 3 +-- src/test/obj_basic_integration/TEST0 | 1 - src/test/obj_basic_integration/TEST1 | 1 - src/test/obj_basic_integration/TEST10 | 1 - src/test/obj_basic_integration/TEST2 | 1 - src/test/obj_basic_integration/TEST3 | 1 - src/test/obj_basic_integration/TEST4 | 1 - src/test/obj_basic_integration/TEST5 | 1 - src/test/obj_basic_integration/TEST6 | 1 - src/test/obj_basic_integration/TEST7 | 1 - src/test/obj_basic_integration/TEST8 | 1 - src/test/obj_basic_integration/TEST9 | 1 - src/test/obj_bucket/obj_bucket.c | 1 - src/test/obj_check/TEST0 | 1 - src/test/obj_check/TEST1 | 1 - src/test/obj_check/TEST2 | 1 - src/test/obj_constructor/TEST0 | 1 - src/test/obj_constructor/TEST0.PS1 | 1 - src/test/obj_constructor/TEST1 | 1 - src/test/obj_constructor/TEST2 | 1 - src/test/obj_ctl_alloc_class/TEST0 | 1 - src/test/obj_ctl_alloc_class/TEST0.PS1 | 1 - src/test/obj_ctl_alloc_class_config/TEST0 | 1 - src/test/obj_ctl_alloc_class_config/TEST0.PS1 | 1 - src/test/obj_ctl_config/TEST0 | 1 - src/test/obj_ctl_config/TEST0.PS1 | 1 - src/test/obj_ctl_config/TEST1.PS1 | 1 - src/test/obj_ctl_heap_size/TEST0 | 1 - src/test/obj_ctl_heap_size/TEST1 | 1 - src/test/obj_ctl_stats/TEST0 | 1 - src/test/obj_ctl_stats/TEST1 | 1 - src/test/obj_first_next/TEST0.PS1 | 1 - src/test/obj_first_next/TEST1.PS1 | 1 - src/test/obj_fragmentation/TEST0 | 1 - src/test/obj_fragmentation/TEST1 | 1 - src/test/obj_fragmentation/TEST2 | 1 - src/test/obj_fragmentation2/TEST0 | 1 - src/test/obj_fragmentation2/TEST1 | 1 - src/test/obj_fragmentation2/TEST2 | 1 - src/test/obj_fragmentation2/TEST3 | 1 - src/test/obj_fragmentation2/TEST4 | 1 - src/test/obj_fragmentation2/TEST5 | 1 - src/test/obj_fragmentation2/TEST6 | 1 - src/test/obj_fragmentation2/TEST7 | 1 - src/test/obj_fragmentation2/TEST8 | 1 - src/test/obj_heap/TEST0.PS1 | 1 - src/test/obj_heap_interrupt/obj_heap_interrupt.c | 2 -- src/test/obj_heap_state/TEST0 | 1 - src/test/obj_heap_state/TEST0.PS1 | 1 - src/test/obj_heap_state/TEST1 | 1 - src/test/obj_heap_state/TEST1.PS1 | 1 - src/test/obj_heap_state/TEST2 | 1 - src/test/obj_heap_state/TEST2.PS1 | 1 - src/test/obj_lane/TEST0.PS1 | 1 - src/test/obj_lane/TEST1.PS1 | 1 - src/test/obj_layout/obj_layout.c | 1 - src/test/obj_list/obj_list_mocks.c | 3 +-- src/test/obj_list_macro/TEST0 | 1 - src/test/obj_list_macro/TEST1 | 1 - src/test/obj_list_macro/obj_list_macro.c | 3 +-- src/test/obj_many_size_allocs/TEST0 | 1 - src/test/obj_many_size_allocs/TEST1 | 1 - src/test/obj_many_size_allocs/TEST1.PS1 | 1 - src/test/obj_many_size_allocs/TEST2 | 1 - src/test/obj_many_size_allocs/TEST2.PS1 | 1 - src/test/obj_many_size_allocs/TEST3 | 1 - src/test/obj_memops/TEST0 | 1 - src/test/obj_memops/obj_memops.c | 1 - src/test/obj_out_of_memory/TEST0 | 1 - src/test/obj_out_of_memory/TEST1 | 1 - src/test/obj_out_of_memory/TEST2 | 1 - src/test/obj_persist_count/obj_persist_count.c | 4 +--- src/test/obj_pmalloc_basic/TEST0.PS1 | 1 - src/test/obj_pmalloc_basic/obj_pmalloc_basic.c | 1 - src/test/obj_pmalloc_mt/obj_pmalloc_mt.c | 1 - src/test/obj_pmalloc_oom_mt/TEST0 | 1 - src/test/obj_pmalloc_oom_mt/TEST0.PS1 | 1 - src/test/obj_realloc/TEST1 | 1 - src/test/obj_recreate/TEST0 | 1 - src/test/obj_recreate/TEST1 | 1 - src/test/obj_rpmem_basic_integration/TEST0 | 2 -- src/test/obj_rpmem_heap_state/TEST0 | 1 - src/test/obj_rpmem_heap_state/TEST1 | 1 - src/test/obj_rpmem_heap_state/TEST2 | 1 - src/test/obj_sds/TEST5 | 1 - src/test/obj_sds/obj_sds.c | 1 - src/test/obj_tx_add_range/obj_tx_add_range.c | 4 ---- .../obj_tx_add_range_direct.c | 1 - src/test/obj_tx_callbacks/obj_tx_callbacks.c | 3 +-- src/test/obj_tx_flow/obj_tx_flow.c | 1 - src/test/obj_tx_locks/obj_tx_locks.c | 3 +-- src/test/obj_tx_realloc/obj_tx_realloc.c | 4 +--- src/test/obj_zones/TEST0 | 1 - src/test/pmem_include/pmem_include.c | 3 +-- .../pmem_is_pmem_windows/pmem_is_pmem_windows.c | 1 - src/test/pmem_map_file/pmem_map_file.c | 1 - src/test/pmem_map_file_win/pmem_map_file_win.c | 3 +-- src/test/pmempool_help/README | 2 -- src/test/pmempool_info_remote/TEST0 | 3 +-- src/test/pmempool_rm/TEST12.PS1 | 1 - src/test/pmempool_sync/TEST28 | 1 - src/test/pmemspoil/TEST0 | 3 +-- src/test/remote_basic/TEST1 | 1 - src/test/rpmem_basic/TEST2 | 1 - src/test/rpmem_fip/TEST0 | 1 - src/test/rpmem_fip/TEST1 | 1 - src/test/rpmem_fip/TEST2 | 1 - src/test/rpmem_fip/TEST3 | 1 - src/test/rpmem_fip/TEST4 | 1 - src/test/rpmem_fip/TEST5 | 1 - src/test/rpmem_fip/TEST6 | 1 - src/test/rpmem_fip/TEST7 | 1 - src/test/rpmem_obc/Makefile | 3 +-- src/test/rpmem_obc/TEST3 | 1 - src/test/rpmem_obc_int/TEST0 | 1 - src/test/rpmem_obc_int/rpmem_obc_int.c | 4 +--- src/test/rpmemd_config/README | 2 -- src/test/rpmemd_dbg/TEST1 | 1 - src/test/rpmemd_dbg/TEST2 | 1 - src/test/rpmemd_obc/TEST0 | 1 - src/test/rpmemd_obc/TEST1 | 1 - src/test/rpmemd_obc/TEST2 | 1 - src/test/rpmemd_obc/TEST3 | 1 - src/test/rpmemd_obc/TEST4 | 1 - src/test/rpmemd_obc/rpmemd_obc_test_common.c | 4 +--- src/test/set_funcs/set_funcs.c | 3 --- src/test/tools/bttcreate/bttcreate.c | 3 +-- src/test/tools/cmpmap/cmpmap.c | 1 - src/test/tools/fip/fip.c | 3 +-- src/test/tools/obj_verify/obj_verify.c | 3 +-- src/test/tools/pmemdetect/pmemdetect.c | 3 +-- src/test/tools/pmemobjcli/pmemobjcli.c | 2 -- src/test/tools/pmemspoil/README | 1 - src/test/tools/pmemspoil/spoil.c | 1 - src/test/tools/pmemwrite/write.c | 3 +-- src/test/tools/sparsefile/TEST_SPARSE.ps1 | 5 +---- .../usc_permission_check/usc_permission_check.c | 3 +-- src/test/unicode_api/TEST0 | 1 - src/test/unittest/unittest.h | 1 - src/test/unittest/unittest.ps1 | 3 --- src/test/unittest/unittest.sh | 2 -- src/test/unittest/ut.c | 1 - src/test/util_badblock/util_badblock.c | 1 - src/test/util_ctl/TEST0 | 1 - src/test/util_ctl/TEST1 | 1 - src/test/util_poolset/TEST0 | 1 - src/test/util_poolset/mocks_windows.c | 3 +-- src/test/util_poolset_parse/util_poolset_parse.c | 2 -- src/test/util_sds/util_sds.c | 3 +-- src/tools/Makefile.inc | 2 -- src/tools/pmempool/README | 1 - src/tools/pmempool/create.c | 1 - src/tools/rpmemd/rpmemd_obc.c | 4 +--- src/windows/include/platform.h | 3 +-- src/windows/win_mmap.c | 1 - utils/build-dpkg.sh | 4 ---- utils/build-rpm.sh | 5 +---- utils/check-shebang.sh | 5 +---- utils/get_aliases.sh | 1 - 297 files changed, 63 insertions(+), 705 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a77fdcb0c..8ac7bd9b8 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -101,7 +101,6 @@ To check or format C++ files, you may use a standalone Visual Studio plugin for clang-format. The plugin installer can be downloaded from [LLVM Builds](http://llvm.org/builds) page. - If you are actively working on an PMDK feature, please let other developers know by [creating an issue](https://github.com/pmem/issues/issues). Use the template `Feature` and assign it to yourself (due to the way diff --git a/LICENSE b/LICENSE index 9c9a6d6b9..aab2430c1 100644 --- a/LICENSE +++ b/LICENSE @@ -28,7 +28,6 @@ THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. - Everything in this source tree is covered by the previous license with the following exceptions: diff --git a/README.md b/README.md index 9110b3996..c1bdaec94 100644 --- a/README.md +++ b/README.md @@ -74,10 +74,8 @@ Getting Started with Persistent Memory Programming is a tutorial series created - Part 4: [Thinking Transactionally](https://software.intel.com/en-us/videos/thinking-transactionally-persistent-memory-programming-series) - Part 5: [A C++ Example](https://software.intel.com/en-us/videos/a-c-example-persistent-memory-programming-series) - Additionally, we recommend reading [Introduction to Programming with Persistent Memory from Intel](https://software.intel.com/en-us/articles/introduction-to-programming-with-persistent-memory-from-intel) - ## Version Conventions - **Builds** are tagged something like `0.2+b1`, which means _Build 1 on top of version 0.2_ @@ -157,7 +155,6 @@ see https://github.com/pmem/issues/issues/1039. ><sup>4</sup> The pkg version of ncurses is required for proper operation; the base version included in FreeBSD is not sufficient. - ## Building PMDK on Linux or FreeBSD To build from source, clone this tree: @@ -207,7 +204,6 @@ For example: ``` Once make completes, all the libraries and examples are built. You can play with the library within the build tree, or install it locally on your machine. For information about running different types of tests, please refer to the [src/test/README](src/test/README). - **Installing the library** is convenient since it installs man pages and libraries in the standard system locations: ``` (as root...) @@ -232,7 +228,6 @@ This will install files to /tmp/usr/lib, /tmp/usr/include /tmp/usr/share/man. ``` This call requires the following dependencies: **pandoc**. Pandoc is provided by the hs-pandoc package on FreeBSD. - **Install copy of source tree** can be done by specifying the path where you want it installed. ``` $ make source DESTDIR=some_path @@ -250,7 +245,6 @@ To build rpm packages without running tests: ``` This requires **rpmbuild** to be installed. - **Build dpkg packages** on Debian-based distributions is done by: ``` $ make dpkg diff --git a/doc/Makefile b/doc/Makefile index 8daa60755..77ea527fb 100644 --- a/doc/Makefile +++ b/doc/Makefile @@ -51,13 +51,11 @@ MANPAGES_3_MD = libpmem/pmem_flush.3.md libpmem/pmem_is_pmem.3.md libpmem/pmem_m libpmempool/pmempool_check_init.3.md libpmempool/pmempool_feature_query.3.md libpmempool/pmempool_rm.3.md libpmempool/pmempool_sync.3.md \ libpmem2/pmem2_errormsg.3.md libpmem2/pmem2_config.3.md libpmem2/pmem2_mapping.3.md - MANPAGES_1_MD = pmempool/pmempool.1.md pmempool/pmempool-info.1.md pmempool/pmempool-create.1.md \ pmempool/pmempool-check.1.md pmempool/pmempool-dump.1.md pmempool/pmempool-rm.1.md \ pmempool/pmempool-convert.1.md pmempool/pmempool-sync.1.md pmempool/pmempool-transform.1.md \ pmempool/pmempool-feature.1.md pmreorder/pmreorder.1.md - MANPAGES_3_DUMMY = pmem_drain.3 pmem_has_hw_drain.3 pmem_has_auto_flush.3 \ pmem_persist.3 pmem_msync.3 pmem_map_file.3 pmem_deep_persist.3 pmem_deep_flush.3 pmem_deep_drain.3 pmem_unmap.3 \ pmem_memcpy_persist.3 pmem_memset_persist.3 pmem_memmove_nodrain.3 pmem_memcpy_nodrain.3 pmem_memset_nodrain.3 \ @@ -110,12 +108,10 @@ MANPAGES_3_DUMMY = pmem_drain.3 pmem_has_hw_drain.3 pmem_has_auto_flush.3 \ pmem2_config_new.3 pmem2_config_delete.3 pmem2_config_set_fd.3 pmem2_config_set_handle.3 \ pmem2_map.3 - MANPAGES_BUILDDIR = generated MANPAGES_WEBDIR_LINUX = web_linux MANPAGES_WEBDIR_WINDOWS = web_windows - # experimental MANPAGES_3_MD_EXP = MANPAGES_1_MD_EXP = diff --git a/doc/daxio/daxio.1.md b/doc/daxio/daxio.1.md index 787785bec..023d3bb69 100644 --- a/doc/daxio/daxio.1.md +++ b/doc/daxio/daxio.1.md @@ -43,19 +43,16 @@ date: daxio version 1.4 [EXAMPLE](#example)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **daxio** - Perform I/O on Device DAX devices or zero a Device DAX device - # SYNOPSIS # ``` $ daxio [<options>] ``` - # DESCRIPTION # The daxio utility performs I/O on Device DAX devices or zero @@ -76,7 +73,6 @@ For a Device DAX device, **daxio** will attempt to clear bad blocks within the range of writes before performing the I/O (it can be turned off using the '--clear-bad-blocks=no' option). - # OPTIONS # `-i, --input` @@ -118,7 +114,6 @@ Prints the version of **daxio**. Prints synopsis and list of options. - # EXAMPLE # ``` diff --git a/doc/libpmem/libpmem.7.md b/doc/libpmem/libpmem.7.md index bb6172934..c4dd5e52f 100644 --- a/doc/libpmem/libpmem.7.md +++ b/doc/libpmem/libpmem.7.md @@ -47,12 +47,10 @@ date: pmem API version 1.1 [ACKNOWLEDGEMENTS](#acknowledgements)<br /> [SEE ALSO](#see-also) - # NAME # **libpmem** - persistent memory support library - # SYNOPSIS # ```c @@ -87,7 +85,6 @@ manual pages: + copying to persistent memory: **pmem_memmove_persist**(3) - # DESCRIPTION # **libpmem** provides low-level *persistent memory* (pmem) support for @@ -117,7 +114,6 @@ intentionally cause the process to exit. The only exception to this is the debugging information, when enabled, as described under **DEBUGGING AND ERROR HANDLING** below. - # CAVEATS # **libpmem** relies on the library destructor being called from the main thread. @@ -125,7 +121,6 @@ For this reason, all functions that might trigger destruction (e.g. **dlclose**(3)) should be called in the main thread. Otherwise some of the resources associated with that thread might not be cleaned up properly. - # LIBRARY API VERSIONING # This section describes how the library API is versioned, allowing @@ -163,7 +158,6 @@ static string describing the reason for failing the version check. The string returned by _UW(pmem_check_version) must not be modified or freed. - # ENVIRONMENT # **libpmem** can change its default behavior based on the following @@ -261,7 +255,6 @@ affects all the PMDK libraries,** disabling mapping address randomization and causing the specified address to be used as a hint about where to place the mapping. - # DEBUGGING AND ERROR HANDLING # If an error is detected during the call to a **libpmem** function, the @@ -320,7 +313,6 @@ is "-", the *PID* of the current process will be appended to the file name when the log file is created. If **PMEM_LOG_FILE** is not set, output is written to *stderr*. - # EXAMPLE # The following example uses **libpmem** to flush changes made to raw, @@ -384,14 +376,12 @@ main(int argc, char *argv[]) See <http://pmem.io/pmdk/libpmem> for more examples using the **libpmem** API. - # ACKNOWLEDGEMENTS # **libpmem** builds on the persistent memory programming model recommended by the SNIA NVM Programming Technical Work Group: <http://snia.org/nvmp> - # SEE ALSO # **dlclose**(3), diff --git a/doc/libpmem/pmem_flush.3.md b/doc/libpmem/pmem_flush.3.md index 96f9830b3..166593b27 100644 --- a/doc/libpmem/pmem_flush.3.md +++ b/doc/libpmem/pmem_flush.3.md @@ -42,7 +42,6 @@ date: pmem API version 1.1 [RETURN VALUE](#return-value)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **pmem_flush**(), **pmem_drain**(), @@ -51,7 +50,6 @@ date: pmem API version 1.1 **pmem_has_hw_drain**(), **pmem_has_auto_flush**() - check persistency, store persistent data and delete mappings - # SYNOPSIS # ```c @@ -68,14 +66,12 @@ int pmem_has_auto_flush(void); (EXPERIMENTAL) int pmem_has_hw_drain(void); ``` - # DESCRIPTION # The functions in this section provide access to the stages of flushing to persistence, for the less common cases where an application needs more control of the flushing operations than the **pmem_persist**() function. - >WARNING: Using **pmem_persist**() on a range where **pmem_is_pmem**(3) returns false may not do anything useful -- use **msync**(2) instead. @@ -191,7 +187,6 @@ The **pmem_has_hw_drain**() function checks if the machine supports an explicit *hardware drain* instruction for persistent memory. - # RETURN VALUE # The **pmem_persist**() function returns no value. @@ -221,7 +216,6 @@ function always returns false. Despite that, programs using **pmem_drain**() once to ensure the flushes are complete. As mentioned above, **pmem_persist**() handles calling both **pmem_flush**() and **pmem_drain**(). - # SEE ALSO # **msync**(2), **pmem_is_pmem**(3), **libpmem**(7) diff --git a/doc/libpmem/pmem_is_pmem.3.md b/doc/libpmem/pmem_is_pmem.3.md index d29762268..c4b4121e1 100644 --- a/doc/libpmem/pmem_is_pmem.3.md +++ b/doc/libpmem/pmem_is_pmem.3.md @@ -45,13 +45,11 @@ date: pmem API version 1.1 [BUGS](#bugs)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **pmem_is_pmem**(), _UW(pmem_map_file), **pmem_unmap**() - check persistency, create and delete mappings - # SYNOPSIS # ```c @@ -146,7 +144,6 @@ address specified by the parameter *addr*, where *addr* must be a previously mapped region. **pmem_unmap**() will delete the mappings using **munmap**(2). - # RETURN VALUE # The **pmem_is_pmem**() function returns true only if the entire range @@ -163,7 +160,6 @@ On error, it returns NULL, sets *errno* appropriately, and does not modify On success, **pmem_unmap**() returns 0. On error, it returns -1 and sets *errno* appropriately. - # NOTES # On Linux, **pmem_is_pmem**() returns true only if the entire range @@ -172,7 +168,6 @@ file system. In the future, as file systems become available that support flushing with **pmem_persist**(3), **pmem_is_pmem**() will return true as appropriate. - # CAVEATS # The result of **pmem_is_pmem**() query is only valid for the mappings @@ -184,7 +179,6 @@ Not all file systems support **posix_fallocate**(3). _UW(pmem_map_file) will fail if **PMEM_FILE_CREATE** is specified without **PMEM_FILE_SPARSE** and the underlying file system does not support **posix_fallocate**(3). - # SEE ALSO # **creat**(2), **ftruncate**(2), **mmap**(2), **msync**(2), **munmap**(2), diff --git a/doc/libpmem/pmem_memmove_persist.3.md b/doc/libpmem/pmem_memmove_persist.3.md index 153f90279..9512e3678 100644 --- a/doc/libpmem/pmem_memmove_persist.3.md +++ b/doc/libpmem/pmem_memmove_persist.3.md @@ -42,7 +42,6 @@ date: pmem API version 1.1 [RETURN VALUE](#return-value)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **pmem_memmove**(), **pmem_memcpy**(), **pmem_memset**(), @@ -50,7 +49,6 @@ date: pmem API version 1.1 **pmem_memmove_nodrain**(), **pmem_memcpy_nodrain**(), **pmem_memset_nodrain**() - functions that provide optimized copying to persistent memory - # SYNOPSIS # ```c @@ -67,7 +65,6 @@ void *pmem_memcpy_nodrain(void *pmemdest, const void *src, size_t len); void *pmem_memset_nodrain(void *pmemdest, int c, size_t len); ``` - # DESCRIPTION # **pmem_memmove**(), **pmem_memcpy**() and **pmem_memset**() functions provide @@ -162,7 +159,6 @@ details. All of the above functions return address of the destination buffer. - # CAVEATS # After calling any of the functions with **PMEM_F_MEM_NODRAIN** flag you should not expect memory to be visible to other threads before calling @@ -171,7 +167,6 @@ x86\_64 those functions may use non-temporal store instructions, which are weakly ordered. See "Intel 64 and IA-32 Architectures Software Developer's Manual", Volume 1, "Caching of Temporal vs. Non-Temporal Data" section for details. - # SEE ALSO # **memcpy**(3), **memmove**(3), **memset**(3), diff --git a/doc/libpmem2/libpmem2.7.md b/doc/libpmem2/libpmem2.7.md index c96b69a88..dff3641f7 100644 --- a/doc/libpmem2/libpmem2.7.md +++ b/doc/libpmem2/libpmem2.7.md @@ -46,12 +46,10 @@ date: pmem2 API version 1.0 [ACKNOWLEDGEMENTS](#acknowledgements)<br /> [SEE ALSO](#see-also) - # NAME # **libpmem2** - persistent memory support library (EXPERIMENTAL) - # SYNOPSIS # ```c @@ -59,14 +57,12 @@ date: pmem2 API version 1.0 cc ... -lpmem2 ``` - # DESCRIPTION # # CAVEATS # # ENVIRONMENT # - # DEBUGGING # Two versions of **libpmem2** are typically available on a development @@ -112,7 +108,6 @@ is "-", the *PID* of the current process will be appended to the file name when the log file is created. If **PMEM2_LOG_FILE** is not set, output is written to *stderr*. - # EXAMPLE # # ACKNOWLEDGEMENTS # @@ -121,7 +116,6 @@ written to *stderr*. by the SNIA NVM Programming Technical Work Group: <http://snia.org/nvmp> - # SEE ALSO # **libpmem**(7), **libpmemblk**(7), **libpmemlog**(7), **libpmemobj**(7) diff --git a/doc/libpmem2/pmem2_config.3.md b/doc/libpmem2/pmem2_config.3.md index 1a7bc0081..fea1e466d 100644 --- a/doc/libpmem2/pmem2_config.3.md +++ b/doc/libpmem2/pmem2_config.3.md @@ -42,13 +42,11 @@ date: pmem2 API version 1.0 [RETURN VALUE](#return-value)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **pmem2_config_new**(), **pmem2_config_delete**(), **pmem2_config_set_fd**(), **pmem2_config_set_handle**() - # SYNOPSIS # ```c @@ -62,10 +60,8 @@ int pmem2_config_set_handle(struct pmem2_config *cfg, HANDLE handle); (XXX: WIND # DESCRIPTION # - # RETURN VALUE # - # SEE ALSO # **libpmem2**(7) and **<http://pmem.io>** diff --git a/doc/libpmem2/pmem2_errormsg.3.md b/doc/libpmem2/pmem2_errormsg.3.md index c0285aec3..f819c1e52 100644 --- a/doc/libpmem2/pmem2_errormsg.3.md +++ b/doc/libpmem2/pmem2_errormsg.3.md @@ -42,12 +42,10 @@ date: pmem2 API version 1.0 [RETURN VALUE](#return-value)<br /> [SEE ALSO](#see-also)<br /> - # NAME # _UW(pmem2_errormsg) - returns last error message - # SYNOPSIS # ```c @@ -58,7 +56,6 @@ _UWFUNC(pmem2_errormsg, void) _UNICODE() - # DESCRIPTION # If an error is detected during the call to a **libpmem2**(7) function, the @@ -71,7 +68,6 @@ call to a **libpmem2**(7) function indicated an error. The application must not modify or free the error message string. Subsequent calls to other library functions may modify the previous message. - # RETURN VALUE # The _UW(pmem2_errormsg) function returns a pointer to a static buffer @@ -79,7 +75,6 @@ containing the last error message logged for the current thread. If *errno* was set, the error message may include a description of the corresponding error code as returned by **strerror**(3). - # SEE ALSO # **strerror**(3), **libpmem2**(7) and **<http://pmem.io>** diff --git a/doc/libpmem2/pmem2_mapping.3.md b/doc/libpmem2/pmem2_mapping.3.md index 31fd435a3..124a4f18f 100644 --- a/doc/libpmem2/pmem2_mapping.3.md +++ b/doc/libpmem2/pmem2_mapping.3.md @@ -42,12 +42,10 @@ date: pmem2 API version 1.0 [RETURN VALUE](#return-value)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **pmem2_map**() - create mapping on the file - # SYNOPSIS # ```c @@ -58,10 +56,8 @@ int pmem2_map(const struct pmem2_config *cfg, struct pmem2_map **map_ptr); # DESCRIPTION # - # RETURN VALUE # - # SEE ALSO # **libpmem2**(7) and **<http://pmem.io>** diff --git a/doc/libpmemblk/libpmemblk.7.md b/doc/libpmemblk/libpmemblk.7.md index 19beb2ee3..f5e8cab8c 100644 --- a/doc/libpmemblk/libpmemblk.7.md +++ b/doc/libpmemblk/libpmemblk.7.md @@ -47,12 +47,10 @@ date: pmemblk API version 1.1 [ACKNOWLEDGEMENTS](#acknowledgements)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **libpmemblk** - persistent memory resident array of blocks - # SYNOPSIS # ```c @@ -95,7 +93,6 @@ manual pages: **pmemblk_ctl_exec**(3), **pmemblk_ctl_get**(3), **pmemblk_ctl_set**(3), **pmemblk_read**(3), **pmemblk_set_zero**(3), - # DESCRIPTION # **libpmemblk** @@ -141,7 +138,6 @@ on whether the memory pool appears to be persistent memory or a regular file There is no need for applications to flush changes directly when using the block memory API provided by **libpmemblk**. - # CAVEATS # **libpmemblk** relies on the library destructor being called from the main @@ -149,7 +145,6 @@ thread. For this reason, all functions that might trigger destruction (e.g. **dlclose**(3)) should be called in the main thread. Otherwise some of the resources associated with that thread might not be cleaned up properly. - # LIBRARY API VERSIONING # This section describes how the library API is versioned, @@ -185,7 +180,6 @@ the return value is NULL. Otherwise the return value is a static string describing the reason for failing the version check. The string returned by _UW(pmemblk_check_version) must not be modified or freed. - # MANAGING LIBRARY BEHAVIOR # The **pmemblk_set_funcs**() function allows an application to override memory @@ -195,7 +189,6 @@ the **libpmemblk** default function to be used. The library does not make heavy use of the system malloc functions, but it does allocate approximately 4-8 kilobytes for each memory pool in use. - # DEBUGGING AND ERROR HANDLING # The _UW(pmemblk_errormsg) function returns a pointer to a static buffer @@ -257,7 +250,6 @@ output is written to *stderr*. See also **libpmem**(7) for information on other environment variables that may affect **libpmemblk** behavior. - # EXAMPLE # The following example illustrates how the **libpmemblk** API is used. @@ -326,20 +318,17 @@ main(int argc, char *argv[]) See <http://pmem.io/pmdk/libpmemblk> for more examples using the **libpmemblk** API. - # BUGS # Unlike **libpmemobj**(7), data replication is not supported in **libpmemblk**. Thus, specifying replica sections in pool set files is not allowed. - # ACKNOWLEDGEMENTS # **libpmemblk** builds on the persistent memory programming model recommended by the SNIA NVM Programming Technical Work Group: <http://snia.org/nvmp> - # SEE ALSO # **msync**(2), **dlclose**(3), **pmemblk_bsize**(3), **pmemblk_create**(3), diff --git a/doc/libpmemblk/pmemblk_bsize.3.md b/doc/libpmemblk/pmemblk_bsize.3.md index 8996722cf..a599dada9 100644 --- a/doc/libpmemblk/pmemblk_bsize.3.md +++ b/doc/libpmemblk/pmemblk_bsize.3.md @@ -42,13 +42,11 @@ date: pmemblk API version 1.1 [RETURN VALUE](#return-value)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **pmemblk_bsize**(), **pmemblk_nblock**() - check number of available blocks or usable space in block memory pool - # SYNOPSIS # ```c @@ -58,7 +56,6 @@ size_t pmemblk_bsize(PMEMblkpool *pbp); size_t pmemblk_nblock(PMEMblkpool *pbp); ``` - # DESCRIPTION # The **pmemblk_bsize**() function returns the block size of the specified @@ -70,7 +67,6 @@ The **pmemblk_nblock**() function returns the usable space in the block memory pool. *pbp* must be a block memory pool handle as returned by **pmemblk_open**(3) or **pmemblk_create**(3). - # RETURN VALUE # The **pmemblk_bsize**() function returns the block size of the specified block @@ -79,7 +75,6 @@ memory pool. The **pmemblk_nblock**() function returns the usable space in the block memory pool, expressed as the number of blocks available. - # SEE ALSO # **pmemblk_create**(3), **pmemblk_open**(3), diff --git a/doc/libpmemblk/pmemblk_create.3.md b/doc/libpmemblk/pmemblk_create.3.md index 892291600..814bb70dd 100644 --- a/doc/libpmemblk/pmemblk_create.3.md +++ b/doc/libpmemblk/pmemblk_create.3.md @@ -42,14 +42,12 @@ date: pmemblk API version 1.1 [RETURN VALUE](#return-value)<br /> [SEE ALSO](#see-also)<br /> - # NAME # _UW(pmemblk_create), _UW(pmemblk_open), **pmemblk_close**(), _UW(pmemblk_check) - create, open, close and validate block pool - # SYNOPSIS # ```c @@ -64,7 +62,6 @@ _UWFUNCR1(int, pmemblk_check, *path, size_t bsize) _UNICODE() - # DESCRIPTION # The _UW(pmemblk_create) function creates a block memory pool with the given @@ -141,7 +138,6 @@ HANDLING** section in **libpmemblk**(7). _UW(pmemblk_check) opens the given *path* read-only so it never makes any changes to the file. This function is not supported on Device DAX. - # RETURN VALUE # On success, _UW(pmemblk_create) returns a *PMEMblkpool\** handle to the block @@ -170,13 +166,11 @@ and does not match the block size given when the pool was created. If the consistency check cannot be performed, _UW(pmemblk_check) returns -1 and sets *errno* appropriately. - # CAVEATS # Not all file systems support **posix_fallocate**(3). _UW(pmemblk_create) will fail if the underlying file system does not support **posix_fallocate**(3). - # SEE ALSO # **pmempool**(1), **creat**(2), **pmemblk_nblock**(3), **posix_fallocate**(3), **poolset**(5), diff --git a/doc/libpmemblk/pmemblk_ctl_get.3.md b/doc/libpmemblk/pmemblk_ctl_get.3.md index 3ae0b5532..16514b0be 100644 --- a/doc/libpmemblk/pmemblk_ctl_get.3.md +++ b/doc/libpmemblk/pmemblk_ctl_get.3.md @@ -43,7 +43,6 @@ date: pmemblk API version 1.1 [CTL EXTERNAL CONFIGURATION](#ctl-external-configuration)<br /> [SEE ALSO](#see-also)<br /> - # NAME # _UW(pmemblk_ctl_get), @@ -51,7 +50,6 @@ _UW(pmemblk_ctl_set), _UW(pmemblk_ctl_exec) - Query and modify libpmemblk internal behavior (EXPERIMENTAL) - # SYNOPSIS # ```c @@ -67,7 +65,6 @@ _UWFUNCR2(int, pmemblk_ctl_exec, PMEMblkpool *pbp, *name, void *arg, _UNICODE() - # DESCRIPTION # The _UW(pmemblk_ctl_get), _UW(pmemblk_ctl_set) and _UW(pmemblk_ctl_exec) @@ -89,7 +86,6 @@ description. See more in **pmem_ctl**(5) man page. - # CTL NAMESPACE # prefault.at_create | rw | global | int | int | - | boolean @@ -139,7 +135,6 @@ a sequence of ctl queries. See more in **pmem_ctl**(5) man page. - # SEE ALSO # **libpmemblk**(7), **pmem_ctl**(5) and **<http://pmem.io>** diff --git a/doc/libpmemblk/pmemblk_read.3.md b/doc/libpmemblk/pmemblk_read.3.md index 176aa0fda..1fb5960ce 100644 --- a/doc/libpmemblk/pmemblk_read.3.md +++ b/doc/libpmemblk/pmemblk_read.3.md @@ -42,13 +42,11 @@ date: pmemblk API version 1.1 [RETURN VALUE](#return-value)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **pmemblk_read**(), **pmemblk_write**() - read or write a block from a block memory pool - # SYNOPSIS # ```c @@ -58,7 +56,6 @@ int pmemblk_read(PMEMblkpool *pbp, void *buf, long long blockno); int pmemblk_write(PMEMblkpool *pbp, const void *buf, long long blockno); ``` - # DESCRIPTION # The **pmemblk_read**() function reads the block with block number *blockno* @@ -71,7 +68,6 @@ reads and writes. In addition, the write cannot be torn by program failure or system crash; on recovery the block is guaranteed to contain either the old data or the new data, never a mixture of both. - # RETURN VALUE # On success, the **pmemblk_read**() and **pmemblk_write**() functions return 0. diff --git a/doc/libpmemblk/pmemblk_set_zero.3.md b/doc/libpmemblk/pmemblk_set_zero.3.md index 124c157bd..48ca8abb6 100644 --- a/doc/libpmemblk/pmemblk_set_zero.3.md +++ b/doc/libpmemblk/pmemblk_set_zero.3.md @@ -36,19 +36,16 @@ date: pmemblk API version 1.1 [comment]: <> (pmemblk_set_zero.3 -- man page for block management functions) - [NAME](#name)<br /> [SYNOPSIS](#synopsis)<br /> [DESCRIPTION](#description)<br /> [RETURN VALUE](#return-value)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **pmemblk_set_zero**(), **pmemblk_set_error**() - block management functions - # SYNOPSIS # ```c @@ -58,7 +55,6 @@ int pmemblk_set_zero(PMEMblkpool *pbp, long long blockno); int pmemblk_set_error(PMEMblkpool *pbp, long long blockno); ``` - # DESCRIPTION # The **pmemblk_set_zero**() function writes zeros to block number *blockno* in @@ -76,7 +72,6 @@ Writing the block clears the error state and returns the block to normal use. On success, **pmemblk_set_zero**() and **pmemblk_set_error**() return 0. On error, they return -1 and set *errno* appropriately. - # SEE ALSO # **libpmemblk**(7) and **<http://pmem.io>** diff --git a/doc/libpmemlog/libpmemlog.7.md b/doc/libpmemlog/libpmemlog.7.md index 2b52f3b52..0b19235f5 100644 --- a/doc/libpmemlog/libpmemlog.7.md +++ b/doc/libpmemlog/libpmemlog.7.md @@ -48,12 +48,10 @@ date: pmemlog API version 1.1 [ACKNOWLEDGEMENTS](#acknowledgements)<br /> [SEE ALSO](#see-also) - # NAME # **libpmemlog** - persistent memory resident log file - # SYNOPSIS # ```c @@ -96,7 +94,6 @@ manual pages: **pmemlog_ctl_get**(3), **pmemlog_ctl_set**(3), **pmemlog_nbyte**(3), **pmemlog_tell**(3) - # DESCRIPTION # **libpmemlog** @@ -145,7 +142,6 @@ or a regular file (see the **pmem_is_pmem**(3) function in **libpmem**(7) for more information). There is no need for applications to flush changes directly when using the log memory API provided by **libpmemlog**. - # CAVEATS # **libpmemlog** relies on the library destructor being called from the main @@ -153,7 +149,6 @@ thread. For this reason, all functions that might trigger destruction (e.g. **dlclose**(3)) should be called in the main thread. Otherwise some of the resources associated with that thread might not be cleaned up properly. - # LIBRARY API VERSIONING # This section describes how the library API is versioned, @@ -188,7 +183,6 @@ On success, _UW(pmemlog_check_version) returns NULL. Otherwise, the return value is a static string describing the reason the version check failed. The string returned by _UW(pmemlog_check_version) must not be modified or freed. - # MANAGING LIBRARY BEHAVIOR # The **pmemlog_set_funcs**() function allows an application to override @@ -198,7 +192,6 @@ Passing in NULL for any of the handlers will cause the heavy use of the system malloc functions, but it does allocate approximately 4-8 kilobytes for each memory pool in use. - # DEBUGGING AND ERROR HANDLING # The _UW(pmemlog_errormsg) function returns a pointer to a static buffer @@ -256,7 +249,6 @@ process will be appended to the file name when the log file is created. If See also **libpmem**(7) for information about other environment variables affecting **libpmemlog** behavior. - # EXAMPLE # The following example illustrates how the **libpmemlog** API is used. @@ -329,20 +321,17 @@ main(int argc, char *argv[]) See <http://pmem.io/pmdk/libpmemlog> for more examples using the **libpmemlog** API. - # BUGS # Unlike **libpmemobj**(7), data replication is not supported in **libpmemlog**. Thus, specifying replica sections in pool set files is not allowed. - # ACKNOWLEDGEMENTS # **libpmemlog** builds on the persistent memory programming model recommended by the SNIA NVM Programming Technical Work Group: <http://snia.org/nvmp> - # SEE ALSO # **msync**(2), **pmemlog_append**(3), **pmemlog_create**(3), diff --git a/doc/libpmemlog/pmemlog_append.3.md b/doc/libpmemlog/pmemlog_append.3.md index d9f84c94a..f0bced9ea 100644 --- a/doc/libpmemlog/pmemlog_append.3.md +++ b/doc/libpmemlog/pmemlog_append.3.md @@ -43,13 +43,11 @@ date: pmemlog API version 1.1 [NOTES](#notes)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **pmemlog_append**(), **pmemlog_appendv**() - append bytes to the persistent memory resident log file - # SYNOPSIS # ```c @@ -72,13 +70,11 @@ similar to **writev**(2). The entire list of buffers is appended atomically, as if the buffers in *iov* were concatenated in order. The append is atomic and cannot be torn by a program failure or system crash. - # RETURN VALUE # On success, **pmemlog_append**() and **pmemlog_appendv**() return 0. On error, they return -1 and set *errno* appropriately. - # ERRORS # **EINVAL** The vector count *iovcnt* is less than zero. @@ -87,7 +83,6 @@ On error, they return -1 and set *errno* appropriately. **EROFS** The log file is open in read-only mode. - # NOTES # Since **libpmemlog**(7) is designed as a low-latency code path, @@ -95,7 +90,6 @@ many of the checks routinely done by the operating system for **writev**(2) are not practical in the library's implementation of **pmemlog_appendv**(). No attempt is made to detect NULL or incorrect pointers, for example. - # SEE ALSO # **writev**(2), **libpmemlog**(7) and **<http://pmem.io>** diff --git a/doc/libpmemlog/pmemlog_create.3.md b/doc/libpmemlog/pmemlog_create.3.md index 4eccd68c9..ca4221a17 100644 --- a/doc/libpmemlog/pmemlog_create.3.md +++ b/doc/libpmemlog/pmemlog_create.3.md @@ -43,14 +43,12 @@ date: pmemlog API version 1.1 [CAVEATS](#caveats)<br /> [SEE ALSO](#see-also)<br /> - # NAME # _UW(pmemlog_create), _UW(pmemlog_open), **pmemlog_close**(), _UW(pmemlog_check) - create, open, close and validate persistent memory resident log file - # SYNOPSIS # ```c @@ -64,7 +62,6 @@ _UWFUNCR(int, pmemlog_check, *path) _UNICODE() - # DESCRIPTION # The _UW(pmemlog_create) function creates a log memory pool with the given @@ -130,7 +127,6 @@ indicated by *path*. _UW(pmemlog_check) opens the given *path* read-only so it never makes any changes to the file. This function is not supported on Device DAX. - # RETURN VALUE # On success, _UW(pmemlog_create) returns a *PMEMlogpool\** handle to the @@ -157,13 +153,11 @@ as described in the **DEBUGGING AND ERROR HANDLING** section in **libpmemlog**(7). _UW(pmemlog_check) will return -1 and set *errno* if it cannot perform the consistency check due to other errors. - # CAVEATS # Not all file systems support **posix_fallocate**(3). _UW(pmemlog_create) will fail if the underlying file system does not support **posix_fallocate**(3). - # SEE ALSO # **pmempool**(1), **creat**(2), **posix_fallocate**(3), diff --git a/doc/libpmemlog/pmemlog_ctl_get.3.md b/doc/libpmemlog/pmemlog_ctl_get.3.md index 31681fea8..e564bcafc 100644 --- a/doc/libpmemlog/pmemlog_ctl_get.3.md +++ b/doc/libpmemlog/pmemlog_ctl_get.3.md @@ -43,7 +43,6 @@ date: pmemlog API version 1.1 [CTL EXTERNAL CONFIGURATION](#ctl-external-configuration)<br /> [SEE ALSO](#see-also)<br /> - # NAME # _UW(pmemlog_ctl_get), @@ -51,7 +50,6 @@ _UW(pmemlog_ctl_set), _UW(pmemlog_ctl_exec) - Query and modify libpmemlog internal behavior (EXPERIMENTAL) - # SYNOPSIS # ```c @@ -67,7 +65,6 @@ _UWFUNCR2(int, pmemlog_ctl_exec, PMEMlogpool *plp, *name, void *arg, _UNICODE() - # DESCRIPTION # The _UW(pmemlog_ctl_get), _UW(pmemlog_ctl_set) and _UW(pmemlog_ctl_exec) @@ -89,7 +86,6 @@ description. See more in **pmem_ctl**(5) man page. - # CTL NAMESPACE # prefault.at_create | rw | global | int | int | - | boolean diff --git a/doc/libpmemlog/pmemlog_nbyte.3.md b/doc/libpmemlog/pmemlog_nbyte.3.md index 85f69baf4..22bc7f97e 100644 --- a/doc/libpmemlog/pmemlog_nbyte.3.md +++ b/doc/libpmemlog/pmemlog_nbyte.3.md @@ -42,12 +42,10 @@ date: pmemlog API version 1.1 [RETURN VALUE](#return-value)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **pmemlog_nbyte**() - checks the amount of usable space in the log pool. - # SYNOPSIS # ```c @@ -62,12 +60,10 @@ The **pmemlog_nbyte**() function checks the amount of usable space in the log *p This function may be used on a log to determine how much usable space is available after **libpmemlog**(7) has added its metadata to the memory pool. - # RETURN VALUE # The **pmemlog_nbyte**() function returns the amount of usable space in the log *plp*. - # SEE ALSO # **libpmemlog**(7) and **<http://pmem.io>** diff --git a/doc/libpmemlog/pmemlog_tell.3.md b/doc/libpmemlog/pmemlog_tell.3.md index b6ec9a70f..26bf3191d 100644 --- a/doc/libpmemlog/pmemlog_tell.3.md +++ b/doc/libpmemlog/pmemlog_tell.3.md @@ -42,13 +42,11 @@ date: pmemlog API version 1.1 [RETURN VALUE](#return-value)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **pmemlog_tell**(), **pmemlog_rewind**(), **pmemlog_walk**() - checks current write point for the log or walks through the log - # SYNOPSIS # ```c @@ -85,7 +83,6 @@ function is called while holding **libpmemlog**(7) internal locks that make calls atomic, so the callback function must not try to append to the log itself or deadlock will occur. - # RETURN VALUE # On success, **pmemlog_tell**() returns the current write point for the log. @@ -93,7 +90,6 @@ On error, it returns -1 and sets *errno* appropriately. The **pmemlog_rewind**() and **pmemlog_walk**() functions return no value. - # SEE ALSO # **libpmemlog**(7) and **<http://pmem.io>** diff --git a/doc/libpmemobj/libpmemobj.7.md b/doc/libpmemobj/libpmemobj.7.md index 81a9dfe3c..5405b3a25 100644 --- a/doc/libpmemobj/libpmemobj.7.md +++ b/doc/libpmemobj/libpmemobj.7.md @@ -46,12 +46,10 @@ date: pmemobj API version 2.3 [ACKNOWLEDGEMENTS](#acknowledgements)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **libpmemobj** - persistent memory transactional object store - # SYNOPSIS # ```c @@ -149,7 +147,6 @@ cause the process to exit. The only exception to this is the debugging information, when enabled, as described under **DEBUGGING AND ERROR HANDLING**, below. - # LIBRARY API VERSIONING # This section describes how the library API is versioned, @@ -184,7 +181,6 @@ On success, _UW(pmemobj_check_version) returns NULL. Otherwise, the return value is a static string describing the reason the version check failed. The string returned by _UW(pmemobj_check_version) must not be modified or freed. - # MANAGING LIBRARY BEHAVIOR # The **pmemobj_set_funcs**() function allows an application to override memory @@ -258,19 +254,16 @@ be appended to the file name when the log file is created. If See also **libpmem**(7) to get information about other environment variables affecting **libpmemobj** behavior. - # EXAMPLE # See <http://pmem.io/pmdk/libpmemobj> for examples using the **libpmemobj** API. - # ACKNOWLEDGEMENTS # **libpmemobj** builds on the persistent memory programming model recommended by the SNIA NVM Programming Technical Work Group: <http://snia.org/nvmp> - # SEE ALSO # **OID_IS_NULL**(3), **pmemobj_alloc**(3), **pmemobj_ctl_exec**(3), **pmemobj_ctl_get**(3), **pmemobj_ctl_set**(3), **pmemobj_first**(3), **pmemobj_list_insert**(3), **pmemobj_memcpy_persist**(3), **pmemobj_mutex_zero**(3), **pmemobj_open**(3), **pmemobj_root**(3), **pmemobj_tx_add_range**(3), **pmemobj_tx_alloc**(3), **pmemobj_tx_begin**(3), **POBJ_LAYOUT_BEGIN**(3), **POBJ_LIST_HEAD**(3), **strerror**(3), **TOID_DECLARE**(3), **libpmem**(7), **libpmemblk**(7), **libpmemlog**(7) diff --git a/doc/libpmemobj/oid_is_null.3.md b/doc/libpmemobj/oid_is_null.3.md index 02b40d493..168c3e95f 100644 --- a/doc/libpmemobj/oid_is_null.3.md +++ b/doc/libpmemobj/oid_is_null.3.md @@ -43,7 +43,6 @@ date: pmemobj API version 2.3 _WINUX(,[NOTES](#notes)<br />) [SEE ALSO](#see-also)<br /> - # NAME # **OID_IS_NULL**(), **OID_EQUALS**(), @@ -52,7 +51,6 @@ _WINUX(,[NOTES](#notes)<br />) **pmemobj_pool_by_ptr**() - functions that allow mapping operations between object addresses, object handles, oids or type numbers - # SYNOPSIS # ```c @@ -71,7 +69,6 @@ void *pmemobj_volatile(PMEMobjpool *pop, struct pmemvlt *vlt, int (*constr)(void *ptr, void *arg), void *arg); (EXPERIMENTAL) ``` - # DESCRIPTION # Each object stored in a persistent memory pool is represented by an object diff --git a/doc/libpmemobj/pmemobj_action.3.md b/doc/libpmemobj/pmemobj_action.3.md index c08fef029..d75106d47 100644 --- a/doc/libpmemobj/pmemobj_action.3.md +++ b/doc/libpmemobj/pmemobj_action.3.md @@ -43,7 +43,6 @@ date: pmemobj API version 2.3 [EXAMPLES](#examples)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **pmemobj_reserve**(), **pmemobj_xreserve**(), **pmemobj_defer_free**(), @@ -52,7 +51,6 @@ date: pmemobj API version 2.3 **POBJ_RESERVE_ALLOC**(), **POBJ_XRESERVE_NEW**(),**POBJ_XRESERVE_ALLOC**() - Delayed atomicity actions (EXPERIMENTAL) - # SYNOPSIS # ```c diff --git a/doc/libpmemobj/pmemobj_alloc.3.md b/doc/libpmemobj/pmemobj_alloc.3.md index 1fdd6bec3..47a5f1e58 100644 --- a/doc/libpmemobj/pmemobj_alloc.3.md +++ b/doc/libpmemobj/pmemobj_alloc.3.md @@ -42,7 +42,6 @@ date: pmemobj API version 2.3 [RETURN VALUE](#return-value)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **pmemobj_alloc**(), **pmemobj_xalloc**(), **pmemobj_zalloc**(), @@ -52,7 +51,6 @@ date: pmemobj API version 2.3 **POBJ_REALLOC**(), **POBJ_ZREALLOC**(), **POBJ_FREE**() - non-transactional atomic allocations - # SYNOPSIS # ```c @@ -88,7 +86,6 @@ POBJ_ZREALLOC(PMEMobjpool *pop, TOID *oidp, TYPE, size_t size) POBJ_FREE(TOID *oidp) ``` - # DESCRIPTION # Functions described in this document provide the mechanism to allocate, @@ -235,7 +232,6 @@ typed *OID* of type name *TYPE*, and passes the type number from the typed The **POBJ_FREE**() macro is a wrapper around the **pmemobj_free**() function which takes a pointer to the typed *OID* instead of to *PMEMoid*. - # RETURN VALUE # On success, **pmemobj_alloc**() and **pmemobj_xalloc** return 0. If *oidp* @@ -266,7 +262,6 @@ appropriately. The **pmemobj_alloc_usable_size**() function returns the number of usable bytes in the object represented by *oid*. If *oid* is **OID_NULL**, it returns 0. - # SEE ALSO # **free**(3), **POBJ_FOREACH**(3), **realloc**(3), diff --git a/doc/libpmemobj/pmemobj_ctl_get.3.md b/doc/libpmemobj/pmemobj_ctl_get.3.md index 8ca128e04..803e4893c 100644 --- a/doc/libpmemobj/pmemobj_ctl_get.3.md +++ b/doc/libpmemobj/pmemobj_ctl_get.3.md @@ -43,7 +43,6 @@ date: pmemobj API version 2.3 [CTL EXTERNAL CONFIGURATION](#ctl-external-configuration)<br /> [SEE ALSO](#see-also)<br /> - # NAME # _UW(pmemobj_ctl_get), @@ -51,7 +50,6 @@ _UW(pmemobj_ctl_set), _UW(pmemobj_ctl_exec) - Query and modify libpmemobj internal behavior (EXPERIMENTAL) - # SYNOPSIS # ```c @@ -67,7 +65,6 @@ _UWFUNCR2(int, pmemobj_ctl_exec, PMEMobjpool *pop, *name, void *arg, _UNICODE() - # DESCRIPTION # The _UW(pmemobj_ctl_get), _UW(pmemobj_ctl_set) and _UW(pmemobj_ctl_exec) @@ -89,7 +86,6 @@ description. See more in **pmem_ctl**(5) man page. - # CTL NAMESPACE # prefault.at_create | rw | global | int | int | - | boolean @@ -384,7 +380,6 @@ a sequence of ctl queries. See more in **pmem_ctl**(5) man page. - # SEE ALSO # **libpmemobj**(7), **pmem_ctl**(5) and **<http://pmem.io>** diff --git a/doc/libpmemobj/pmemobj_first.3.md b/doc/libpmemobj/pmemobj_first.3.md index c0afbb0e6..a0345a602 100644 --- a/doc/libpmemobj/pmemobj_first.3.md +++ b/doc/libpmemobj/pmemobj_first.3.md @@ -41,7 +41,6 @@ date: pmemobj API version 2.3 [DESCRIPTION](#description)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **pmemobj_first**(), **pmemobj_next**(), @@ -51,7 +50,6 @@ date: pmemobj API version 2.3 **POBJ_FOREACH_TYPE**(), **POBJ_FOREACH_SAFE_TYPE**() - pmemobj container operations - # SYNOPSIS # ```c @@ -71,7 +69,6 @@ POBJ_FOREACH_TYPE(PMEMobjpool *pop, TOID var) POBJ_FOREACH_SAFE_TYPE(PMEMobjpool *pop, TOID var, TOID nvar) ``` - # DESCRIPTION # The **libpmemobj**(7) container operations provide a mechanism that allows @@ -125,7 +122,6 @@ is empty, **OID_NULL**. referenced by *oid* is the last object in the collection, or if *oid* is *OID_NULL*, **pmemobj_next**() returns **OID_NULL**. - # SEE ALSO # **libpmemobj**(7) and **<http://pmem.io>** diff --git a/doc/libpmemobj/pmemobj_list_insert.3.md b/doc/libpmemobj/pmemobj_list_insert.3.md index 3a23f10e7..cefb44b08 100644 --- a/doc/libpmemobj/pmemobj_list_insert.3.md +++ b/doc/libpmemobj/pmemobj_list_insert.3.md @@ -42,14 +42,12 @@ date: pmemobj API version 2.3 [RETURN VALUE](#return-value)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **pmemobj_list_insert**(), **pmemobj_list_insert_new**(), **pmemobj_list_move**(), **pmemobj_list_remove**() - non-transactional persistent atomic lists functions - # SYNOPSIS # ```c @@ -71,7 +69,6 @@ int pmemobj_list_remove(PMEMobjpool *pop, size_t pe_offset, void *head, PMEMoid oid, int free); ``` - # DESCRIPTION # In addition to the container operations on internal object collections @@ -173,7 +170,6 @@ memory space. *pe_offset* specifies the offset of the structure that connects the elements in the list. Both *head* and *oid* must point to objects allocated from memory pool *pop* and cannot be **OID_NULL**. - # RETURN VALUE # On success, **pmemobj_list_insert**(), **pmemobj_list_remove**() and @@ -185,7 +181,6 @@ allocated object. If the constructor returns a non-zero value, the allocation is canceled, -1 is returned, and *errno* is set to **ECANCELED**. On other errors, **OID_NULL** is returned and *errno* is set appropriately. - # SEE ALSO # **pmemobj_first**(3), **POBJ_FOREACH**(3), **libpmemobj**(7) diff --git a/doc/libpmemobj/pmemobj_memcpy_persist.3.md b/doc/libpmemobj/pmemobj_memcpy_persist.3.md index cb56978ed..f3a9d078e 100644 --- a/doc/libpmemobj/pmemobj_memcpy_persist.3.md +++ b/doc/libpmemobj/pmemobj_memcpy_persist.3.md @@ -43,7 +43,6 @@ date: pmemobj API version 2.3 [EXAMPLES](#examples)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **pmemobj_persist**(), **pmemobj_xpersist**(), **pmemobj_flush**(), @@ -51,7 +50,6 @@ date: pmemobj API version 2.3 **pmemobj_memmove**(), **pmemobj_memset**(), **pmemobj_memcpy_persist**(), **pmemobj_memset_persist**() - low-level memory manipulation functions - # SYNOPSIS # ```c @@ -81,7 +79,6 @@ void *pmemobj_memset_persist(PMEMobjpool *pop, void *dest, int c, size_t len); ``` - # DESCRIPTION # The **libpmemobj**-specific low-level memory manipulation functions described @@ -205,7 +202,6 @@ pmemobj_persist(PMEMobjpool *pop, const void *addr, size_t len) } ``` - # SEE ALSO # **memcpy**(3), **memset**(3), **pmem_msync**(3), diff --git a/doc/libpmemobj/pmemobj_mutex_zero.3.md b/doc/libpmemobj/pmemobj_mutex_zero.3.md index f1cd662e6..8a6b511e2 100644 --- a/doc/libpmemobj/pmemobj_mutex_zero.3.md +++ b/doc/libpmemobj/pmemobj_mutex_zero.3.md @@ -42,7 +42,6 @@ date: pmemobj API version 2.3 [RETURN VALUE](#return-value)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **pmemobj_mutex_zero**(), **pmemobj_mutex_lock**(), **pmemobj_mutex_timedlock**(), @@ -56,7 +55,6 @@ date: pmemobj API version 2.3 **pmemobj_cond_timedwait**(), **pmemobj_cond_wait**() - pmemobj synchronization primitives - # SYNOPSIS # ```c @@ -89,7 +87,6 @@ int pmemobj_cond_wait(PMEMobjpool *pop, PMEMcond *restrict condp, PMEMmutex *restrict mutexp); ``` - # DESCRIPTION # **libpmemobj**(7) provides several types of synchronization primitives @@ -212,7 +209,6 @@ has released it, then a subsequent call to **pmemobj_cond_broadcast**() or after the about-to-block thread has blocked. Upon successful return, the mutex will be locked and owned by the calling thread. - # RETURN VALUE # The **pmemobj_mutex_zero**(), **pmemobj_rwlock_zero**() @@ -221,7 +217,6 @@ and **pmemobj_cond_zero**() functions return no value. Other locking functions return 0 on success. Otherwise, an error number will be returned to indicate the error. - # SEE ALSO # **pmemobj_tx_zalloc**(3), **pmemobj_zalloc**(3), **pthread_cond_init**(3), diff --git a/doc/libpmemobj/pmemobj_open.3.md b/doc/libpmemobj/pmemobj_open.3.md index bf839c741..ff874209a 100644 --- a/doc/libpmemobj/pmemobj_open.3.md +++ b/doc/libpmemobj/pmemobj_open.3.md @@ -43,14 +43,12 @@ date: pmemobj API version 2.3 [CAVEATS](#caveats)<br /> [SEE ALSO](#see-also)<br /> - # NAME # _UW(pmemobj_open), _UW(pmemobj_create), **pmemobj_close**(), _UW(pmemobj_check) - create, open, close and validate persistent memory transactional object store - # SYNOPSIS # ```c @@ -65,7 +63,6 @@ _UWFUNCR1(int, pmemobj_check, *path, const char *layout) _UNICODE() - # DESCRIPTION # To use the pmem-resident transactional object store provided by @@ -178,13 +175,11 @@ as described in the **DEBUGGING AND ERROR HANDLING** section in **libpmemobj**(7). _UW(pmemobj_check) returns -1 and sets *errno* if it cannot perform the consistency check due to other errors. - # CAVEATS # Not all file systems support **posix_fallocate**(3). _UW(pmemobj_create) will fail if the underlying file system does not support **posix_fallocate**(3). - # SEE ALSO # **creat**(2), **msync**(2), **pmem_is_pmem**(3), **pmem_persist**(3), diff --git a/doc/libpmemobj/pmemobj_root.3.md b/doc/libpmemobj/pmemobj_root.3.md index 11988de34..a500178ab 100644 --- a/doc/libpmemobj/pmemobj_root.3.md +++ b/doc/libpmemobj/pmemobj_root.3.md @@ -42,13 +42,11 @@ date: pmemobj API version 2.3 [RETURN VALUE](#return-value)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **pmemobj_root**(), **pmemobj_root_construct**() **POBJ_ROOT**(), **pmemobj_root_size**() - root object management - # SYNOPSIS # ```c @@ -61,7 +59,6 @@ POBJ_ROOT(PMEMobjpool *pop, TYPE) size_t pmemobj_root_size(PMEMobjpool *pop); ``` - # DESCRIPTION # The root object of a persistent memory pool is an entry point for all other @@ -95,7 +92,6 @@ except it returns a typed *OID* value. The **pmemobj_root_size**() function returns the current size of the root object associated with the persistent memory pool *pop*. - # RETURN VALUE # Upon success, **pmemobj_root**() returns a handle to the root object associated @@ -120,7 +116,6 @@ associated with the persistent memory pool *pop*. The returned size is the largest value requested by any of the earlier **pmemobj_root**() calls. If the root object has not been allocated yet, **pmemobj_root_size**() returns 0. - # SEE ALSO # **libpmemobj**(7) and **<http://pmem.io>** diff --git a/doc/libpmemobj/pmemobj_tx_add_range.3.md b/doc/libpmemobj/pmemobj_tx_add_range.3.md index cb12d315a..92072eb9c 100644 --- a/doc/libpmemobj/pmemobj_tx_add_range.3.md +++ b/doc/libpmemobj/pmemobj_tx_add_range.3.md @@ -42,7 +42,6 @@ date: pmemobj API version 2.3 [RETURN VALUE](#return-value)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **pmemobj_tx_add_range**(), **pmemobj_tx_add_range_direct**(), @@ -58,7 +57,6 @@ date: pmemobj API version 2.3 **TX_MEMCPY**(), **TX_MEMSET**() - transactional object manipulation - # SYNOPSIS # ```c @@ -85,7 +83,6 @@ TX_MEMCPY(void *dest, const void *src, size_t num) TX_MEMSET(void *dest, int c, size_t num) ``` - # DESCRIPTION # **pmemobj_tx_add_range**() takes a "snapshot" of the memory block of given @@ -204,7 +201,6 @@ undo log and then fills the first *num* bytes of its memory area with the constant byte *c*. In case of a failure or abort, the saved value will be restored. - # RETURN VALUE # On success, **pmemobj_tx_add_range**() and **pmemobj_tx_add_range_direct**() @@ -215,7 +211,6 @@ On success, **pmemobj_tx_xadd_range**() and **pmemobj_tx_xadd_range_direct**() returns 0. Otherwise, the error number is returned, **errno** is set and when flags do not contain **POBJ_XADD_NO_ABORT**, the transaction is aborted. - # SEE ALSO # **pmemobj_tx_alloc**(3), **pmemobj_tx_begin**(3), diff --git a/doc/libpmemobj/pmemobj_tx_alloc.3.md b/doc/libpmemobj/pmemobj_tx_alloc.3.md index ab41577ac..25770866a 100644 --- a/doc/libpmemobj/pmemobj_tx_alloc.3.md +++ b/doc/libpmemobj/pmemobj_tx_alloc.3.md @@ -42,7 +42,6 @@ date: pmemobj API version 2.3 [RETURN VALUE](#return-value)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **pmemobj_tx_alloc**(), **pmemobj_tx_zalloc**(), @@ -61,7 +60,6 @@ date: pmemobj API version 2.3 **TX_XFREE**() - transactional object manipulation - # SYNOPSIS # ```c @@ -90,7 +88,6 @@ TX_FREE(TOID o) TX_XFREE(TOID o, uint64_t flags) ``` - # DESCRIPTION # The **pmemobj_tx_alloc**() function transactionally allocates a new object of @@ -253,7 +250,6 @@ section. If successful and called during **TX_STAGE_WORK**, **TX_FREE**() returns 0. Otherwise, the error number is returned, **errno** is set and when flags do not contain **POBJ_XFREE_NO_ABORT**, the transaction is aborted. - # RETURN VALUE # On success, the **pmemobj_tx_alloc**(), **pmemobj_tx_zalloc**(), diff --git a/doc/libpmemobj/pmemobj_tx_begin.3.md b/doc/libpmemobj/pmemobj_tx_begin.3.md index c0c4e31d8..a0fc54a3d 100644 --- a/doc/libpmemobj/pmemobj_tx_begin.3.md +++ b/doc/libpmemobj/pmemobj_tx_begin.3.md @@ -43,7 +43,6 @@ date: pmemobj API version 2.3 [CAVEATS](#caveats)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **pmemobj_tx_stage**(), @@ -62,7 +61,6 @@ date: pmemobj API version 2.3 **pmemobj_tx_log_intents_max_size**() - transactional object manipulation - # SYNOPSIS # ```c @@ -94,7 +92,6 @@ size_t pmemobj_tx_log_snapshots_max_size(size_t *sizes, size_t nsizes); size_t pmemobj_tx_log_intents_max_size(size_t nintents); ``` - # DESCRIPTION # The non-transactional functions and macros described in **pmemobj_alloc**(3), @@ -535,7 +532,6 @@ thread. For this reason, all functions that might trigger destruction (e.g. **dlclose**(3)) should be called in the main thread. Otherwise some of the resources associated with that thread might not be cleaned up properly. - # SEE ALSO # **dlclose**(3), **longjmp**(3), **pmemobj_tx_add_range**(3), diff --git a/doc/libpmemobj/pobj_layout_begin.3.md b/doc/libpmemobj/pobj_layout_begin.3.md index 6b82532e3..a55740e7f 100644 --- a/doc/libpmemobj/pobj_layout_begin.3.md +++ b/doc/libpmemobj/pobj_layout_begin.3.md @@ -42,7 +42,6 @@ date: pmemobj API version 2.3 [EXAMPLE](#example)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **POBJ_LAYOUT_BEGIN**(), **POBJ_LAYOUT_TOID**(), @@ -50,7 +49,6 @@ date: pmemobj API version 2.3 **POBJ_LAYOUT_END**(), **POBJ_LAYOUT_TYPES_NUM**() - persistent memory transactional object store layout - # SYNOPSIS # ```c @@ -64,7 +62,6 @@ POBJ_LAYOUT_END(layout) POBJ_LAYOUT_TYPES_NUM(layout) ``` - # DESCRIPTION # **libpmemobj**(7) defines a set of macros for convenient declaration of a @@ -96,7 +93,6 @@ The **POBJ_LAYOUT_NAME**() macro returns the name of layout as a null-terminated The **POBJ_LAYOUT_TYPES_NUM**() macro returns number of types declared using the **POBJ_LAYOUT_TOID**() macro within the layout declaration. - # EXAMPLE # This is an example of layout declaration: @@ -127,7 +123,6 @@ const char *layout_name = POBJ_LAYOUT_NAME(mylayout); int num_of_types = POBJ_LAYOUT_TYPES_NUM(mylayout); ``` - # SEE ALSO # **TOID_DECLARE**(3), **libpmemobj**(7) and **<http://pmem.io>** diff --git a/doc/libpmemobj/pobj_list_head.3.md b/doc/libpmemobj/pobj_list_head.3.md index 05b620a67..346a16970 100644 --- a/doc/libpmemobj/pobj_list_head.3.md +++ b/doc/libpmemobj/pobj_list_head.3.md @@ -41,7 +41,6 @@ date: pmemobj API version 2.3 [DESCRIPTION](#description)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **POBJ_LIST_HEAD**(), @@ -73,7 +72,6 @@ date: pmemobj API version 2.3 **POBJ_LIST_MOVE_ELEMENT_BEFORE**() - type-safe non-transactional persistent atomic lists - # SYNOPSIS # ```c @@ -130,7 +128,6 @@ POBJ_LIST_MOVE_ELEMENT_BEFORE(PMEMobjpool *pop, POBJ_LIST_HEAD *head, POBJ_LIST_ENTRY FIELD, POBJ_LIST_ENTRY field_new) ``` - # DESCRIPTION # The following macros define and operate on a type-safe persistent @@ -273,7 +270,6 @@ the object is inserted at the head of the list. The *field* and *field_new* arguments are the names of the fields of type *POBJ_LIST_ENTRY* in the element structure that are used to connect the elements in both lists. - # SEE ALSO # **queue**(3), **libpmemobj**(7) and **<http://pmem.io>** diff --git a/doc/libpmemobj/toid_declare.3.md b/doc/libpmemobj/toid_declare.3.md index 8be76d19c..b6cf76174 100644 --- a/doc/libpmemobj/toid_declare.3.md +++ b/doc/libpmemobj/toid_declare.3.md @@ -41,7 +41,6 @@ date: pmemobj API version 2.3 [DESCRIPTION](#description)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **TOID_DECLARE**(), **TOID_DECLARE_ROOT**(), **TOID**(), @@ -51,7 +50,6 @@ date: pmemobj API version 2.3 **DIRECT_RW**(), **D_RW**(), **DIRECT_RO**(), **D_RO**() - libpmemobj type safety mechanism - # SYNOPSIS # ```c @@ -75,7 +73,6 @@ DIRECT_RO(TOID oid) D_RO(TOID oid) ``` - # DESCRIPTION # Operating on untyped object handles, as well as on direct untyped object @@ -130,7 +127,6 @@ The **DIRECT_RO**() macro and its shortened form **D_RO**() return a typed read-only (const) pointer (*TYPE\**) to an object represented by *oid*. If *oid* is **OID_NULL**, the macro evaluates to NULL. - # SEE ALSO # **OID_IS_NULL**(3), **POBJ_LAYOUT_ROOT**(3), **POBJ_LAYOUT_TOID**(3), diff --git a/doc/libpmempool/libpmempool.7.md b/doc/libpmempool/libpmempool.7.md index 17a5e0986..a0c6adbda 100644 --- a/doc/libpmempool/libpmempool.7.md +++ b/doc/libpmempool/libpmempool.7.md @@ -45,12 +45,10 @@ date: pmempool API version 1.3 [ACKNOWLEDGEMENTS](#acknowledgements)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **libpmempool** - persistent memory pool management library - # SYNOPSIS # ```c @@ -87,7 +85,6 @@ manual pages: + toggle or query pool set features: **pmempool_feature_query**(3) - # DESCRIPTION # **libpmempool** @@ -107,7 +104,6 @@ purposes also. **libpmempool** introduces functionality of pool set health check, synchronization, transformation and removal. - # CAVEATS # **libpmempool** relies on the library destructor being called from the main @@ -156,7 +152,6 @@ return value is a static string describing the reason for failing the version check. The string returned by _UW(pmempool_check_version) must not be modified or freed. - # DEBUGGING AND ERROR HANDLING # If an error is detected during the call to a **libpmempool** function, the @@ -214,7 +209,6 @@ is "-", the *PID* of the current process will be appended to the file name when the log file is created. If **PMEMPOOL_LOG_FILE** is not set, output is written to *stderr*. - # EXAMPLE # The following example illustrates how the **libpmempool** API is used. @@ -287,14 +281,12 @@ main(int argc, char *argv[]) See <http://pmem.io/pmdk/libpmempool> for more examples using the **libpmempool** API. - # ACKNOWLEDGEMENTS # **libpmempool** builds on the persistent memory programming model recommended by the SNIA NVM Programming Technical Work Group: <http://snia.org/nvmp> - # SEE ALSO # **dlclose**(3), **pmempool_check_init**(3), **pmempool_feature_query**(3), diff --git a/doc/libpmempool/pmempool_check_init.3.md b/doc/libpmempool/pmempool_check_init.3.md index a05fa6824..088f47312 100644 --- a/doc/libpmempool/pmempool_check_init.3.md +++ b/doc/libpmempool/pmempool_check_init.3.md @@ -44,13 +44,11 @@ date: pmempool API version 1.3 [NOTES](#notes)<br /> [SEE ALSO](#see-also)<br /> - # NAME # _UW(pmempool_check_init), _UW(pmempool_check), **pmempool_check_end**() - checks pmempool health - # SYNOPSIS # ```c @@ -65,7 +63,6 @@ enum pmempool_check_result pmempool_check_end(PMEMpoolcheck *ppc); _UNICODE() - # DESCRIPTION # To perform the checks provided by **libpmempool**, a *check context* @@ -88,7 +85,6 @@ _UW(pmempool_check_init) initializes the check context. *args* describes parameters of the check context. *args_size* should be equal to the size of the _UWS(pmempool_check_args). _UWS(pmempool_check_args) is defined as follows: - _WINUX(=q= ```c struct pmempool_check_argsU @@ -232,7 +228,6 @@ _UWS(pmempool_check_status) pointer must be considered invalid. The **pmempool_check_end**() function finalizes the check and releases all related resources. *ppc* is invalid after calling **pmempool_check_end**(). - # RETURN VALUE # _UW(pmempool_check_init) returns an opaque handle of type *PMEMpoolcheck\**. @@ -297,13 +292,11 @@ The **PMEMPOOL_CHECK_FORMAT_STR** flag indicates string format statuses (*struct pmempool_check_status*). Currently this is the only supported status format so this flag is required. - # NOTES # Currently, checking the consistency of a *pmemobj* pool is **not** supported. - # SEE ALSO # **libpmemlog**(7), **libpmemobj**(7) and **<http://pmem.io>** diff --git a/doc/libpmempool/pmempool_feature_query.3.md b/doc/libpmempool/pmempool_feature_query.3.md index 330965bdd..d008cc9bb 100644 --- a/doc/libpmempool/pmempool_feature_query.3.md +++ b/doc/libpmempool/pmempool_feature_query.3.md @@ -45,13 +45,11 @@ set features) [RETURN VALUE](#return-value)<br /> [SEE ALSO](#see-also)<br /> - # NAME # _UW(pmempool_feature_query), _UW(pmempool_feature_enable), _UW(pmempool_feature_disable) - toggle or query pool set features - # SYNOPSIS # ```c @@ -66,7 +64,6 @@ _UWFUNCR1(int, pmempool_feature_disable, *path, =q=enum pmempool_feature feature _UNICODE() - # DESCRIPTION # The *feature* argument accepts following values: diff --git a/doc/libpmempool/pmempool_rm.3.md b/doc/libpmempool/pmempool_rm.3.md index 80099f8a0..d9712deda 100644 --- a/doc/libpmempool/pmempool_rm.3.md +++ b/doc/libpmempool/pmempool_rm.3.md @@ -42,12 +42,10 @@ date: pmempool API version 1.3 [RETURN VALUE](#return-value)<br /> [SEE ALSO](#see-also)<br /> - # NAME # _UW(pmempool_rm) - remove persistent memory pool - # SYNOPSIS # ```c @@ -58,7 +56,6 @@ _UWFUNCR1(int, pmempool_rm, *path, int flags) _UNICODE() - # DESCRIPTION # The _UW(pmempool_rm) function removes the pool pointed to by *path*. The *path* @@ -78,13 +75,11 @@ local _WINUX(,or remote )replicas. _WINUX(, + **PMEMPOOL_RM_POOLSET_REMOTE** - Also remove remote pool set file.) - # RETURN VALUE # On success, _UW(pmempool_rm) returns 0. On error, it returns -1 and sets *errno* accordingly. - # SEE ALSO # **rpmem_remove**(3), **unlink**(3), **libpmemlog**(7), diff --git a/doc/libpmempool/pmempool_sync.3.md b/doc/libpmempool/pmempool_sync.3.md index f15f94565..a50bec367 100644 --- a/doc/libpmempool/pmempool_sync.3.md +++ b/doc/libpmempool/pmempool_sync.3.md @@ -44,12 +44,10 @@ date: pmempool API version 1.3 [NOTES](#notes)<br /> [SEE ALSO](#see-also)<br /> - # NAME # _UW(pmempool_sync), _UW(pmempool_transform) - pool set synchronization and transformation - # SYNOPSIS # ```c @@ -63,7 +61,6 @@ _UWFUNCR12(int, pmempool_transform, *poolset_file_src, _UNICODE() - # DESCRIPTION # The _UW(pmempool_sync) function synchronizes data between replicas within @@ -102,7 +99,6 @@ part in the replica. If the option *NOHDRS* is used, replicas contain no internal metadata. In both cases, only the missing parts or the ones which cannot be opened are recreated with the _UW(pmempool_sync) function.=e=) - _UW(pmempool_transform) modifies the internal structure of a pool set. It supports the following operations: @@ -166,13 +162,11 @@ metadata.=e=) **libpmemobj**(7) pools, so _UW(pmempool_transform) cannot be used with other pool types (**libpmemlog**(7), **libpmemblk**(7)). - # RETURN VALUE # _UW(pmempool_sync) and _UW(pmempool_transform) return 0 on success. Otherwise, they return -1 and set *errno* appropriately. - # ERRORS # **EINVAL** Invalid format of the input/output pool set file. @@ -193,7 +187,6 @@ Otherwise, they return -1 and set *errno* appropriately. **ENOTSUP** The pool set contains a remote replica, but remote replication is not supported (**librpmem**(7) is not available). - # NOTES # The _UW(pmempool_sync) API is experimental and it may change in future @@ -202,7 +195,6 @@ versions of the library. The _UW(pmempool_transform) API is experimental and it may change in future versions of the library. - # SEE ALSO # **libpmemlog**(7), **libpmemobj**(7) and **<http://pmem.io>** diff --git a/doc/librpmem/librpmem.7.md b/doc/librpmem/librpmem.7.md index 26001eecb..47acf4dff 100644 --- a/doc/librpmem/librpmem.7.md +++ b/doc/librpmem/librpmem.7.md @@ -36,7 +36,6 @@ date: rpmem API version 1.3 [comment]: <> (librpmem.7 -- man page for librpmem) - [NAME](#name)<br /> [SYNOPSIS](#synopsis)<br /> [DESCRIPTION](#description)<br /> @@ -52,12 +51,10 @@ date: rpmem API version 1.3 [ACKNOWLEDGEMENTS](#acknowledgements)<br /> [SEE ALSO](#see-also) - # NAME # **librpmem** - remote persistent memory support library (EXPERIMENTAL) - # SYNOPSIS # ```c @@ -86,7 +83,6 @@ manual pages: + **rpmem_create**(3), **rpmem_persist**(3) - # DESCRIPTION # **librpmem** provides low-level support for remote access to @@ -109,7 +105,6 @@ available and are recommended for most applications, see: + **libpmemobj**(7), a general use persistent memory API, providing memory allocation and transactional operations on variable-sized objects. - # TARGET NODE ADDRESS FORMAT # ``` @@ -122,7 +117,6 @@ to authenticate to the remote machine without querying for password/passphrase. The optional *port* number is used to establish the SSH connection. The default port number is 22. - # REMOTE POOL ATTRIBUTES # The *rpmem_pool_attr* structure describes a remote pool and is stored in remote @@ -177,7 +171,6 @@ pools in a list. The *user_flags* field is a 16-byte user-defined flags. - # SSH # **librpmem** utilizes the **ssh**(1) client to login and execute the @@ -189,7 +182,6 @@ on the remote node may be overridden by setting the **RPMEM_SSH** and **RPMEM_CMD** environment variables, respectively. See **ENVIRONMENT** for details. - # FORK # The **ssh**(1) client is executed by **rpmem_open**(3) and **rpmem_create**(3) after forking a child process @@ -203,7 +195,6 @@ By default, **fabric**(7) initializes **libibverbs** with **fork**(2) support by calling the **ibv_fork_init**(3) function. See **fi_verbs**(7) for more details. - # CAVEATS # **librpmem** relies on the library destructor being called from the main thread. @@ -253,14 +244,12 @@ static string describing the reason for failing the version check. The string returned by **rpmem_check_version**() must not be modified or freed. - # ENVIRONMENT # **librpmem** can change its default behavior based on the following environment variables. These are largely intended for testing and are not normally required. - + **RPMEM_SSH**=*ssh_client* Setting this environment variable overrides the default **ssh**(1) client @@ -365,7 +354,6 @@ If the last character in the name is "-", the *PID* of the current process will be appended to the file name when the log file is created. If **RPMEM_LOG_FILE** is not set, logging output is written to *stderr*. - # EXAMPLE # The following example uses **librpmem** to create a remote pool on given @@ -481,7 +469,6 @@ compatibility will be preserved. recommended by the SNIA NVM Programming Technical Work Group: <http://snia.org/nvmp> - # SEE ALSO # **rpmemd**(1), **ssh**(1), **fork**(2), **dlclose**(3), **dlopen**(3), diff --git a/doc/librpmem/rpmem_create.3.md b/doc/librpmem/rpmem_create.3.md index 32eb4889e..6e84381b3 100644 --- a/doc/librpmem/rpmem_create.3.md +++ b/doc/librpmem/rpmem_create.3.md @@ -43,14 +43,12 @@ date: rpmem API version 1.3 [NOTES](#notes)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **rpmem_create**(), **rpmem_open**(), **rpmem_set_attr**(), **rpmem_close**(), **rpmem_remove**() - most commonly used functions for remote access to *persistent memory* - # SYNOPSIS # ```c @@ -67,7 +65,6 @@ int rpmem_close(RPMEMpool *rpp); int rpmem_remove(const char *target, const char *pool_set_name, int flags); ``` - # DESCRIPTION # The **rpmem_create**() function creates a remote pool on a given *target* node, @@ -131,7 +128,6 @@ removed. + **RPMEM_REMOVE_POOL_SET** - Remove the pool *set* file after removing the pool described by this pool set. - # RETURN VALUE # On success, **rpmem_create**() returns an opaque handle to the remote pool @@ -156,7 +152,6 @@ and sets *errno* appropriately. On success, **rpmem_remove**() returns 0. On error, it returns a non-zero value and sets *errno* appropriately. - # NOTES # ## REMOTE POOL SIZE ## @@ -176,7 +171,6 @@ contains internal metadata. For other consequences of using the *SINGLEHDR* and the minimum size allowed by **librpmem** for a part file and a remote pool, respectively. - ## LANES ## The term *lane* means an isolated path of execution. The underlying hardware utilized by both local and remote nodes may have limited resources that @@ -197,7 +191,6 @@ If the system runs out of free file descriptors during **rpmem_create**() or **rpmem_open**(), these functions will fail. See **nofile** in **limits.conf**(5) for more details. - # SEE ALSO # **rpmem_persist**(3), **sysconf**(3), **limits.conf**(5), diff --git a/doc/librpmem/rpmem_persist.3.md b/doc/librpmem/rpmem_persist.3.md index 46408a3c2..11331ad1c 100644 --- a/doc/librpmem/rpmem_persist.3.md +++ b/doc/librpmem/rpmem_persist.3.md @@ -43,14 +43,12 @@ date: rpmem API version 1.3 [CAVEATS](#caveats)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **rpmem_persist**(), **rpmem_deep_persist**(), **rpmem_flush**(), **rpmem_drain**(), **rpmem_read**() - functions to copy and read remote pools - # SYNOPSIS # ```c @@ -69,7 +67,6 @@ int rpmem_read(RPMEMpool *rpp, void *buff, size_t offset, size_t length, unsigned lane); ``` - # DESCRIPTION # The **rpmem_persist**() function copies data of given *length* at given @@ -127,7 +124,6 @@ the specified *lane*. The lane must be less than the value returned by remote pool opened or created previously by **rpmem_open**(3) or **rpmem_create**(3). - # RETURN VALUE # The **rpmem_persist**() function returns 0 if the entire memory area was @@ -146,13 +142,11 @@ appropriately. The **rpmem_read**() function returns 0 if the data was read entirely. Otherwise it returns a non-zero value and sets *errno* appropriately. - # CAVEATS # Ordering of **rpmem_flush**() and **rpmem_persist**() operations which are using different *lane* values is not guaranteed. - # SEE ALSO # **rpmem_create**(3), **rpmem_open**(3), **rpmem_persist**(3), diff --git a/doc/pmem_ctl/pmem_ctl.5.md b/doc/pmem_ctl/pmem_ctl.5.md index 2099dd3d4..a77a1a520 100644 --- a/doc/pmem_ctl/pmem_ctl.5.md +++ b/doc/pmem_ctl/pmem_ctl.5.md @@ -41,12 +41,10 @@ date: pmem_ctl API version 1.4 [CTL EXTERNAL CONFIGURATION](#ctl-external-configuration)<br /> [SEE ALSO](#see-also)<br /> - # NAME # ctl - interface for examination and modification of the library's internal state. - # DESCRIPTION # The CTL namespace is organized in a tree structure. Starting from the root, diff --git a/doc/pmempool/pmempool-check.1.md b/doc/pmempool/pmempool-check.1.md index 50a906a53..81441b359 100644 --- a/doc/pmempool/pmempool-check.1.md +++ b/doc/pmempool/pmempool-check.1.md @@ -42,19 +42,16 @@ date: pmem Tools version 1.4 [EXAMPLE](#example)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **pmempool-check** - check and repair persistent memory pool - # SYNOPSIS # ``` $ pmempool check [<options>] <file> ``` - # DESCRIPTION # The **pmempool** invoked with *check* command checks consistency of a given pool file. @@ -113,7 +110,6 @@ Be more verbose. Display help message and exit. - # EXAMPLE # ``` @@ -136,7 +132,6 @@ $ pmempool check -rvN pool.bin Check consistency of "pool.bin" pool file, print what would be repaired with increased verbosity level. - # SEE ALSO # **pmempool**(1), **libpmemblk**(7), **libpmemlog**(7), diff --git a/doc/pmempool/pmempool-convert.1.md b/doc/pmempool/pmempool-convert.1.md index e18309a09..ccc0d2cdf 100644 --- a/doc/pmempool/pmempool-convert.1.md +++ b/doc/pmempool/pmempool-convert.1.md @@ -42,7 +42,6 @@ date: pmem Tools version 1.4 [EXAMPLE](#example)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **pmempool-convert** - this is a wrapper around pmdk-convert tool. More information diff --git a/doc/pmempool/pmempool-create.1.md b/doc/pmempool/pmempool-create.1.md index f14c09051..c3213c2e7 100644 --- a/doc/pmempool/pmempool-create.1.md +++ b/doc/pmempool/pmempool-create.1.md @@ -42,19 +42,16 @@ date: pmem Tools version 1.4 [EXAMPLE](#example)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **pmempool-create** - create a persistent memory pool - # SYNOPSIS # ``` $ pmempool create [<options>] [<type>] [<bsize>] <file> ``` - # DESCRIPTION # The **pmempool** invoked with *create* command creates a pool file @@ -114,7 +111,6 @@ Increase verbosity level. Display help message and exit. - ##### Options for PMEMBLK: ##### By default when creating a pmem **blk** pool, the **BTT** layout is *not* @@ -127,7 +123,6 @@ is performed to block number 0. Please refer to **libpmemblk**(7) for details. Force writing the **BTT** layout by performing *write operation* to block number zero. - ##### Options for PMEMOBJ: ##### By default when creating a pmem **obj** pool, the layout name provided to @@ -138,7 +133,6 @@ the **libpmemobj** library is an empty string. Please refer to Layout name of the **pmemobj** pool. - # EXAMPLE # ``` @@ -171,7 +165,6 @@ $ pmempool create --inherit=pool.log new_pool.log Create a pool file based on pool.log file - # SEE ALSO # **pmempool**(1), **libpmemblk**(7), **libpmemlog**(7), diff --git a/doc/pmempool/pmempool-dump.1.md b/doc/pmempool/pmempool-dump.1.md index 965513a4b..e7ac88fc0 100644 --- a/doc/pmempool/pmempool-dump.1.md +++ b/doc/pmempool/pmempool-dump.1.md @@ -43,19 +43,16 @@ date: pmem Tools version 1.4 [EXAMPLE](#example)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **pmempool-dump** - dump user data from persistent memory pool - # SYNOPSIS # ``` $ pmempool dump [<options>] <file> ``` - # DESCRIPTION # The **pmempool** invoked with *dump* command dumps user data from specified pool file. @@ -92,7 +89,6 @@ Name of output file. Display help message and exit. - # RANGE # Using **-r**, **--range** option it is possible to dump only a range of user data. @@ -116,7 +112,6 @@ All blocks/bytes/data chunks starting from *\<first\>* will be dumped. Only *\<number\>* block/byte/data chunk will be dumped. - # EXAMPLE # ``` @@ -138,7 +133,6 @@ $ pmempool dump -r 1K-2K pool.bin Dump data form 1K to 2K from pool.bin file. - # SEE ALSO # **pmempool**(1), **libpmemblk**(7), **libpmemlog**(7), diff --git a/doc/pmempool/pmempool-feature.1.md b/doc/pmempool/pmempool-feature.1.md index 7ffc481dd..a77151bae 100644 --- a/doc/pmempool/pmempool-feature.1.md +++ b/doc/pmempool/pmempool-feature.1.md @@ -44,19 +44,16 @@ date: pmem Tools version 1.4 [EXAMPLE](#example)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **pmempool-feature** - toggle or query pool set features - # SYNOPSIS # ``` $ pmempool feature (-e|-d|-q feature-name) [options] <file> ``` - # DESCRIPTION # The **pmempool feature** command enables / disables or queries pool set features. @@ -115,18 +112,15 @@ Disable feature for pool set. Print feature status. - # COMPATIBILITY # Poolsets with features not defined in this document (e.g. enabled by the newer software version) are not supported. - # DISCLAIMER # ```pmempool feature``` command is not fail safe. - # EXAMPLE # ``` @@ -148,7 +142,6 @@ $ pmempool feature --query CHECKSUM_2K pool.set Prints POOL_FEAT_CKSUM_2K incompat feature flag value. - # SEE ALSO # **poolset**(5) and **<http://pmem.io>** diff --git a/doc/pmempool/pmempool-info.1.md b/doc/pmempool/pmempool-info.1.md index b86e979fa..43623e9dd 100644 --- a/doc/pmempool/pmempool-info.1.md +++ b/doc/pmempool/pmempool-info.1.md @@ -44,19 +44,16 @@ date: pmem Tools version 1.4 [EXAMPLE](#example)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **pmempool-info** - show information about persistent memory pool - # SYNOPSIS # ``` $ pmempool info [<options>] <file> ``` - # DESCRIPTION # The **pmempool** invoked with *info* command analyzes an existing pool @@ -152,7 +149,6 @@ Print bad blocks found in the pool. Display help message and exit. - ##### Options for PMEMLOG: ##### `-w, --walk <size>` @@ -160,7 +156,6 @@ Display help message and exit. Use this option to walk through used data with fixed data chunk size. See **pmemlog_walk**(3) in **libpmemlog**(7) for details. - ##### Options for PMEMBLK: ##### By default the *info* command displays the **pmemblk** header and @@ -202,7 +197,6 @@ Skip blocks marked with *error* flag. Skip blocks *not* marked with any flag. - ##### Options for PMEMOBJ: ##### By default the *info* command displays pool header and **pmemobj** pool descriptor. @@ -287,7 +281,6 @@ This option requires **-H, --heap** and **-C, --chunks** options. Print information from *\<num\>* replica. The 0 value means the master pool file. - # RANGE # Using **-r, --range** option it is possible to dump only a range of user data. @@ -311,7 +304,6 @@ All blocks/bytes/data chunks starting from *\<first\>* will be dumped. Only *\<number\>* block/byte/data chunk will be dumped. - # STATISTICS # Below is the description of statistical measures for specific pool types. @@ -322,7 +314,6 @@ Below is the description of statistical measures for specific pool types. + **Available** - Size and percentage of available space. + **Used** - Size and percentage of used space. - ##### PMEMBLK ##### + **Total blocks** - Total number of blocks in pool. @@ -335,7 +326,6 @@ In case of pmemblk, statistics are evaluated for blocks which meet requirements *range* of blocks (**-r** option), *skipped* types of blocks (**-z**, **-e**, **-u** options). - ##### PMEMOBJ ##### + **Object store** @@ -362,7 +352,6 @@ In case of pmemblk, statistics are evaluated for blocks which meet requirements + **Total bytes** - Total number of bytes of all classes. + **Total used bytes** - Total number of used bytes of all classes. - # EXAMPLE # ``` @@ -390,7 +379,6 @@ $ pmempool info -d -r10-100 -eu ./pmemblk Print information from "pmemblk" file. Dump data blocks from 10 to 100, skip blocks marked with error flag and not marked with any flag. - # SEE ALSO # **pmempool**(1), **libpmemblk**(7), **libpmemlog**(7), diff --git a/doc/pmempool/pmempool-rm.1.md b/doc/pmempool/pmempool-rm.1.md index 36fef628c..c192a3b55 100644 --- a/doc/pmempool/pmempool-rm.1.md +++ b/doc/pmempool/pmempool-rm.1.md @@ -42,19 +42,16 @@ date: pmem Tools version 1.4 [EXAMPLE](#example)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **pmempool-rm** - remove a persistent memory pool - # SYNOPSIS # ``` $ pmempool rm [<options>] <file>.. ``` - # DESCRIPTION # The **pmempool rm** command removes each specified file. If the specified file @@ -103,7 +100,6 @@ Remove all specified files, ignore nonexistent files, never prompt. Prompt before removing every single file or remote pool. - # REMOTE REPLICATION # A remote pool is removed using **rpmem_remove**(3) function if **librpmem**(7) @@ -111,7 +107,6 @@ library is available. If a pool set file contains remote replication but **librpmem**(7) is not available, the **pmempool rm** command terminates with an error code, unless the **-f, --force** option is specified. - # EXAMPLE # ``` @@ -133,7 +128,6 @@ $ pmempool rm -a pool.set Remove all pool files from the "pool.set", remove the local pool set file and all remote pool set files. - # SEE ALSO # **pmempool**(1), **libpmemblk**(7), **libpmemlog**(7), diff --git a/doc/pmempool/pmempool-sync.1.md b/doc/pmempool/pmempool-sync.1.md index 7535ba1c3..52c25a443 100644 --- a/doc/pmempool/pmempool-sync.1.md +++ b/doc/pmempool/pmempool-sync.1.md @@ -46,7 +46,6 @@ date: pmem Tools version 1.4 **pmempool-sync** - Synchronize replicas or their parts within a pool set. - # SYNOPSIS # ``` @@ -115,7 +114,6 @@ viability of synchronization. : Display help message and exit. - # SEE ALSO # **pmempool(1)**, **libpmemblk(7)**, **libpmemlog(7)**, diff --git a/doc/pmempool/pmempool-transform.1.md b/doc/pmempool/pmempool-transform.1.md index d398b9666..171ee781a 100644 --- a/doc/pmempool/pmempool-transform.1.md +++ b/doc/pmempool/pmempool-transform.1.md @@ -46,14 +46,12 @@ date: pmem Tools version 1.4 **pmempool-transform** - Modify internal structure of a pool set. - # SYNOPSIS # ``` pmempool transform [options] <poolset_file_src> <poolset_file_dst> ``` - # DESCRIPTION # The **pmempool transform** command modifies internal structure of a pool set @@ -75,7 +73,6 @@ Only one of the above operations can be performed at a time. Currently adding and removing replicas are allowed only for **pmemobj** pools (see **libpmemobj**(7)). - The *poolset_file_src* argument provides the source pool set to be changed. The *poolset_file_dst* argument points to the target pool set. @@ -112,7 +109,6 @@ If the option *NOHDRS* is used, the effective size of a replica is the sum of sizes of all its part files. In this case none of the parts contains internal metadata.=e=) - ##### Available options: ##### `-d, --dry-run` @@ -128,7 +124,6 @@ viability of the operation is performed. : Display help message and exit. - # EXAMPLES # ##### Example 1. ##### @@ -194,7 +189,6 @@ Then deletes the second replica from the pool set. The first replica remains unchanged and the size of the pool is still 60M. - # SEE ALSO # **pmempool(1)**, **libpmemblk(7)**, **libpmemlog(7)**, diff --git a/doc/pmempool/pmempool.1.md b/doc/pmempool/pmempool.1.md index 1a29d9e26..b9e6f3d66 100644 --- a/doc/pmempool/pmempool.1.md +++ b/doc/pmempool/pmempool.1.md @@ -43,12 +43,10 @@ date: pmem Tools version 1.4 [COMMANDS](#commands)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **pmempool** - Persistent Memory Pool Management Tool - # SYNOPSIS # ``` @@ -70,7 +68,6 @@ The **pmempool** may be useful for troubleshooting by system administrators and for software developers who work on applications based on **PMDK**. The latter may find these tools useful for testing and debugging purposes also. - # OPTIONS # `-V, --version` @@ -81,7 +78,6 @@ Prints the version of **pmempool**. Prints synopsis and list of commands. - # COMMANDS # Currently there is a following set of commands available: @@ -115,7 +111,6 @@ Toggle or query a poolset features. In order to get more information about specific *command* you can use **pmempool help <command>.** - # SEE ALSO # **libpmemblk**(7), **libpmemlog**(7), **libpmemobj**(7) diff --git a/doc/pmreorder/pmreorder.1.md b/doc/pmreorder/pmreorder.1.md index 1dc0bb8b0..c284cedd2 100644 --- a/doc/pmreorder/pmreorder.1.md +++ b/doc/pmreorder/pmreorder.1.md @@ -47,20 +47,17 @@ date: pmreorder version 1.5 [EXAMPLE](#example)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **pmreorder** - performs a persistent consistency check using a store reordering mechanism - # SYNOPSIS # ``` $ python pmreorder <options> ``` - # DESCRIPTION # The pmreorder tool is a collection of python scripts designed @@ -77,7 +74,6 @@ Considering that logging, replaying and reordering of operations are very time consuming, it is recommended to use as few stores as possible in test workloads. - # OPTIONS # `-h, --help` @@ -141,7 +137,6 @@ Set the initial reorder engine. Default value is `NoReorderNoCheck`. Assign an engine types to the defined marker. - # ENGINES # By default, the **NoReorderNoCheck** engine is used, @@ -235,7 +230,6 @@ separately for any marked code sections. For more details about `-x` extended macros functionality see section INSTRUMENTATION below. - # INSTRUMENTATION # The core of **pmreorder** is based on user-provided named markers. @@ -380,7 +374,6 @@ pmem_memcpy_persist pmem_memset_persist ``` - # PMEMCHECK STORE LOG # To generate *store_log* for **pmreorder** run pmemcheck @@ -401,7 +394,6 @@ valgrind \ For further details of pmemcheck parameters see [pmemcheck documentation](https://github.com/pmem/valgrind/blob/pmem-3.13/pmemcheck/docs/pmc-manual.xml) - # ENVIRONMENT # By default all logging from PMDK libraries is disabled. @@ -409,7 +401,6 @@ To enable API macros logging set environment variable: + **PMREORDER_EMIT_LOG**=1 - # EXAMPLE # ``` @@ -427,7 +418,6 @@ Checker binary will be used to run consistency checks on stores found during **pmreorder** analysis will be logged to `pmreorder_out.log`. - # SEE ALSO # **<http://pmem.io>** diff --git a/doc/poolset/poolset.5.md b/doc/poolset/poolset.5.md index c0163a11c..f448eed2a 100644 --- a/doc/poolset/poolset.5.md +++ b/doc/poolset/poolset.5.md @@ -44,19 +44,16 @@ date: poolset API version 1.0 [NOTES](#notes)<br /> [SEE ALSO](#see-also)<br /> - # NAME # poolset - persistent memory pool configuration file format - # SYNOPSIS # ```c mypool.set ``` - # DESCRIPTION # Depending on the configuration of the system, the available non-volatile @@ -222,7 +219,6 @@ _WINUX(, =q=Remote replica cannot have replicas, i.e. a remote pool set file cannot define any replicas.=e=) - # POOL SET OPTIONS # Pool set options can appear anywhere after the line with *PMEMPOOLSET* string. @@ -257,7 +253,6 @@ Using the *SINGLEHDR* and *NOHDRS* options has important implications for data integrity checking and recoverability in case of a pool set damage. See _UW(pmempool_sync) API for more information about pool set recovery. - # DIRECTORIES # Providing a directory as a part's *pathname* allows the pool to dynamically @@ -313,7 +308,6 @@ replicated pool set, the *path* argument passed to **pmemobj_open**(3), **pmemblk_open**(3) or **pmemlog_open**(3) must point to the same *set* file that was used for pool set creation. - # SEE ALSO # **ndctl-create-namespace**(1), **pmemblk_create**(3), **pmemlog_create**(3), diff --git a/doc/rpmemd/rpmemd.1.md b/doc/rpmemd/rpmemd.1.md index d21016e6b..ec4a1a119 100644 --- a/doc/rpmemd/rpmemd.1.md +++ b/doc/rpmemd/rpmemd.1.md @@ -46,26 +46,22 @@ date: rpmemd version 1.4 [PERSISTENCY METHODS](#persistency-methods)<br /> [SEE ALSO](#see-also)<br /> - # NAME # **rpmemd** - librpmem target node process (EXPERIMENTAL) - # SYNOPSIS # ``` $ rpmemd [--help] [--version] [<args>] ``` - # DESCRIPTION # The **rpmemd** process is executed on target node by **librpmem**(7) library over **ssh**(1) and facilitates access to persistent memory over RDMA. The **rpmemd** should not be run manually under normal conditions. - # OPTIONS # Command line options overwrite the default **rpmemd** configuration, the global @@ -157,7 +153,6 @@ The allowed options are: The **$HOME** sub-string in the *poolset-dir* path is replaced with the current user home directory. - # EXAMPLE # Example of the configuration file: @@ -172,7 +167,6 @@ use-syslog = no # Use log file instead of syslog log-level = info ``` - # DEFAULT CONFIGURATION # The **rpmemd** default configuration is equivalent of the following @@ -187,7 +181,6 @@ use-syslog = yes log-level = err ``` - # PERSISTENCY METHODS # The **librpmem**(7) supports two methods for making data written to remote @@ -230,7 +223,6 @@ If the pool set is NOT stored in the persistent momory it will use See **pmem_persist**(3) and **pmem_msync**(3) for more details. - # SEE ALSO # **ssh**(1), **pmem_msync**(3), **pmem_persist**(3), diff --git a/src/common/ctl.c b/src/common/ctl.c index 76753780b..519e33929 100644 --- a/src/common/ctl.c +++ b/src/common/ctl.c @@ -338,8 +338,6 @@ out: return ret; } - - /* * ctl_register_module_node -- adds a new node to the CTL tree root. */ diff --git a/src/common/os_auto_flush_linux.c b/src/common/os_auto_flush_linux.c index b0c8517fb..6efaade93 100644 --- a/src/common/os_auto_flush_linux.c +++ b/src/common/os_auto_flush_linux.c @@ -158,7 +158,6 @@ end: return cpu_cache; } - /* * os_auto_flush -- check if platform supports auto flush for all regions * diff --git a/src/common/os_auto_flush_windows.h b/src/common/os_auto_flush_windows.h index 5a1bb708f..fdc77ef23 100644 --- a/src/common/os_auto_flush_windows.h +++ b/src/common/os_auto_flush_windows.h @@ -1,5 +1,5 @@ /* - * Copyright 2018, Intel Corporation + * Copyright 2018-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -33,7 +33,6 @@ #ifndef PMDK_OS_AUTO_FLUSH_WINDOWS_H #define PMDK_OS_AUTO_FLUSH_WINDOWS_H 1 - #define ACPI_SIGNATURE 0x41435049 /* hex value of ACPI signature */ #define NFIT_REV_SIGNATURE 0x5449464e /* hex value of htonl(NFIT) signature */ #define NFIT_STR_SIGNATURE "NFIT" diff --git a/src/common/os_dimm_ndctl.c b/src/common/os_dimm_ndctl.c index 5dbd23a0b..8bae1da70 100644 --- a/src/common/os_dimm_ndctl.c +++ b/src/common/os_dimm_ndctl.c @@ -59,7 +59,6 @@ ndctl_region_foreach(bus, region) \ ndctl_namespace_foreach(region, ndns) \ - /* * os_dimm_match_devdax -- (internal) returns 1 if the devdax matches * with the given file, 0 if it doesn't match, diff --git a/src/common/os_thread.h b/src/common/os_thread.h index 27953615f..3b80f3698 100644 --- a/src/common/os_thread.h +++ b/src/common/os_thread.h @@ -1,5 +1,5 @@ /* - * Copyright 2015-2018, Intel Corporation + * Copyright 2015-2019, Intel Corporation * Copyright (c) 2016, Microsoft Corporation. All rights reserved. * * Redistribution and use in source and binary forms, with or without @@ -168,7 +168,6 @@ int os_thread_setaffinity_np(os_thread_t *thread, size_t set_size, int os_thread_atfork(void (*prepare)(void), void (*parent)(void), void (*child)(void)); - int os_semaphore_init(os_semaphore_t *sem, unsigned value); int os_semaphore_destroy(os_semaphore_t *sem); int os_semaphore_wait(os_semaphore_t *sem); diff --git a/src/common/os_windows.c b/src/common/os_windows.c index 06ba97d0c..c0aca0d14 100644 --- a/src/common/os_windows.c +++ b/src/common/os_windows.c @@ -294,7 +294,6 @@ out: return ret; } - /* * os_posix_fallocate -- allocate file space */ @@ -491,7 +490,6 @@ os_clock_gettime(int id, struct timespec *ts) return 0; } - /* * os_setenv -- change or add an environment variable */ diff --git a/src/common/rand.c b/src/common/rand.c index ef55d0fe8..f047cc276 100644 --- a/src/common/rand.c +++ b/src/common/rand.c @@ -143,7 +143,6 @@ rnd64(void) return rnd64_r(&global_rng); } - /* * randomize -- initialize global RNG */ diff --git a/src/common/set.c b/src/common/set.c index bb7c3be3d..21ced9007 100644 --- a/src/common/set.c +++ b/src/common/set.c @@ -1133,7 +1133,6 @@ util_replica_check_map_sync(struct pool_set *set, unsigned repidx, int map_sync = rep->part[0].map_sync; - for (unsigned p = 1; p < rep->nparts; p++) { if (map_sync != rep->part[p].map_sync) { ERR("replica #%u part %u %smapped with MAP_SYNC", @@ -2589,7 +2588,6 @@ util_header_check_remote(struct pool_set *set, unsigned partidx) shutdown_state_set_dirty(&hdrp->sds, rep); } - rep->part[partidx].rdonly = 0; return 0; diff --git a/src/common/util.h b/src/common/util.h index 7d1c23cfa..cf48a54be 100644 --- a/src/common/util.h +++ b/src/common/util.h @@ -312,7 +312,6 @@ typedef enum { _ReadWriteBarrier();\ } while (0) - #define util_atomic_load_explicit32 util_atomic_load_explicit #define util_atomic_load_explicit64 util_atomic_load_explicit diff --git a/src/common/vec.h b/src/common/vec.h index 3b99861b9..fc04d3af3 100644 --- a/src/common/vec.h +++ b/src/common/vec.h @@ -74,7 +74,6 @@ struct name {\ (vecr)->capacity = 0;\ } while (0) - #define VEC_REINIT(vec) do {\ VALGRIND_ANNOTATE_NEW_MEMORY((vec), sizeof(*vec));\ VALGRIND_ANNOTATE_NEW_MEMORY((vec)->buffer,\ diff --git a/src/examples/libpmemobj/hashmap/hashmap_tx.c b/src/examples/libpmemobj/hashmap/hashmap_tx.c index 02349d7f0..5c131e77b 100644 --- a/src/examples/libpmemobj/hashmap/hashmap_tx.c +++ b/src/examples/libpmemobj/hashmap/hashmap_tx.c @@ -1,5 +1,5 @@ /* - * Copyright 2015-2017, Intel Corporation + * Copyright 2015-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -41,7 +41,6 @@ #include "hashmap_tx.h" #include "hashmap_internal.h" - /* layout definition */ TOID_DECLARE(struct buckets, HASHMAP_TX_TYPE_OFFSET + 1); TOID_DECLARE(struct entry, HASHMAP_TX_TYPE_OFFSET + 2); diff --git a/src/examples/libpmemobj/libart/art.c b/src/examples/libpmemobj/libart/art.c index 6e20bb3fd..431387503 100644 --- a/src/examples/libpmemobj/libart/art.c +++ b/src/examples/libpmemobj/libart/art.c @@ -1,7 +1,7 @@ /* * Copyright 2016, FUJITSU TECHNOLOGY SOLUTIONS GMBH * Copyright 2012, Armon Dadgar. All rights reserved. - * Copyright 2017, Intel Corporation + * Copyright 2016-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -1280,7 +1280,6 @@ art_delete(PMEMobjpool *pop, return retval; } - // Recursively iterates over the tree static int recursive_iter(TOID(art_node_u)n, art_callback cb, void *data) diff --git a/src/examples/libpmemobj/libart/art.h b/src/examples/libpmemobj/libart/art.h index a7053cfa6..c816a5eac 100644 --- a/src/examples/libpmemobj/libart/art.h +++ b/src/examples/libpmemobj/libart/art.h @@ -1,6 +1,7 @@ /* * Copyright 2016, FUJITSU TECHNOLOGY SOLUTIONS GMBH * Copyright 2012, Armon Dadgar. All rights reserved. + * Copyright 2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -191,7 +192,6 @@ typedef struct _cb_data { TX_MEMCPY(D_RW(_obj)->s, _blob, _len); \ D_RW(_obj)->s[(_len) - 1] = '\0'; - typedef int(*art_callback)(void *data, const unsigned char *key, uint32_t key_len, const unsigned char *value, uint32_t val_len); diff --git a/src/examples/libpmemobj/map/mapcli.c b/src/examples/libpmemobj/map/mapcli.c index c447b2871..d5e1f3d2d 100644 --- a/src/examples/libpmemobj/map/mapcli.c +++ b/src/examples/libpmemobj/map/mapcli.c @@ -1,5 +1,5 @@ /* - * Copyright 2015-2018, Intel Corporation + * Copyright 2015-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -254,7 +254,6 @@ main(int argc, char *argv[]) args.seed = (uint32_t)time(NULL); srand(args.seed); - mapc = map_ctx_init(ops, pop); if (!mapc) { pmemobj_close(pop); diff --git a/src/examples/libpmemobj/pi.c b/src/examples/libpmemobj/pi.c index 0b9099b0c..2de400bce 100644 --- a/src/examples/libpmemobj/pi.c +++ b/src/examples/libpmemobj/pi.c @@ -1,5 +1,5 @@ /* - * Copyright 2015-2017, Intel Corporation + * Copyright 2015-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -54,7 +54,6 @@ POBJ_LAYOUT_ROOT(pi, struct pi); POBJ_LAYOUT_TOID(pi, struct pi_task); POBJ_LAYOUT_END(pi); - static PMEMobjpool *pop; struct pi_task_proto { diff --git a/src/examples/libpmemobj/pmemblk/obj_pmemblk.c b/src/examples/libpmemobj/pmemblk/obj_pmemblk.c index 08a1ec2d9..05ab8239a 100644 --- a/src/examples/libpmemobj/pmemblk/obj_pmemblk.c +++ b/src/examples/libpmemobj/pmemblk/obj_pmemblk.c @@ -1,5 +1,5 @@ /* - * Copyright 2015-2018, Intel Corporation + * Copyright 2015-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -30,7 +30,6 @@ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ - /* * obj_pmemblk.c -- alternate pmemblk implementation based on pmemobj * diff --git a/src/examples/libpmemobj/pmemlog/obj_pmemlog.c b/src/examples/libpmemobj/pmemlog/obj_pmemlog.c index 63ac3d46e..f72e76301 100644 --- a/src/examples/libpmemobj/pmemlog/obj_pmemlog.c +++ b/src/examples/libpmemobj/pmemlog/obj_pmemlog.c @@ -1,5 +1,5 @@ /* - * Copyright 2015-2017, Intel Corporation + * Copyright 2015-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -72,7 +72,6 @@ enum types { MAX_TYPES }; - /* log entry header */ struct log_hdr { PMEMoid next; /* object ID of the next log buffer */ diff --git a/src/examples/libpmemobj/pmemlog/obj_pmemlog_macros.c b/src/examples/libpmemobj/pmemlog/obj_pmemlog_macros.c index f641ee578..408eaa988 100644 --- a/src/examples/libpmemobj/pmemlog/obj_pmemlog_macros.c +++ b/src/examples/libpmemobj/pmemlog/obj_pmemlog_macros.c @@ -1,5 +1,5 @@ /* - * Copyright 2015-2017, Intel Corporation + * Copyright 2015-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -356,7 +356,6 @@ main(int argc, char *argv[]) return 1; } - if (plp == NULL) { perror("pmemlog_create/pmemlog_open"); return 1; diff --git a/src/examples/libpmemobj/pmemobjfs/Makefile b/src/examples/libpmemobj/pmemobjfs/Makefile index ce367c756..e18fd0de1 100644 --- a/src/examples/libpmemobj/pmemobjfs/Makefile +++ b/src/examples/libpmemobj/pmemobjfs/Makefile @@ -1,5 +1,5 @@ # -# Copyright 2015-2016, Intel Corporation +# Copyright 2015-2019, Intel Corporation # # Redistribution and use in source and binary forms, with or without # modification, are permitted provided that the following conditions @@ -58,7 +58,6 @@ clean-progs: clean-links include ../../Makefile.inc - LIBS += -lpmemobj -lpmem -pthread ifeq ($(FUSE), y) diff --git a/src/examples/libpmemobj/pmemobjfs/pmemobjfs.c b/src/examples/libpmemobj/pmemobjfs/pmemobjfs.c index 5267626d2..94342362f 100644 --- a/src/examples/libpmemobj/pmemobjfs/pmemobjfs.c +++ b/src/examples/libpmemobj/pmemobjfs/pmemobjfs.c @@ -761,7 +761,6 @@ pmemobjfs_read(struct pmemobjfs *objfs, TOID(struct objfs_inode) inode, memcpy(buff, &D_RW(block)[block_off], block_size); } - buff += block_size; off += block_size; sz -= block_size; @@ -916,7 +915,6 @@ pmemobjfs_remove_dir_entry_name(struct pmemobjfs *objfs, } TX_END } - /* * pmemobjfs_add_dir_entry -- add new directory entry */ @@ -1031,7 +1029,6 @@ pmemobjfs_mkdir(struct pmemobjfs *objfs, TOID(struct objfs_inode) inode, return ret; } - /* * pmemobjfs_remove_dir -- remove directory from directory */ @@ -2447,7 +2444,6 @@ main(int argc, char *argv[]) log("\n\n\nPMEMOBJFS\n"); #endif - const char *fname = argv[argc - 2]; struct pmemobjfs *objfs = calloc(1, sizeof(*objfs)); if (!objfs) { diff --git a/src/examples/libpmemobj/pminvaders/Makefile b/src/examples/libpmemobj/pminvaders/Makefile index 46c0c3e01..0feaa42f5 100644 --- a/src/examples/libpmemobj/pminvaders/Makefile +++ b/src/examples/libpmemobj/pminvaders/Makefile @@ -1,5 +1,5 @@ # -# Copyright 2015-2016, Intel Corporation +# Copyright 2015-2019, Intel Corporation # # Redistribution and use in source and binary forms, with or without # modification, are permitted provided that the following conditions @@ -53,6 +53,5 @@ endif include ../../Makefile.inc - pminvaders: pminvaders.o pminvaders2: pminvaders2.o diff --git a/src/examples/libpmemobj/pminvaders/pminvaders.c b/src/examples/libpmemobj/pminvaders/pminvaders.c index 9d4bc7e3d..70e5f661e 100644 --- a/src/examples/libpmemobj/pminvaders/pminvaders.c +++ b/src/examples/libpmemobj/pminvaders/pminvaders.c @@ -1,5 +1,5 @@ /* - * Copyright 2015-2017, Intel Corporation + * Copyright 2015-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -111,7 +111,6 @@ POBJ_LAYOUT_TOID(pminvaders, struct alien); POBJ_LAYOUT_TOID(pminvaders, struct bullet); POBJ_LAYOUT_END(pminvaders); - static PMEMobjpool *pop; static struct game_state *gstate; diff --git a/src/examples/libpmemobj/pminvaders/pminvaders2.c b/src/examples/libpmemobj/pminvaders/pminvaders2.c index 92ad493bb..c85b8f0fc 100644 --- a/src/examples/libpmemobj/pminvaders/pminvaders2.c +++ b/src/examples/libpmemobj/pminvaders/pminvaders2.c @@ -1,5 +1,5 @@ /* - * Copyright 2015-2018, Intel Corporation + * Copyright 2015-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -52,7 +52,6 @@ #include <libpmem.h> #include <libpmemobj.h> - /* * Layout definition */ @@ -65,7 +64,6 @@ POBJ_LAYOUT_TOID(pminvaders2, struct bullet); POBJ_LAYOUT_TOID(pminvaders2, struct star); POBJ_LAYOUT_END(pminvaders2); - #define POOL_SIZE (100 * 1024 * 1024) /* 100 megabytes */ #define GAME_WIDTH 50 @@ -89,7 +87,6 @@ POBJ_LAYOUT_END(pminvaders2); #define MAX_STAR1_TIMER 200 #define MAX_STAR2_TIMER 100 - enum game_event { EVENT_NOP, EVENT_BOUNCE, diff --git a/src/examples/libpmemobj/string_store/layout.h b/src/examples/libpmemobj/string_store/layout.h index a03fbcb30..9d94615bd 100644 --- a/src/examples/libpmemobj/string_store/layout.h +++ b/src/examples/libpmemobj/string_store/layout.h @@ -1,5 +1,5 @@ /* - * Copyright 2015-2017, Intel Corporation + * Copyright 2015-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -34,7 +34,6 @@ * layout.h -- example from introduction part 1 */ - #define LAYOUT_NAME "intro_1" #define MAX_BUF_LEN 10 diff --git a/src/examples/libpmemobj/string_store_tx/layout.h b/src/examples/libpmemobj/string_store_tx/layout.h index e5c8d388f..7b9ea892d 100644 --- a/src/examples/libpmemobj/string_store_tx/layout.h +++ b/src/examples/libpmemobj/string_store_tx/layout.h @@ -1,5 +1,5 @@ /* - * Copyright 2015-2017, Intel Corporation + * Copyright 2015-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -34,7 +34,6 @@ * layout.h -- example from introduction part 2 */ - #define LAYOUT_NAME "intro_2" #define MAX_BUF_LEN 10 diff --git a/src/examples/libpmemobj/tree_map/btree_map.c b/src/examples/libpmemobj/tree_map/btree_map.c index f02a74a96..141734744 100644 --- a/src/examples/libpmemobj/tree_map/btree_map.c +++ b/src/examples/libpmemobj/tree_map/btree_map.c @@ -1,5 +1,5 @@ /* - * Copyright 2015-2018, Intel Corporation + * Copyright 2015-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -49,7 +49,6 @@ struct tree_map_node_item { PMEMoid value; }; - struct tree_map_node { int n; /* number of occupied slots */ struct tree_map_node_item items[BTREE_ORDER - 1]; @@ -101,7 +100,6 @@ btree_map_clear_node(TOID(struct tree_map_node) node) TX_FREE(node); } - /* * btree_map_clear -- removes all elements from the map */ @@ -122,7 +120,6 @@ btree_map_clear(PMEMobjpool *pop, TOID(struct btree_map) map) return ret; } - /* * btree_map_destroy -- cleanups and frees btree instance */ diff --git a/src/examples/libpmemobj/tree_map/ctree_map.c b/src/examples/libpmemobj/tree_map/ctree_map.c index 639da18d0..d11526be3 100644 --- a/src/examples/libpmemobj/tree_map/ctree_map.c +++ b/src/examples/libpmemobj/tree_map/ctree_map.c @@ -1,5 +1,5 @@ /* - * Copyright 2015-2017, Intel Corporation + * Copyright 2015-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -106,7 +106,6 @@ ctree_map_clear_node(PMEMoid p) pmemobj_tx_free(p); } - /* * ctree_map_clear -- removes all elements from the map */ @@ -198,7 +197,6 @@ ctree_map_insert_new(PMEMobjpool *pop, TOID(struct ctree_map) map, return ret; } - /* * ctree_map_insert -- inserts a new key-value pair into the map */ diff --git a/src/examples/libpmemobj/tree_map/rbtree_map.c b/src/examples/libpmemobj/tree_map/rbtree_map.c index 48a4fe671..370347dc8 100644 --- a/src/examples/libpmemobj/tree_map/rbtree_map.c +++ b/src/examples/libpmemobj/tree_map/rbtree_map.c @@ -1,5 +1,5 @@ /* - * Copyright 2015-2017, Intel Corporation + * Copyright 2015-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -143,7 +143,6 @@ rbtree_map_clear_node(TOID(struct rbtree_map) map, TOID(struct tree_map_node) p) TX_FREE(p); } - /* * rbtree_map_clear -- removes all elements from the map */ @@ -164,7 +163,6 @@ rbtree_map_clear(PMEMobjpool *pop, TOID(struct rbtree_map) map) return 0; } - /* * rbtree_map_destroy -- cleanups and frees red-black tree instance */ diff --git a/src/examples/libpmemobj/tree_map/rtree_map.c b/src/examples/libpmemobj/tree_map/rtree_map.c index a651162f2..1eb16e155 100644 --- a/src/examples/libpmemobj/tree_map/rtree_map.c +++ b/src/examples/libpmemobj/tree_map/rtree_map.c @@ -1,5 +1,5 @@ /* - * Copyright 2016-2017, Intel Corporation + * Copyright 2016-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -42,7 +42,6 @@ #include "rtree_map.h" - TOID_DECLARE(struct tree_map_node, RTREE_MAP_TYPE_OFFSET + 1); /* Good values: 0x10 an 0x100, but implementation is bound to 0x100 */ @@ -95,7 +94,6 @@ rtree_map_clear_node(TOID(struct tree_map_node) node) TX_FREE(node); } - /* * rtree_map_clear -- removes all elements from the map */ @@ -116,7 +114,6 @@ rtree_map_clear(PMEMobjpool *pop, TOID(struct rtree_map) map) return ret; } - /* * rtree_map_destroy -- cleanups and frees rtree instance */ diff --git a/src/include/libpmemobj/base.h b/src/include/libpmemobj/base.h index af199ecff..e47a4d263 100644 --- a/src/include/libpmemobj/base.h +++ b/src/include/libpmemobj/base.h @@ -297,7 +297,6 @@ const wchar_t *pmemobj_check_versionW(unsigned major_required, unsigned minor_required); #endif - /* * Passing NULL to pmemobj_set_funcs() tells libpmemobj to continue to use the * default for that function. The replacement functions must not make calls diff --git a/src/include/libpmemobj/iterator.h b/src/include/libpmemobj/iterator.h index ce52c2d97..090d6618f 100644 --- a/src/include/libpmemobj/iterator.h +++ b/src/include/libpmemobj/iterator.h @@ -1,5 +1,5 @@ /* - * Copyright 2014-2017, Intel Corporation + * Copyright 2014-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -68,7 +68,6 @@ POBJ_NEXT_TYPE_NUM(PMEMoid o) return _pobj_ret; } - #define POBJ_FIRST(pop, t) ((TOID(t))POBJ_FIRST_TYPE_NUM(pop, TOID_TYPE_NUM(t))) #define POBJ_NEXT(o) ((__typeof__(o))POBJ_NEXT_TYPE_NUM((o).oid)) diff --git a/src/include/libpmemobj/iterator_base.h b/src/include/libpmemobj/iterator_base.h index 42cfad90c..4606dd9ac 100644 --- a/src/include/libpmemobj/iterator_base.h +++ b/src/include/libpmemobj/iterator_base.h @@ -1,5 +1,5 @@ /* - * Copyright 2014-2017, Intel Corporation + * Copyright 2014-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -61,7 +61,6 @@ PMEMoid pmemobj_first(PMEMobjpool *pop); */ PMEMoid pmemobj_next(PMEMoid oid); - #ifdef __cplusplus } #endif diff --git a/src/include/libpmemobj/tx.h b/src/include/libpmemobj/tx.h index 5f314fc85..71e5f0df7 100644 --- a/src/include/libpmemobj/tx.h +++ b/src/include/libpmemobj/tx.h @@ -143,7 +143,6 @@ pmemobj_tx_xadd_range_direct(p, sizeof(*(p)), flags) #define TX_XADD_FIELD_DIRECT(p, field, flags)\ pmemobj_tx_xadd_range_direct(&(p)->field, sizeof((p)->field), flags) - #define TX_NEW(t)\ ((TOID(t))pmemobj_tx_alloc(sizeof(t), TOID_TYPE_NUM(t))) diff --git a/src/include/libpmempool.h b/src/include/libpmempool.h index c08a95609..811c4a7eb 100644 --- a/src/include/libpmempool.h +++ b/src/include/libpmempool.h @@ -158,7 +158,6 @@ enum pmempool_check_result pmempool_check_end(PMEMpoolcheck *ppc); #define PMEMPOOL_RM_POOLSET_LOCAL (1U << 1) /* remove local poolsets */ #define PMEMPOOL_RM_POOLSET_REMOTE (1U << 2) /* remove remote poolsets */ - /* * LIBPMEMPOOL SYNC */ @@ -172,7 +171,6 @@ enum pmempool_check_result pmempool_check_end(PMEMpoolcheck *ppc); */ #define PMEMPOOL_SYNC_DRY_RUN (1U << 1) - /* * LIBPMEMPOOL TRANSFORM */ @@ -182,7 +180,6 @@ enum pmempool_check_result pmempool_check_end(PMEMpoolcheck *ppc); */ #define PMEMPOOL_TRANSFORM_DRY_RUN (1U << 1) - /* * PMEMPOOL_MAJOR_VERSION and PMEMPOOL_MINOR_VERSION provide the current version * of the libpmempool API as provided by this header file. Applications can diff --git a/src/libpmemblk/blk.c b/src/libpmemblk/blk.c index 29891ebd1..fe35b7e31 100644 --- a/src/libpmemblk/blk.c +++ b/src/libpmemblk/blk.c @@ -628,7 +628,6 @@ pmemblk_openW(const wchar_t *path, size_t bsize) } #endif - /* * pmemblk_close -- close a block memory pool */ diff --git a/src/libpmemblk/blk.h b/src/libpmemblk/blk.h index 5d197b646..922591a90 100644 --- a/src/libpmemblk/blk.h +++ b/src/libpmemblk/blk.h @@ -101,7 +101,6 @@ struct pmemblk { /* data area starts at this alignment after the struct pmemblk above */ #define BLK_FORMAT_DATA_ALIGN ((uintptr_t)4096) - #if FAULT_INJECTION void pmemblk_inject_fault_at(enum pmem_allocation_type type, int nth, diff --git a/src/libpmemblk/btt.c b/src/libpmemblk/btt.c index 8fbe0c244..6208299ec 100644 --- a/src/libpmemblk/btt.c +++ b/src/libpmemblk/btt.c @@ -2004,7 +2004,6 @@ check_arena(struct btt *bttp, struct arena *arenap) consistent = 0; } - Free(bitmap); return consistent; diff --git a/src/libpmemobj/alloc_class.h b/src/libpmemobj/alloc_class.h index 173cfefbe..83c382fa5 100644 --- a/src/libpmemobj/alloc_class.h +++ b/src/libpmemobj/alloc_class.h @@ -1,5 +1,5 @@ /* - * Copyright 2016-2018, Intel Corporation + * Copyright 2016-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -104,7 +104,6 @@ alloc_class_new(int id, struct alloc_class_collection *ac, void alloc_class_delete(struct alloc_class_collection *ac, struct alloc_class *c); - #ifdef __cplusplus } #endif diff --git a/src/libpmemobj/critnib.c b/src/libpmemobj/critnib.c index 41fec793d..d63c3914e 100644 --- a/src/libpmemobj/critnib.c +++ b/src/libpmemobj/critnib.c @@ -40,7 +40,6 @@ * cause latency (ie, better worst case behaviour). */ - /* * STRUCTURE DESCRIPTION * diff --git a/src/libpmemobj/list.c b/src/libpmemobj/list.c index 769bd9cbe..0ac25c1c3 100644 --- a/src/libpmemobj/list.c +++ b/src/libpmemobj/list.c @@ -203,7 +203,6 @@ list_set_oid_redo_log(PMEMobjpool *pop, return 0; } - /* * list_update_head -- (internal) update pe_first entry in list head */ diff --git a/src/libpmemobj/obj.c b/src/libpmemobj/obj.c index 4f725da7c..0f015b219 100644 --- a/src/libpmemobj/obj.c +++ b/src/libpmemobj/obj.c @@ -296,7 +296,6 @@ obj_init(void) COMPILE_ERROR_ON(PMEMOBJ_F_MEM_NOFLUSH != PMEM_F_MEM_NOFLUSH); - #ifdef _WIN32 /* XXX - temporary implementation (see above) */ os_once(&Cached_pool_key_once, _Cached_pool_key_alloc); diff --git a/src/libpmemobj/pmalloc.c b/src/libpmemobj/pmalloc.c index 954669c89..fef56ead4 100644 --- a/src/libpmemobj/pmalloc.c +++ b/src/libpmemobj/pmalloc.c @@ -711,7 +711,6 @@ static const struct ctl_node CTL_NODE(size)[] = { CTL_NODE_END }; - /* * CTL_READ_HANDLER(size) -- reads usable size of specified arena */ diff --git a/src/libpmemobj/tx.c b/src/libpmemobj/tx.c index 697d7d071..e72fb6ff0 100644 --- a/src/libpmemobj/tx.c +++ b/src/libpmemobj/tx.c @@ -260,7 +260,6 @@ constructor_tx_alloc(void *ctx, void *ptr, size_t usable_size, void *arg) return 0; } - struct tx_range_data { void *begin; void *end; @@ -460,7 +459,6 @@ tx_pre_commit(struct tx *tx) tx->ranges = NULL; } - /* * tx_abort -- (internal) abort all allocated objects */ @@ -1639,7 +1637,6 @@ pmemobj_tx_realloc(PMEMoid oid, size_t size, uint64_t type_num) return ret; } - /* * pmemobj_zrealloc -- resizes an existing object, any new space is zeroed. */ @@ -1921,7 +1918,6 @@ pmemobj_tx_xlog_append_buffer(enum pobj_log_type type, void *addr, size_t size, return err; } - /* * pmemobj_tx_log_append_buffer -- append user allocated buffer to the ulog */ diff --git a/src/libpmempool/check_write.c b/src/libpmempool/check_write.c index caaf22b2e..47d3becb4 100644 --- a/src/libpmempool/check_write.c +++ b/src/libpmempool/check_write.c @@ -209,7 +209,6 @@ error: return -1; } - struct step { int (*func)(PMEMpoolcheck *, location *loc); enum pool_type type; diff --git a/src/libpmempool/replica.c b/src/libpmempool/replica.c index bbb4ccfd3..f8f49acf9 100644 --- a/src/libpmempool/replica.c +++ b/src/libpmempool/replica.c @@ -1841,8 +1841,6 @@ check_uuids_between_replicas(struct pool_set *set, r); return -1; } - - } } return 0; diff --git a/src/libpmempool/replica.h b/src/libpmempool/replica.h index 9cc336caa..08883f2e2 100644 --- a/src/libpmempool/replica.h +++ b/src/libpmempool/replica.h @@ -1,5 +1,5 @@ /* - * Copyright 2016-2018, Intel Corporation + * Copyright 2016-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -225,7 +225,6 @@ int replica_check_part_dirs(struct pool_set *set); int replica_check_local_part_dir(struct pool_set *set, unsigned repn, unsigned partn); - int replica_open_replica_part_files(struct pool_set *set, unsigned repn); int replica_open_poolset_part_files(struct pool_set *set); diff --git a/src/libpmempool/sync.c b/src/libpmempool/sync.c index 41f299ee8..1d489004e 100644 --- a/src/libpmempool/sync.c +++ b/src/libpmempool/sync.c @@ -1,5 +1,5 @@ /* - * Copyright 2016-2018, Intel Corporation + * Copyright 2016-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -1371,7 +1371,6 @@ update_remote_headers(struct pool_set *set) return 0; } - /* * update_uuids -- (internal) set all uuids that might have changed or be unset * after recreating parts @@ -1495,7 +1494,6 @@ create_remote_replicas(struct pool_set *set, return 0; } - /* * sync_replica -- synchronize data across replicas within a poolset */ diff --git a/src/libpmempool/transform.c b/src/libpmempool/transform.c index cf79b6fca..a6c2c9095 100644 --- a/src/libpmempool/transform.c +++ b/src/libpmempool/transform.c @@ -377,7 +377,6 @@ check_compare_poolsets_options(struct pool_set *set_in, return 0; } - /* * compare_poolsets -- (internal) compare two poolsets; for each replica which * has a counterpart in the other poolset store the other diff --git a/src/librpmem/rpmem_fip.c b/src/librpmem/rpmem_fip.c index 697dd6fd7..40c816a9a 100644 --- a/src/librpmem/rpmem_fip.c +++ b/src/librpmem/rpmem_fip.c @@ -318,7 +318,6 @@ rpmem_fip_lane_fini(struct rpmem_fip_lane *lanep) if (ret) lret = ret; - return lret; } @@ -872,7 +871,6 @@ rpmem_fip_fini_lanes_common(struct rpmem_fip *fip) free(fip->pres); } - /* * rpmem_fip_init_lanes_apm -- (internal) initialize lanes for APM */ diff --git a/src/librpmem/rpmem_obc.c b/src/librpmem/rpmem_obc.c index ee5ffa4e9..b8ad361a4 100644 --- a/src/librpmem/rpmem_obc.c +++ b/src/librpmem/rpmem_obc.c @@ -1,5 +1,5 @@ /* - * Copyright 2016-2018, Intel Corporation + * Copyright 2016-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -580,7 +580,6 @@ rpmem_obc_open(struct rpmem_obc *rpc, rpmem_ntoh_msg_open_resp(&resp); - if (rpmem_obc_check_open_resp(&resp)) goto err_msg_resp; diff --git a/src/librpmem/rpmem_ssh.c b/src/librpmem/rpmem_ssh.c index 353f49912..27e726bd0 100644 --- a/src/librpmem/rpmem_ssh.c +++ b/src/librpmem/rpmem_ssh.c @@ -242,7 +242,6 @@ rpmem_ssh_execv(const struct rpmem_target_info *info, const char **argv) if (ret) goto err_run; - free(user_at_node); free(cmd); diff --git a/src/test/README b/src/test/README index 308c20a01..556582a94 100644 --- a/src/test/README +++ b/src/test/README @@ -13,7 +13,6 @@ testconfig.sh.example provides more detail. The script RUNTESTS, when run with no arguments, will run all unit tests through all the combinations of fs-types and build-types, running the "check" level test. - DETAILS ON HOW TO RUN UNIT TESTS See the top-level README for instructions on building, installing, running @@ -131,7 +130,6 @@ unit test framework also looks for several other variables: Display test run times: $ TM=1 ./TEST0 - DETAILS ON HOW TO WRITE UNIT TESTS A minimal unit test consists of a sub-directory here with an executable called diff --git a/src/test/RUNTESTLIB.PS1 b/src/test/RUNTESTLIB.PS1 index 72687990d..2410cfc66 100644 --- a/src/test/RUNTESTLIB.PS1 +++ b/src/test/RUNTESTLIB.PS1 @@ -1,5 +1,5 @@ # -# Copyright 2015-2018, Intel Corporation +# Copyright 2015-2019, Intel Corporation # Copyright (c) 2016, Microsoft Corporation. All rights reserved. # # Redistribution and use in source and binary forms, with or without @@ -387,7 +387,6 @@ Start-Job -Name $name -Args $PSScriptRoot -ScriptBlock { $Env:Path = "..\x64\Debug\libs;" + $Env:Path } - if (isDir($Env:PMEM_FS_DIR)) { if ($Env:PMEM_FS_DIR_FORCE_PMEM -eq "1") { # "0" means there is PMEM diff --git a/src/test/RUNTESTS.PS1 b/src/test/RUNTESTS.PS1 index 5ab69badd..f2cad103f 100644 --- a/src/test/RUNTESTS.PS1 +++ b/src/test/RUNTESTS.PS1 @@ -1,5 +1,5 @@ # -# Copyright 2015-2018, Intel Corporation +# Copyright 2015-2019, Intel Corporation # Copyright (c) 2016, Microsoft Corporation. All rights reserved. # # Redistribution and use in source and binary forms, with or without @@ -97,7 +97,6 @@ if ($PSVersionTable.PSVersion.Major -lt 5) { . .\RUNTESTLIB.PS1 - if($help) { usage $MyInvocation.MyCommand.Name } @@ -110,7 +109,6 @@ Write-Verbose " check-pool: $(if ($check_pool -eq "1") {"yes"} else {"no"})" $config = New-Object Config - $config.setBuildtype($buildtype) $config.setFstype($fstype) $config.setTimeout($time) diff --git a/src/test/blk_nblock/TEST0w.PS1 b/src/test/blk_nblock/TEST0w.PS1 index 7752f9224..6df4ee5d1 100644 --- a/src/test/blk_nblock/TEST0w.PS1 +++ b/src/test/blk_nblock/TEST0w.PS1 @@ -33,7 +33,6 @@ # src/test/blk_nblock/TEST0 -- unit test for pmemblk_nblock # - . ..\unittest\unittest.ps1 require_test_type medium diff --git a/src/test/blk_pool/README b/src/test/blk_pool/README index 0cf31e0be..6a7375077 100644 --- a/src/test/blk_pool/README +++ b/src/test/blk_pool/README @@ -73,7 +73,6 @@ TEST30 (fail) existing file, file length >= min required size, bsize == 300 bsize matches the value from pool header pool set with replica section - - each case outputs: - error, if error happened - resulting file size, nblocks, mode, consistency check results diff --git a/src/test/blk_pool_win/blk_pool_win.c b/src/test/blk_pool_win/blk_pool_win.c index b61cb5b8d..42fe0d794 100644 --- a/src/test/blk_pool_win/blk_pool_win.c +++ b/src/test/blk_pool_win/blk_pool_win.c @@ -1,5 +1,5 @@ /* - * Copyright 2015-2017, Intel Corporation + * Copyright 2015-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -63,7 +63,6 @@ pool_create(const wchar_t *path, size_t bsize, size_t poolsize, unsigned mode) pmemblk_nblock(pbp), stbuf.st_mode & 0777); - pmemblk_close(pbp); int result = pmemblk_checkW(path, bsize); diff --git a/src/test/blk_rw/TEST7 b/src/test/blk_rw/TEST7 index 27874c6ea..38218ece0 100755 --- a/src/test/blk_rw/TEST7 +++ b/src/test/blk_rw/TEST7 @@ -46,7 +46,6 @@ setup # mix writes with set_zero and set_error and check results truncate -s 128M $DIR/testfile1 - expect_normal_exit ./blk_rw$EXESUFFIX 512 $DIR/testfile1 c\ e:1 r:1\ e:2 w:2 r:2\ diff --git a/src/test/common_badblock.sh b/src/test/common_badblock.sh index 894d2da65..e4165a460 100644 --- a/src/test/common_badblock.sh +++ b/src/test/common_badblock.sh @@ -55,7 +55,6 @@ COMMAND_NDCTL_NFIT_TEST_FINI="\ sudo ndctl disable-region all &>>$PREP_LOG_FILE && \ sudo modprobe -r nfit_test &>>$PREP_LOG_FILE" - # # badblock_test_init -- initialize badblock test based on underlying hardware # @@ -220,7 +219,6 @@ function prepare_mount_dir_node() { fi } - # # real_pmem_get_dax_device -- get real pmem dax device name # @@ -483,7 +481,6 @@ function ndctl_nfit_test_grant_access() { sudo chmod o+r /sys/bus/nd/devices/ndbus*/$REGION/resource" } - # # ndctl_nfit_test_grant_access_node -- grant accesses required by libndctl on a node # diff --git a/src/test/compat_incompat_features/TEST0 b/src/test/compat_incompat_features/TEST0 index 7f7e7444b..19fa6356b 100755 --- a/src/test/compat_incompat_features/TEST0 +++ b/src/test/compat_incompat_features/TEST0 @@ -1,6 +1,6 @@ #!/usr/bin/env bash # -# Copyright 2017-2018, Intel Corporation +# Copyright 2017-2019, Intel Corporation # # Redistribution and use in source and binary forms, with or without # modification, are permitted provided that the following conditions @@ -50,7 +50,6 @@ create_poolset $POOLSET \ 20M:$DIR/part0:x \ 20M:$DIR/part1:x - for type in ${POOL_TYPES[@]}; do expect_normal_exit $PMEMPOOL$EXESUFFIX rm -f $POOLSET >> $LOG_TEMP expect_normal_exit $PMEMPOOL$EXESUFFIX create ${create_args[$type]} \ diff --git a/src/test/ctl_prefault/TEST0 b/src/test/ctl_prefault/TEST0 index 414c446fd..257c846c3 100755 --- a/src/test/ctl_prefault/TEST0 +++ b/src/test/ctl_prefault/TEST0 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type short diff --git a/src/test/ctl_prefault/TEST1 b/src/test/ctl_prefault/TEST1 index b19c370ca..5c187ce38 100755 --- a/src/test/ctl_prefault/TEST1 +++ b/src/test/ctl_prefault/TEST1 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type short diff --git a/src/test/ctl_prefault/TEST2 b/src/test/ctl_prefault/TEST2 index ffab53d1c..8ec19602d 100755 --- a/src/test/ctl_prefault/TEST2 +++ b/src/test/ctl_prefault/TEST2 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type short diff --git a/src/test/ex_libpmem/TEST0.PS1 b/src/test/ex_libpmem/TEST0.PS1 index 073de5a63..020b43829 100644 --- a/src/test/ex_libpmem/TEST0.PS1 +++ b/src/test/ex_libpmem/TEST0.PS1 @@ -34,7 +34,6 @@ # src/test/ex_libpmem/TEST0 -- unit test for libpmem examples # - . ..\unittest\unittest.ps1 require_test_type medium diff --git a/src/test/ex_libpmem/TEST1.PS1 b/src/test/ex_libpmem/TEST1.PS1 index 99ffa1a40..e4a328498 100644 --- a/src/test/ex_libpmem/TEST1.PS1 +++ b/src/test/ex_libpmem/TEST1.PS1 @@ -34,7 +34,6 @@ # src/test/ex_libpmem/TEST1 -- unit test for libpmem examples # - . ..\unittest\unittest.ps1 require_test_type medium diff --git a/src/test/ex_libpmemobj/Makefile b/src/test/ex_libpmemobj/Makefile index 21e224210..9cd4634fd 100644 --- a/src/test/ex_libpmemobj/Makefile +++ b/src/test/ex_libpmemobj/Makefile @@ -1,5 +1,5 @@ # -# Copyright 2015-2016, Intel Corporation +# Copyright 2015-2019, Intel Corporation # # Redistribution and use in source and binary forms, with or without # modification, are permitted provided that the following conditions @@ -63,5 +63,3 @@ else $(info NOTE: Skipping pminvaders test because ncurses is missing \ -- see src/examples/libpmemobj/pminvaders/README for details.) endif - - diff --git a/src/test/ex_linkedlist/TEST0 b/src/test/ex_linkedlist/TEST0 index 5f47a7d58..883bb945b 100755 --- a/src/test/ex_linkedlist/TEST0 +++ b/src/test/ex_linkedlist/TEST0 @@ -35,7 +35,6 @@ # src/test/ex_linkedlist/TEST0 -- unit test for linkedlist example # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/ex_linkedlist/TEST1 b/src/test/ex_linkedlist/TEST1 index 7f6715d45..a4e710a1b 100755 --- a/src/test/ex_linkedlist/TEST1 +++ b/src/test/ex_linkedlist/TEST1 @@ -40,7 +40,6 @@ # in multiply stores to the same field. This is not en error considering # the transactional nature of the test. - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/libpmempool_rm/TEST5 b/src/test/libpmempool_rm/TEST5 index c8e19138c..9f877f826 100755 --- a/src/test/libpmempool_rm/TEST5 +++ b/src/test/libpmempool_rm/TEST5 @@ -1,6 +1,6 @@ #!/usr/bin/env bash # -# Copyright 2016-2018, Intel Corporation +# Copyright 2016-2019, Intel Corporation # # Redistribution and use in source and binary forms, with or without # modification, are permitted provided that the following conditions @@ -54,7 +54,6 @@ chmod -r $DIR/pool.set1 expect_normal_exit ./libpmempool_rm$EXESUFFIX $DIR/pool.set1 - check pass diff --git a/src/test/libpmempool_rm/libpmempool_rm.c b/src/test/libpmempool_rm/libpmempool_rm.c index e93610541..0cda1e541 100644 --- a/src/test/libpmempool_rm/libpmempool_rm.c +++ b/src/test/libpmempool_rm/libpmempool_rm.c @@ -1,5 +1,5 @@ /* - * Copyright 2017-2019, Intel Corporation + * Copyright 2016-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -77,7 +77,6 @@ main(int argc, char *argv[]) } } - for (int i = optind; i < argc; i++) { const char *path = argv[i]; if (do_open) { diff --git a/src/test/libpmempool_rm_win/libpmempool_rm_win.c b/src/test/libpmempool_rm_win/libpmempool_rm_win.c index 2aa5d5a92..ac543dc9e 100644 --- a/src/test/libpmempool_rm_win/libpmempool_rm_win.c +++ b/src/test/libpmempool_rm_win/libpmempool_rm_win.c @@ -1,5 +1,5 @@ /* - * Copyright 2017-2018, Intel Corporation + * Copyright 2017-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -72,7 +72,6 @@ wmain(int argc, wchar_t *argv[]) break; } - for (; i < argc; i++) { const wchar_t *path = argv[i]; if (do_open) { diff --git a/src/test/libpmempool_sync/libpmempool_sync.c b/src/test/libpmempool_sync/libpmempool_sync.c index 49aac45f7..eb67ee973 100644 --- a/src/test/libpmempool_sync/libpmempool_sync.c +++ b/src/test/libpmempool_sync/libpmempool_sync.c @@ -1,5 +1,5 @@ /* - * Copyright 2016-2018, Intel Corporation + * Copyright 2016-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -54,6 +54,5 @@ main(int argc, char *argv[]) else UT_OUT("result: %d", ret); - DONE(NULL); } diff --git a/src/test/log_basic/README b/src/test/log_basic/README index 3ed301715..9a74d8e59 100644 --- a/src/test/log_basic/README +++ b/src/test/log_basic/README @@ -14,7 +14,6 @@ This directory contains a unit test for: - pmemlog_check - fault injection - The program in pmemlog.c takes a file name and a list of operations encoded as characters as arguments. For example: @@ -33,7 +32,3 @@ as described in the table below: r - pmemlog_rewind w - pmemlog_walk n - pmemlog_nbyte - - - - diff --git a/src/test/log_pool_win/log_pool_win.c b/src/test/log_pool_win/log_pool_win.c index b58865bc0..0f298cdcd 100644 --- a/src/test/log_pool_win/log_pool_win.c +++ b/src/test/log_pool_win/log_pool_win.c @@ -1,5 +1,5 @@ /* - * Copyright 2015-2017, Intel Corporation + * Copyright 2015-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -89,7 +89,6 @@ pool_open(const wchar_t *path) free(upath); } - int wmain(int argc, wchar_t *argv[]) { diff --git a/src/test/obj_action/obj_action.c b/src/test/obj_action/obj_action.c index 46f03dbed..e724b0842 100644 --- a/src/test/obj_action/obj_action.c +++ b/src/test/obj_action/obj_action.c @@ -1,5 +1,5 @@ /* - * Copyright 2017-2018, Intel Corporation + * Copyright 2017-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -263,7 +263,6 @@ test_many_sets(PMEMobjpool *pop, size_t n) FREE(act); } - int main(int argc, char *argv[]) { diff --git a/src/test/obj_basic_integration/TEST0 b/src/test/obj_basic_integration/TEST0 index 0bb9215ed..e7459f2c3 100755 --- a/src/test/obj_basic_integration/TEST0 +++ b/src/test/obj_basic_integration/TEST0 @@ -32,7 +32,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/obj_basic_integration/TEST1 b/src/test/obj_basic_integration/TEST1 index 82edf985f..316e27d8e 100755 --- a/src/test/obj_basic_integration/TEST1 +++ b/src/test/obj_basic_integration/TEST1 @@ -32,7 +32,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/obj_basic_integration/TEST10 b/src/test/obj_basic_integration/TEST10 index ad1a23ca5..aad54e8c2 100755 --- a/src/test/obj_basic_integration/TEST10 +++ b/src/test/obj_basic_integration/TEST10 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/obj_basic_integration/TEST2 b/src/test/obj_basic_integration/TEST2 index b85baea9b..672b31629 100755 --- a/src/test/obj_basic_integration/TEST2 +++ b/src/test/obj_basic_integration/TEST2 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/obj_basic_integration/TEST3 b/src/test/obj_basic_integration/TEST3 index 3fbc66ca6..7ade7e889 100755 --- a/src/test/obj_basic_integration/TEST3 +++ b/src/test/obj_basic_integration/TEST3 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/obj_basic_integration/TEST4 b/src/test/obj_basic_integration/TEST4 index 244f55e91..fd5a25451 100755 --- a/src/test/obj_basic_integration/TEST4 +++ b/src/test/obj_basic_integration/TEST4 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/obj_basic_integration/TEST5 b/src/test/obj_basic_integration/TEST5 index e20e08803..9e79a9fc7 100755 --- a/src/test/obj_basic_integration/TEST5 +++ b/src/test/obj_basic_integration/TEST5 @@ -32,7 +32,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/obj_basic_integration/TEST6 b/src/test/obj_basic_integration/TEST6 index 15b4a5a00..29af0d877 100755 --- a/src/test/obj_basic_integration/TEST6 +++ b/src/test/obj_basic_integration/TEST6 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/obj_basic_integration/TEST7 b/src/test/obj_basic_integration/TEST7 index 44986b2d6..cd1842338 100755 --- a/src/test/obj_basic_integration/TEST7 +++ b/src/test/obj_basic_integration/TEST7 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/obj_basic_integration/TEST8 b/src/test/obj_basic_integration/TEST8 index 2bc082bc9..bf44dc059 100755 --- a/src/test/obj_basic_integration/TEST8 +++ b/src/test/obj_basic_integration/TEST8 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/obj_basic_integration/TEST9 b/src/test/obj_basic_integration/TEST9 index 8fecaa841..a3ff65976 100755 --- a/src/test/obj_basic_integration/TEST9 +++ b/src/test/obj_basic_integration/TEST9 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/obj_bucket/obj_bucket.c b/src/test/obj_bucket/obj_bucket.c index 7cd19157d..c48a93043 100644 --- a/src/test/obj_bucket/obj_bucket.c +++ b/src/test/obj_bucket/obj_bucket.c @@ -203,7 +203,6 @@ main(int argc, char *argv[]) DONE(NULL); } - #ifdef _MSC_VER /* * Since libpmemobj is linked statically, we need to invoke its ctor/dtor. diff --git a/src/test/obj_check/TEST0 b/src/test/obj_check/TEST0 index a97285ab6..68a59cbe2 100755 --- a/src/test/obj_check/TEST0 +++ b/src/test/obj_check/TEST0 @@ -39,7 +39,6 @@ require_test_type medium - setup expect_normal_exit $PMEMPOOL$EXESUFFIX create obj $DIR/testfile diff --git a/src/test/obj_check/TEST1 b/src/test/obj_check/TEST1 index e7e54e577..8c702c4da 100755 --- a/src/test/obj_check/TEST1 +++ b/src/test/obj_check/TEST1 @@ -39,7 +39,6 @@ require_test_type medium - setup expect_normal_exit $PMEMPOOL$EXESUFFIX create obj $DIR/testfile diff --git a/src/test/obj_check/TEST2 b/src/test/obj_check/TEST2 index 64560e6c5..de41f1242 100755 --- a/src/test/obj_check/TEST2 +++ b/src/test/obj_check/TEST2 @@ -39,7 +39,6 @@ require_test_type medium - setup expect_normal_exit $PMEMPOOL$EXESUFFIX create obj $DIR/testfile diff --git a/src/test/obj_constructor/TEST0 b/src/test/obj_constructor/TEST0 index 117fac026..3fb38452c 100755 --- a/src/test/obj_constructor/TEST0 +++ b/src/test/obj_constructor/TEST0 @@ -36,7 +36,6 @@ # obj_constructor/TEST0 -- test for obj_constructor # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/obj_constructor/TEST0.PS1 b/src/test/obj_constructor/TEST0.PS1 index 0f09538d2..162e92022 100644 --- a/src/test/obj_constructor/TEST0.PS1 +++ b/src/test/obj_constructor/TEST0.PS1 @@ -35,7 +35,6 @@ # obj_constructor/TEST0 -- test for obj_constructor # - . ..\unittest\unittest.ps1 require_test_type medium diff --git a/src/test/obj_constructor/TEST1 b/src/test/obj_constructor/TEST1 index 5ab007075..79749d0b0 100755 --- a/src/test/obj_constructor/TEST1 +++ b/src/test/obj_constructor/TEST1 @@ -36,7 +36,6 @@ # obj_constructor/TEST1 -- test for obj_constructor # - . ../unittest/unittest.sh require_test_type long diff --git a/src/test/obj_constructor/TEST2 b/src/test/obj_constructor/TEST2 index f091d802f..d5cc75d2e 100755 --- a/src/test/obj_constructor/TEST2 +++ b/src/test/obj_constructor/TEST2 @@ -36,7 +36,6 @@ # obj_constructor/TEST2 -- test for obj_constructor # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/obj_ctl_alloc_class/TEST0 b/src/test/obj_ctl_alloc_class/TEST0 index b7b4d8b92..a6f3970bc 100755 --- a/src/test/obj_ctl_alloc_class/TEST0 +++ b/src/test/obj_ctl_alloc_class/TEST0 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type short diff --git a/src/test/obj_ctl_alloc_class/TEST0.PS1 b/src/test/obj_ctl_alloc_class/TEST0.PS1 index 550f617a5..b311b43cc 100644 --- a/src/test/obj_ctl_alloc_class/TEST0.PS1 +++ b/src/test/obj_ctl_alloc_class/TEST0.PS1 @@ -30,7 +30,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ..\unittest\unittest.ps1 require_test_type short diff --git a/src/test/obj_ctl_alloc_class_config/TEST0 b/src/test/obj_ctl_alloc_class_config/TEST0 index 1a8f03832..a44dfd38b 100755 --- a/src/test/obj_ctl_alloc_class_config/TEST0 +++ b/src/test/obj_ctl_alloc_class_config/TEST0 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type short diff --git a/src/test/obj_ctl_alloc_class_config/TEST0.PS1 b/src/test/obj_ctl_alloc_class_config/TEST0.PS1 index 3c56211ce..3792ce981 100644 --- a/src/test/obj_ctl_alloc_class_config/TEST0.PS1 +++ b/src/test/obj_ctl_alloc_class_config/TEST0.PS1 @@ -30,7 +30,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ..\unittest\unittest.ps1 require_test_type short diff --git a/src/test/obj_ctl_config/TEST0 b/src/test/obj_ctl_config/TEST0 index 7450c739d..53c2e70b4 100755 --- a/src/test/obj_ctl_config/TEST0 +++ b/src/test/obj_ctl_config/TEST0 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type short diff --git a/src/test/obj_ctl_config/TEST0.PS1 b/src/test/obj_ctl_config/TEST0.PS1 index bd407d5e0..5e5c69b10 100644 --- a/src/test/obj_ctl_config/TEST0.PS1 +++ b/src/test/obj_ctl_config/TEST0.PS1 @@ -34,7 +34,6 @@ # src/test/obj_ctl_config/TEST0 -- unit test for ctl configuration # - . ..\unittest\unittest.ps1 require_test_type short diff --git a/src/test/obj_ctl_config/TEST1.PS1 b/src/test/obj_ctl_config/TEST1.PS1 index 339590897..fe3fe4bc4 100644 --- a/src/test/obj_ctl_config/TEST1.PS1 +++ b/src/test/obj_ctl_config/TEST1.PS1 @@ -36,7 +36,6 @@ $Env:UNITTEST_NAME = "obj_ctl_config/TEST1" $Env:UNITTEST_NUM = "100" # TEST0 poses as different test numbers - . ..\unittest\unittest.ps1 require_test_type short diff --git a/src/test/obj_ctl_heap_size/TEST0 b/src/test/obj_ctl_heap_size/TEST0 index 2f5cbb18a..8356b6cc5 100755 --- a/src/test/obj_ctl_heap_size/TEST0 +++ b/src/test/obj_ctl_heap_size/TEST0 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type short diff --git a/src/test/obj_ctl_heap_size/TEST1 b/src/test/obj_ctl_heap_size/TEST1 index 6457fd3d1..6c2e3bf0f 100755 --- a/src/test/obj_ctl_heap_size/TEST1 +++ b/src/test/obj_ctl_heap_size/TEST1 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type short diff --git a/src/test/obj_ctl_stats/TEST0 b/src/test/obj_ctl_stats/TEST0 index 972090b07..54089e729 100755 --- a/src/test/obj_ctl_stats/TEST0 +++ b/src/test/obj_ctl_stats/TEST0 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type short diff --git a/src/test/obj_ctl_stats/TEST1 b/src/test/obj_ctl_stats/TEST1 index 6e1422412..03e4c0fbe 100755 --- a/src/test/obj_ctl_stats/TEST1 +++ b/src/test/obj_ctl_stats/TEST1 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type short diff --git a/src/test/obj_first_next/TEST0.PS1 b/src/test/obj_first_next/TEST0.PS1 index ea519525d..c2ce31036 100644 --- a/src/test/obj_first_next/TEST0.PS1 +++ b/src/test/obj_first_next/TEST0.PS1 @@ -34,7 +34,6 @@ # src/test/obj_first_next/TEST0 -- unit test for POBJ_NEXT macro # - . ..\unittest\unittest.ps1 require_test_type medium diff --git a/src/test/obj_first_next/TEST1.PS1 b/src/test/obj_first_next/TEST1.PS1 index 8745204c2..e43f3504b 100644 --- a/src/test/obj_first_next/TEST1.PS1 +++ b/src/test/obj_first_next/TEST1.PS1 @@ -36,7 +36,6 @@ # Returns first object on the proper list # - . ..\unittest\unittest.ps1 require_test_type medium diff --git a/src/test/obj_fragmentation/TEST0 b/src/test/obj_fragmentation/TEST0 index a4f26c8da..fe5a7ee14 100755 --- a/src/test/obj_fragmentation/TEST0 +++ b/src/test/obj_fragmentation/TEST0 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/obj_fragmentation/TEST1 b/src/test/obj_fragmentation/TEST1 index e25d66f84..f6a38ab4b 100755 --- a/src/test/obj_fragmentation/TEST1 +++ b/src/test/obj_fragmentation/TEST1 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/obj_fragmentation/TEST2 b/src/test/obj_fragmentation/TEST2 index dd20061d4..62fbef0b6 100755 --- a/src/test/obj_fragmentation/TEST2 +++ b/src/test/obj_fragmentation/TEST2 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/obj_fragmentation2/TEST0 b/src/test/obj_fragmentation2/TEST0 index ebab1c13f..6dad7ccfe 100755 --- a/src/test/obj_fragmentation2/TEST0 +++ b/src/test/obj_fragmentation2/TEST0 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type long diff --git a/src/test/obj_fragmentation2/TEST1 b/src/test/obj_fragmentation2/TEST1 index fe7a75044..67c040c49 100755 --- a/src/test/obj_fragmentation2/TEST1 +++ b/src/test/obj_fragmentation2/TEST1 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type long diff --git a/src/test/obj_fragmentation2/TEST2 b/src/test/obj_fragmentation2/TEST2 index 410b7e3a0..23acd7da7 100755 --- a/src/test/obj_fragmentation2/TEST2 +++ b/src/test/obj_fragmentation2/TEST2 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type long diff --git a/src/test/obj_fragmentation2/TEST3 b/src/test/obj_fragmentation2/TEST3 index 8cc34bf75..910b751e9 100755 --- a/src/test/obj_fragmentation2/TEST3 +++ b/src/test/obj_fragmentation2/TEST3 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type long diff --git a/src/test/obj_fragmentation2/TEST4 b/src/test/obj_fragmentation2/TEST4 index 5a931b944..4d18eec5d 100755 --- a/src/test/obj_fragmentation2/TEST4 +++ b/src/test/obj_fragmentation2/TEST4 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type long diff --git a/src/test/obj_fragmentation2/TEST5 b/src/test/obj_fragmentation2/TEST5 index 3708456fe..97416d112 100755 --- a/src/test/obj_fragmentation2/TEST5 +++ b/src/test/obj_fragmentation2/TEST5 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type long diff --git a/src/test/obj_fragmentation2/TEST6 b/src/test/obj_fragmentation2/TEST6 index 51ef4417e..41ffeb20d 100755 --- a/src/test/obj_fragmentation2/TEST6 +++ b/src/test/obj_fragmentation2/TEST6 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type long diff --git a/src/test/obj_fragmentation2/TEST7 b/src/test/obj_fragmentation2/TEST7 index 3c54bb19e..c361e8d5d 100755 --- a/src/test/obj_fragmentation2/TEST7 +++ b/src/test/obj_fragmentation2/TEST7 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type long diff --git a/src/test/obj_fragmentation2/TEST8 b/src/test/obj_fragmentation2/TEST8 index 43055f8db..e732d8af0 100755 --- a/src/test/obj_fragmentation2/TEST8 +++ b/src/test/obj_fragmentation2/TEST8 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type long diff --git a/src/test/obj_heap/TEST0.PS1 b/src/test/obj_heap/TEST0.PS1 index 878f1aa4b..0a4bb684a 100644 --- a/src/test/obj_heap/TEST0.PS1 +++ b/src/test/obj_heap/TEST0.PS1 @@ -34,7 +34,6 @@ # src/test/obj_heap/TEST0 -- unit test for obj_heap interface # - . ..\unittest\unittest.ps1 require_test_type medium diff --git a/src/test/obj_heap_interrupt/obj_heap_interrupt.c b/src/test/obj_heap_interrupt/obj_heap_interrupt.c index 0fe861b71..4641d3321 100644 --- a/src/test/obj_heap_interrupt/obj_heap_interrupt.c +++ b/src/test/obj_heap_interrupt/obj_heap_interrupt.c @@ -40,7 +40,6 @@ POBJ_LAYOUT_BEGIN(heap_interrupt); POBJ_LAYOUT_END(heap_interrupt); - static int exit_on_finish = 0; FUNC_MOCK(operation_finish, void, struct operation_context *ctx, unsigned flags) @@ -126,7 +125,6 @@ main(int argc, char *argv[]) DONE(NULL); } - #ifdef _MSC_VER /* * Since libpmemobj is linked statically, we need to invoke its ctor/dtor. diff --git a/src/test/obj_heap_state/TEST0 b/src/test/obj_heap_state/TEST0 index 19bc0eecc..ac7a22d17 100755 --- a/src/test/obj_heap_state/TEST0 +++ b/src/test/obj_heap_state/TEST0 @@ -32,7 +32,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/obj_heap_state/TEST0.PS1 b/src/test/obj_heap_state/TEST0.PS1 index 4e284c12d..5cc8b4ce1 100644 --- a/src/test/obj_heap_state/TEST0.PS1 +++ b/src/test/obj_heap_state/TEST0.PS1 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ..\unittest\unittest.ps1 require_test_type medium diff --git a/src/test/obj_heap_state/TEST1 b/src/test/obj_heap_state/TEST1 index d34930422..b157df0d2 100755 --- a/src/test/obj_heap_state/TEST1 +++ b/src/test/obj_heap_state/TEST1 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/obj_heap_state/TEST1.PS1 b/src/test/obj_heap_state/TEST1.PS1 index c426aac0b..53d4ddb48 100644 --- a/src/test/obj_heap_state/TEST1.PS1 +++ b/src/test/obj_heap_state/TEST1.PS1 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ..\unittest\unittest.ps1 require_test_type medium diff --git a/src/test/obj_heap_state/TEST2 b/src/test/obj_heap_state/TEST2 index 29d84c4d3..355975305 100755 --- a/src/test/obj_heap_state/TEST2 +++ b/src/test/obj_heap_state/TEST2 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/obj_heap_state/TEST2.PS1 b/src/test/obj_heap_state/TEST2.PS1 index 4df5158a8..761505904 100644 --- a/src/test/obj_heap_state/TEST2.PS1 +++ b/src/test/obj_heap_state/TEST2.PS1 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ..\unittest\unittest.ps1 require_test_type medium diff --git a/src/test/obj_lane/TEST0.PS1 b/src/test/obj_lane/TEST0.PS1 index e69faea52..f1ba142b9 100644 --- a/src/test/obj_lane/TEST0.PS1 +++ b/src/test/obj_lane/TEST0.PS1 @@ -34,7 +34,6 @@ # src/test/obj_lane/TEST0 -- single thread unit test for lanes # - . ..\unittest\unittest.ps1 require_test_type medium diff --git a/src/test/obj_lane/TEST1.PS1 b/src/test/obj_lane/TEST1.PS1 index b9bd85c25..4fd0f2941 100644 --- a/src/test/obj_lane/TEST1.PS1 +++ b/src/test/obj_lane/TEST1.PS1 @@ -34,7 +34,6 @@ # src/test/obj_lane/TEST1 -- multithreaded unit test for lanes # - . ..\unittest\unittest.ps1 require_test_type medium diff --git a/src/test/obj_layout/obj_layout.c b/src/test/obj_layout/obj_layout.c index d5589f41b..315ddac9b 100644 --- a/src/test/obj_layout/obj_layout.c +++ b/src/test/obj_layout/obj_layout.c @@ -232,7 +232,6 @@ main(int argc, char *argv[]) UT_COMPILE_ERROR_ON(sizeof(struct lane_layout) != SIZEOF_LANE_V3); - DONE(NULL); } diff --git a/src/test/obj_list/obj_list_mocks.c b/src/test/obj_list/obj_list_mocks.c index 1e224961e..0f0fa9b2a 100644 --- a/src/test/obj_list/obj_list_mocks.c +++ b/src/test/obj_list/obj_list_mocks.c @@ -1,5 +1,5 @@ /* - * Copyright 2015-2018, Intel Corporation + * Copyright 2015-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -106,7 +106,6 @@ obj_drain(void *ctx) pop->drain_local(); } - static void * obj_memcpy(void *ctx, void *dest, const void *src, size_t len, unsigned flags) diff --git a/src/test/obj_list_macro/TEST0 b/src/test/obj_list_macro/TEST0 index 5e87dff48..4d74d4d9f 100755 --- a/src/test/obj_list_macro/TEST0 +++ b/src/test/obj_list_macro/TEST0 @@ -35,7 +35,6 @@ # src/test/obj_list_macro/TEST0 -- unit test for list API # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/obj_list_macro/TEST1 b/src/test/obj_list_macro/TEST1 index 597cd6505..b38d69845 100755 --- a/src/test/obj_list_macro/TEST1 +++ b/src/test/obj_list_macro/TEST1 @@ -35,7 +35,6 @@ # src/test/obj_list_macro/TEST1 -- unit test for list API # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/obj_list_macro/obj_list_macro.c b/src/test/obj_list_macro/obj_list_macro.c index d45ee88ab..b01544e5a 100644 --- a/src/test/obj_list_macro/obj_list_macro.c +++ b/src/test/obj_list_macro/obj_list_macro.c @@ -1,5 +1,5 @@ /* - * Copyright 2015-2017, Intel Corporation + * Copyright 2015-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -39,7 +39,6 @@ #include "libpmemobj.h" #include "unittest.h" - TOID_DECLARE(struct item, 0); TOID_DECLARE(struct list, 1); diff --git a/src/test/obj_many_size_allocs/TEST0 b/src/test/obj_many_size_allocs/TEST0 index f4833fd48..1c8561bd6 100755 --- a/src/test/obj_many_size_allocs/TEST0 +++ b/src/test/obj_many_size_allocs/TEST0 @@ -32,7 +32,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh # covered by TEST3 diff --git a/src/test/obj_many_size_allocs/TEST1 b/src/test/obj_many_size_allocs/TEST1 index eccd952be..0636ccd52 100755 --- a/src/test/obj_many_size_allocs/TEST1 +++ b/src/test/obj_many_size_allocs/TEST1 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type long diff --git a/src/test/obj_many_size_allocs/TEST1.PS1 b/src/test/obj_many_size_allocs/TEST1.PS1 index c102fa130..99dc588d7 100644 --- a/src/test/obj_many_size_allocs/TEST1.PS1 +++ b/src/test/obj_many_size_allocs/TEST1.PS1 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ..\unittest\unittest.ps1 require_test_type long diff --git a/src/test/obj_many_size_allocs/TEST2 b/src/test/obj_many_size_allocs/TEST2 index 2d5aac846..b8929115c 100755 --- a/src/test/obj_many_size_allocs/TEST2 +++ b/src/test/obj_many_size_allocs/TEST2 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type long diff --git a/src/test/obj_many_size_allocs/TEST2.PS1 b/src/test/obj_many_size_allocs/TEST2.PS1 index d7e0a7b47..af44283cf 100644 --- a/src/test/obj_many_size_allocs/TEST2.PS1 +++ b/src/test/obj_many_size_allocs/TEST2.PS1 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ..\unittest\unittest.ps1 require_test_type long diff --git a/src/test/obj_many_size_allocs/TEST3 b/src/test/obj_many_size_allocs/TEST3 index 1b81ee25e..a76b7ab11 100755 --- a/src/test/obj_many_size_allocs/TEST3 +++ b/src/test/obj_many_size_allocs/TEST3 @@ -32,7 +32,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type long diff --git a/src/test/obj_memops/TEST0 b/src/test/obj_memops/TEST0 index 1fb0f3cec..858d3d39b 100755 --- a/src/test/obj_memops/TEST0 +++ b/src/test/obj_memops/TEST0 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/obj_memops/obj_memops.c b/src/test/obj_memops/obj_memops.c index 8869948b5..2b453082b 100644 --- a/src/test/obj_memops/obj_memops.c +++ b/src/test/obj_memops/obj_memops.c @@ -381,7 +381,6 @@ test_undo_large_copy(PMEMobjpool *pop, struct operation_context *ctx, for (uint64_t i = 0; i < TEST_VALUES; ++i) UT_ASSERTeq(object->values[i], i + 1); - operation_finish(ctx, ULOG_INC_FIRST_GEN_NUM); for (uint64_t i = 0; i < TEST_VALUES; ++i) diff --git a/src/test/obj_out_of_memory/TEST0 b/src/test/obj_out_of_memory/TEST0 index 8c3deb9fd..c1f6f3bed 100755 --- a/src/test/obj_out_of_memory/TEST0 +++ b/src/test/obj_out_of_memory/TEST0 @@ -32,7 +32,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/obj_out_of_memory/TEST1 b/src/test/obj_out_of_memory/TEST1 index 9ae16850b..3984f1188 100755 --- a/src/test/obj_out_of_memory/TEST1 +++ b/src/test/obj_out_of_memory/TEST1 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/obj_out_of_memory/TEST2 b/src/test/obj_out_of_memory/TEST2 index 97897e6b9..f32e62d16 100755 --- a/src/test/obj_out_of_memory/TEST2 +++ b/src/test/obj_out_of_memory/TEST2 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type long diff --git a/src/test/obj_persist_count/obj_persist_count.c b/src/test/obj_persist_count/obj_persist_count.c index 64d605381..73fae9e13 100644 --- a/src/test/obj_persist_count/obj_persist_count.c +++ b/src/test/obj_persist_count/obj_persist_count.c @@ -1,5 +1,5 @@ /* - * Copyright 2015-2018, Intel Corporation + * Copyright 2015-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -381,7 +381,6 @@ main(int argc, char *argv[]) "pmem_memset_drain", "potential_cache_misses"); - print_reset_counters("pool_create", 0); /* allocate one structure to create a run */ @@ -480,7 +479,6 @@ main(int argc, char *argv[]) DONE(NULL); } - #ifdef _MSC_VER /* * Since libpmemobj is linked statically, we need to invoke its ctor/dtor. diff --git a/src/test/obj_pmalloc_basic/TEST0.PS1 b/src/test/obj_pmalloc_basic/TEST0.PS1 index da0c6c2d2..36b70f305 100644 --- a/src/test/obj_pmalloc_basic/TEST0.PS1 +++ b/src/test/obj_pmalloc_basic/TEST0.PS1 @@ -34,7 +34,6 @@ # src/test/obj_pmalloc_basic/TEST0 -- unit test for pmalloc interface # - . ..\unittest\unittest.ps1 require_test_type medium diff --git a/src/test/obj_pmalloc_basic/obj_pmalloc_basic.c b/src/test/obj_pmalloc_basic/obj_pmalloc_basic.c index bbee2a231..4580febaf 100644 --- a/src/test/obj_pmalloc_basic/obj_pmalloc_basic.c +++ b/src/test/obj_pmalloc_basic/obj_pmalloc_basic.c @@ -389,7 +389,6 @@ main(int argc, char *argv[]) DONE(NULL); } - #ifdef _MSC_VER /* * Since libpmemobj is linked statically, we need to invoke its ctor/dtor. diff --git a/src/test/obj_pmalloc_mt/obj_pmalloc_mt.c b/src/test/obj_pmalloc_mt/obj_pmalloc_mt.c index 3bcf5fd7e..5a2c6d7ae 100644 --- a/src/test/obj_pmalloc_mt/obj_pmalloc_mt.c +++ b/src/test/obj_pmalloc_mt/obj_pmalloc_mt.c @@ -177,7 +177,6 @@ tx3_worker(void *arg) return NULL; } - static void * alloc_free_worker(void *arg) { diff --git a/src/test/obj_pmalloc_oom_mt/TEST0 b/src/test/obj_pmalloc_oom_mt/TEST0 index 06df260fd..ac5dc4195 100755 --- a/src/test/obj_pmalloc_oom_mt/TEST0 +++ b/src/test/obj_pmalloc_oom_mt/TEST0 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/obj_pmalloc_oom_mt/TEST0.PS1 b/src/test/obj_pmalloc_oom_mt/TEST0.PS1 index cf597c848..5f6f82b2f 100644 --- a/src/test/obj_pmalloc_oom_mt/TEST0.PS1 +++ b/src/test/obj_pmalloc_oom_mt/TEST0.PS1 @@ -34,7 +34,6 @@ # src/test/obj_pmalloc_oom_mt/TEST0 -- unit test for pmalloc interface # - . ..\unittest\unittest.ps1 require_test_type medium diff --git a/src/test/obj_realloc/TEST1 b/src/test/obj_realloc/TEST1 index 33425fffa..1593e0f9b 100755 --- a/src/test/obj_realloc/TEST1 +++ b/src/test/obj_realloc/TEST1 @@ -40,7 +40,6 @@ require_test_type long - # XXX reduce the number of reallocs performed under pmemcheck so that the # execution time is reasonable and within the time limit (5 minutes) on both # pmem and non-pmem fs types. diff --git a/src/test/obj_recreate/TEST0 b/src/test/obj_recreate/TEST0 index cdd6ad3b2..e068214ee 100755 --- a/src/test/obj_recreate/TEST0 +++ b/src/test/obj_recreate/TEST0 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/obj_recreate/TEST1 b/src/test/obj_recreate/TEST1 index 162f067fd..f575f4c14 100755 --- a/src/test/obj_recreate/TEST1 +++ b/src/test/obj_recreate/TEST1 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/obj_rpmem_basic_integration/TEST0 b/src/test/obj_rpmem_basic_integration/TEST0 index 7ccb56c95..320eee9d6 100755 --- a/src/test/obj_rpmem_basic_integration/TEST0 +++ b/src/test/obj_rpmem_basic_integration/TEST0 @@ -95,6 +95,4 @@ compare_replicas "-soOaAb -l -Z -H -C" \ check_local - - pass diff --git a/src/test/obj_rpmem_heap_state/TEST0 b/src/test/obj_rpmem_heap_state/TEST0 index 6ebbb2a3b..20ac22284 100755 --- a/src/test/obj_rpmem_heap_state/TEST0 +++ b/src/test/obj_rpmem_heap_state/TEST0 @@ -32,7 +32,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/obj_rpmem_heap_state/TEST1 b/src/test/obj_rpmem_heap_state/TEST1 index 54bb15e37..0dbbc87ca 100755 --- a/src/test/obj_rpmem_heap_state/TEST1 +++ b/src/test/obj_rpmem_heap_state/TEST1 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/obj_rpmem_heap_state/TEST2 b/src/test/obj_rpmem_heap_state/TEST2 index 705bf34d0..f55e9ff61 100755 --- a/src/test/obj_rpmem_heap_state/TEST2 +++ b/src/test/obj_rpmem_heap_state/TEST2 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/obj_sds/TEST5 b/src/test/obj_sds/TEST5 index 48b22c33f..49d1f7a55 100755 --- a/src/test/obj_sds/TEST5 +++ b/src/test/obj_sds/TEST5 @@ -64,5 +64,4 @@ expect_abnormal_exit ./obj_sds 1 1 $POOLSET\ expect_abnormal_exit ./obj_sds 0 0 $POOLSET\ 5 0 7 0 9 0 11 0 121 0 - pass diff --git a/src/test/obj_sds/obj_sds.c b/src/test/obj_sds/obj_sds.c index 00c4a1862..0bbda587f 100644 --- a/src/test/obj_sds/obj_sds.c +++ b/src/test/obj_sds/obj_sds.c @@ -89,7 +89,6 @@ main(int argc, char *argv[]) } } - if (!fail) pmemobj_close(pop); diff --git a/src/test/obj_tx_add_range/obj_tx_add_range.c b/src/test/obj_tx_add_range/obj_tx_add_range.c index 2ab0b0e5d..b3166c086 100644 --- a/src/test/obj_tx_add_range/obj_tx_add_range.c +++ b/src/test/obj_tx_add_range/obj_tx_add_range.c @@ -81,7 +81,6 @@ struct overlap_object { #define TEST_VALUE_1 1 #define TEST_VALUE_2 2 - /* * do_tx_zalloc -- do tx allocation with specified type number */ @@ -347,7 +346,6 @@ do_tx_add_range_abort_after_commit(PMEMobjpool *pop) for (i = 0; i < DATA_SIZE; i++) UT_ASSERTeq(D_RO(obj)->data[i], TEST_VALUE_1); - /* 2. Do the snapshot using non-zero value. */ TX_BEGIN(pop) { ret = pmemobj_tx_add_range(obj.oid, @@ -450,8 +448,6 @@ do_tx_add_range_abort(PMEMobjpool *pop) UT_ASSERTeq(D_RO(obj)->value, 0); } - - /* * do_tx_add_huge_range_abort -- call pmemobj_tx_add_range on a huge range and * commit the tx diff --git a/src/test/obj_tx_add_range_direct/obj_tx_add_range_direct.c b/src/test/obj_tx_add_range_direct/obj_tx_add_range_direct.c index e3ebd8bc5..fe6e4360c 100644 --- a/src/test/obj_tx_add_range_direct/obj_tx_add_range_direct.c +++ b/src/test/obj_tx_add_range_direct/obj_tx_add_range_direct.c @@ -616,7 +616,6 @@ do_tx_add_range_no_uninit_check_commit_no_flag(PMEMobjpool *pop) UT_ASSERTeq(D_RO(obj)->data[256], TEST_VALUE_2); } - /* * do_tx_xadd_range_no_uninit_check_abort -- call pmemobj_tx_range with * POBJ_XADD_ASSUME_INITIALIZED flag, modify the value inside aborted diff --git a/src/test/obj_tx_callbacks/obj_tx_callbacks.c b/src/test/obj_tx_callbacks/obj_tx_callbacks.c index bb565fbd9..3bc733fa7 100644 --- a/src/test/obj_tx_callbacks/obj_tx_callbacks.c +++ b/src/test/obj_tx_callbacks/obj_tx_callbacks.c @@ -1,5 +1,5 @@ /* - * Copyright 2016, Intel Corporation + * Copyright 2016-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -235,7 +235,6 @@ test(PMEMobjpool *pop, TOID(struct pmem_root) root) } TX_END UT_OUT("end of tx 6\n"); - UT_OUT("start of tx 7"); if (pmemobj_tx_begin(pop, NULL, TX_PARAM_CB, log_stages, NULL, TX_PARAM_NONE)) diff --git a/src/test/obj_tx_flow/obj_tx_flow.c b/src/test/obj_tx_flow/obj_tx_flow.c index 10c2ba186..5102dda4e 100644 --- a/src/test/obj_tx_flow/obj_tx_flow.c +++ b/src/test/obj_tx_flow/obj_tx_flow.c @@ -50,7 +50,6 @@ struct test_obj { int c; }; - static void do_tx_macro_commit(PMEMobjpool *pop, TOID(struct test_obj) *obj) { diff --git a/src/test/obj_tx_locks/obj_tx_locks.c b/src/test/obj_tx_locks/obj_tx_locks.c index c5da562b3..0d2cd98ff 100644 --- a/src/test/obj_tx_locks/obj_tx_locks.c +++ b/src/test/obj_tx_locks/obj_tx_locks.c @@ -1,5 +1,5 @@ /* - * Copyright 2015-2018, Intel Corporation + * Copyright 2015-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -276,7 +276,6 @@ main(int argc, char *argv[]) UT_ASSERT(test_obj->b == TEST_VALUE_A); UT_ASSERT(test_obj->c == TEST_VALUE_C); - /* test that deprecated macros still work */ UT_COMPILE_ERROR_ON((int)TX_LOCK_NONE != (int)TX_PARAM_NONE); UT_COMPILE_ERROR_ON((int)TX_LOCK_MUTEX != (int)TX_PARAM_MUTEX); diff --git a/src/test/obj_tx_realloc/obj_tx_realloc.c b/src/test/obj_tx_realloc/obj_tx_realloc.c index f50679fa9..d50e13fde 100644 --- a/src/test/obj_tx_realloc/obj_tx_realloc.c +++ b/src/test/obj_tx_realloc/obj_tx_realloc.c @@ -1,5 +1,5 @@ /* - * Copyright 2015-2018, Intel Corporation + * Copyright 2015-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -246,7 +246,6 @@ do_tx_zrealloc_commit(PMEMobjpool *pop) void *new_ptr = (void *)((uintptr_t)D_RW(obj) + old_size); UT_ASSERT(util_is_zeroed(new_ptr, new_size - old_size)); - TOID_ASSIGN(obj, POBJ_NEXT_TYPE_NUM(obj.oid)); UT_ASSERT(TOID_IS_NULL(obj)); } @@ -433,7 +432,6 @@ do_tx_realloc_alloc_abort(PMEMobjpool *pop) UT_ASSERT(TOID_IS_NULL(obj)); } - /* * do_tx_root_realloc -- retrieve root inside of transaction */ diff --git a/src/test/obj_zones/TEST0 b/src/test/obj_zones/TEST0 index 3e4bc569e..62a7229e1 100755 --- a/src/test/obj_zones/TEST0 +++ b/src/test/obj_zones/TEST0 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh # too large diff --git a/src/test/pmem_include/pmem_include.c b/src/test/pmem_include/pmem_include.c index 7d37e4f4d..fc64fca4f 100644 --- a/src/test/pmem_include/pmem_include.c +++ b/src/test/pmem_include/pmem_include.c @@ -1,5 +1,5 @@ /* - * Copyright 2016, Intel Corporation + * Copyright 2016-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -38,7 +38,6 @@ #include <libpmem.h> - int main(int argc, char *argv[]) { diff --git a/src/test/pmem_is_pmem_windows/pmem_is_pmem_windows.c b/src/test/pmem_is_pmem_windows/pmem_is_pmem_windows.c index 6ecc50bba..bdc5f7ada 100644 --- a/src/test/pmem_is_pmem_windows/pmem_is_pmem_windows.c +++ b/src/test/pmem_is_pmem_windows/pmem_is_pmem_windows.c @@ -237,7 +237,6 @@ main(int argc, char *argv[]) DONE(NULL); } - /* * Since libpmem is linked statically, we need to invoke its ctor/dtor. */ diff --git a/src/test/pmem_map_file/pmem_map_file.c b/src/test/pmem_map_file/pmem_map_file.c index 86ca13749..a219a4ec0 100644 --- a/src/test/pmem_map_file/pmem_map_file.c +++ b/src/test/pmem_map_file/pmem_map_file.c @@ -262,7 +262,6 @@ main(int argc, char *argv[]) DONE(NULL); } - #ifdef _MSC_VER /* * Since libpmem is linked statically, we need to invoke its ctor/dtor. diff --git a/src/test/pmem_map_file_win/pmem_map_file_win.c b/src/test/pmem_map_file_win/pmem_map_file_win.c index 4a634654d..0a2dba6e1 100644 --- a/src/test/pmem_map_file_win/pmem_map_file_win.c +++ b/src/test/pmem_map_file_win/pmem_map_file_win.c @@ -1,5 +1,5 @@ /* - * Copyright 2014-2017, Intel Corporation + * Copyright 2014-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -230,7 +230,6 @@ wmain(int argc, wchar_t *argv[]) DONEW(NULL); } - /* * Since libpmem is linked statically, we need to invoke its ctor/dtor. */ diff --git a/src/test/pmempool_help/README b/src/test/pmempool_help/README index 65ef75d61..ac0d2f262 100644 --- a/src/test/pmempool_help/README +++ b/src/test/pmempool_help/README @@ -3,5 +3,3 @@ Persistent Memory Development Kit This is src/test/pmempool_help/README. This directory contains a unit test for 'pmempool help' command. - - diff --git a/src/test/pmempool_info_remote/TEST0 b/src/test/pmempool_info_remote/TEST0 index c1713d0d3..9a33f81b6 100755 --- a/src/test/pmempool_info_remote/TEST0 +++ b/src/test/pmempool_info_remote/TEST0 @@ -1,6 +1,6 @@ #!/usr/bin/env bash # -# Copyright 2017-2018, Intel Corporation +# Copyright 2017-2019, Intel Corporation # # Redistribution and use in source and binary forms, with or without # modification, are permitted provided that the following conditions @@ -62,7 +62,6 @@ LOG=out${UNITTEST_NUM}.log create_poolset $DIR/$TEST_SET_LOCAL 16M:${NODE_DIR[1]}/$TEST_FILE_LOCAL:x \ m ${NODE_ADDR[0]}:$TEST_SET_REMOTE - create_poolset $DIR/$TEST_SET_REMOTE 17M:${NODE_DIR[0]}/$TEST_FILE_REMOTE:x copy_files_to_node 0 ${NODE_DIR[0]} $DIR/$TEST_SET_REMOTE diff --git a/src/test/pmempool_rm/TEST12.PS1 b/src/test/pmempool_rm/TEST12.PS1 index 422acc864..43e4c430b 100644 --- a/src/test/pmempool_rm/TEST12.PS1 +++ b/src/test/pmempool_rm/TEST12.PS1 @@ -34,7 +34,6 @@ # a write-protected part file by answering with invalid response # - . ..\unittest\unittest.ps1 require_test_type medium diff --git a/src/test/pmempool_sync/TEST28 b/src/test/pmempool_sync/TEST28 index 0a1d394cf..862257f54 100755 --- a/src/test/pmempool_sync/TEST28 +++ b/src/test/pmempool_sync/TEST28 @@ -39,7 +39,6 @@ # in the first 8kB of the pool (in the pool header) located in a DAX device. # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/pmemspoil/TEST0 b/src/test/pmemspoil/TEST0 index 3e0937adb..772a44d51 100755 --- a/src/test/pmemspoil/TEST0 +++ b/src/test/pmemspoil/TEST0 @@ -1,6 +1,6 @@ #!/usr/bin/env bash # -# Copyright 2014-2018, Intel Corporation +# Copyright 2014-2019, Intel Corporation # # Redistribution and use in source and binary forms, with or without # modification, are permitted provided that the following conditions @@ -72,7 +72,6 @@ expect_normal_exit $PMEMSPOIL $POOLSET --replica 1 "pmemobj.layout=replica1" expect_normal_exit $PMEMPOOL info --replica 1 $POOLSET -f obj\ | $GREP '^Layout.*' >> $LOG - check pass diff --git a/src/test/remote_basic/TEST1 b/src/test/remote_basic/TEST1 index e574dc521..1f3b87cf6 100755 --- a/src/test/remote_basic/TEST1 +++ b/src/test/remote_basic/TEST1 @@ -35,7 +35,6 @@ # src/test/remote_basic/TEST1 -- unit test for remote tests support # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/rpmem_basic/TEST2 b/src/test/rpmem_basic/TEST2 index 01bf48111..d03fb6331 100755 --- a/src/test/rpmem_basic/TEST2 +++ b/src/test/rpmem_basic/TEST2 @@ -88,5 +88,4 @@ expect_normal_exit run_on_node 1 ./rpmem_basic$EXESUFFIX\ expect_normal_exit run_on_node 0 ./rpmem_basic$EXESUFFIX\ check_pool ${NODE_DIR[0]}$POOLS_DIR/pool1.set 1234 8M - pass diff --git a/src/test/rpmem_fip/TEST0 b/src/test/rpmem_fip/TEST0 index 483ce93dc..598083caa 100755 --- a/src/test/rpmem_fip/TEST0 +++ b/src/test/rpmem_fip/TEST0 @@ -35,7 +35,6 @@ # src/test/rpmem_fip/TEST0 -- tests for rpmem_fip and rpmemd_fip modules # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/rpmem_fip/TEST1 b/src/test/rpmem_fip/TEST1 index 0f8257f5f..703badab7 100755 --- a/src/test/rpmem_fip/TEST1 +++ b/src/test/rpmem_fip/TEST1 @@ -35,7 +35,6 @@ # src/test/rpmem_fip/TEST1 -- tests for rpmem_fip and rpmemd_fip modules # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/rpmem_fip/TEST2 b/src/test/rpmem_fip/TEST2 index b42d11fe9..e3fd7fda3 100755 --- a/src/test/rpmem_fip/TEST2 +++ b/src/test/rpmem_fip/TEST2 @@ -35,7 +35,6 @@ # src/test/rpmem_fip/TEST2 -- tests for rpmem_fip and rpmemd_fip modules # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/rpmem_fip/TEST3 b/src/test/rpmem_fip/TEST3 index 59dc2f345..8ac4622f2 100755 --- a/src/test/rpmem_fip/TEST3 +++ b/src/test/rpmem_fip/TEST3 @@ -35,7 +35,6 @@ # src/test/rpmem_fip/TEST3 -- tests for rpmem_fip and rpmemd_fip modules # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/rpmem_fip/TEST4 b/src/test/rpmem_fip/TEST4 index f19b1135e..c7feef43f 100755 --- a/src/test/rpmem_fip/TEST4 +++ b/src/test/rpmem_fip/TEST4 @@ -35,7 +35,6 @@ # src/test/rpmem_fip/TEST4 -- tests for rpmem_fip and rpmemd_fip modules # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/rpmem_fip/TEST5 b/src/test/rpmem_fip/TEST5 index 825ef0398..1becbf0c4 100755 --- a/src/test/rpmem_fip/TEST5 +++ b/src/test/rpmem_fip/TEST5 @@ -35,7 +35,6 @@ # src/test/rpmem_fip/TEST5 -- test WQ size evaluation # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/rpmem_fip/TEST6 b/src/test/rpmem_fip/TEST6 index 2cc911e19..3747d726e 100755 --- a/src/test/rpmem_fip/TEST6 +++ b/src/test/rpmem_fip/TEST6 @@ -38,7 +38,6 @@ # multi-threaded in TEST7 # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/rpmem_fip/TEST7 b/src/test/rpmem_fip/TEST7 index 066dd28cd..ae7ef8d88 100755 --- a/src/test/rpmem_fip/TEST7 +++ b/src/test/rpmem_fip/TEST7 @@ -38,7 +38,6 @@ # single-threaded in TEST6 # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/rpmem_obc/Makefile b/src/test/rpmem_obc/Makefile index 9360cf418..3e6dcc0e1 100644 --- a/src/test/rpmem_obc/Makefile +++ b/src/test/rpmem_obc/Makefile @@ -1,5 +1,5 @@ # -# Copyright 2016-2017, Intel Corporation +# Copyright 2016-2019, Intel Corporation # # Redistribution and use in source and binary forms, with or without # modification, are permitted provided that the following conditions @@ -38,7 +38,6 @@ SCP_TO_REMOTE_NODES = y vpath %.c ../../librpmem/ vpath %.c ../../rpmem_common/ - TARGET = rpmem_obc OBJS = rpmem_obc_test.o\ rpmem_obc_test_common.o\ diff --git a/src/test/rpmem_obc/TEST3 b/src/test/rpmem_obc/TEST3 index f0e2d7ca8..976e1d16d 100755 --- a/src/test/rpmem_obc/TEST3 +++ b/src/test/rpmem_obc/TEST3 @@ -35,7 +35,6 @@ # src/test/rpmem_obc/TEST3 -- unit test for rpmem_obc_create function # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/rpmem_obc_int/TEST0 b/src/test/rpmem_obc_int/TEST0 index 4fd4f8a8d..29ae4f0e6 100755 --- a/src/test/rpmem_obc_int/TEST0 +++ b/src/test/rpmem_obc_int/TEST0 @@ -36,7 +36,6 @@ # rpmemd_obc modules # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/rpmem_obc_int/rpmem_obc_int.c b/src/test/rpmem_obc_int/rpmem_obc_int.c index 7422147b9..f4ba0c6cf 100644 --- a/src/test/rpmem_obc_int/rpmem_obc_int.c +++ b/src/test/rpmem_obc_int/rpmem_obc_int.c @@ -1,5 +1,5 @@ /* - * Copyright 2016-2018, Intel Corporation + * Copyright 2016-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -228,7 +228,6 @@ client_set_attr(const struct test_case *tc, int argc, char *argv[]) struct rpmem_target_info *info; const struct rpmem_pool_attr pool_attr = POOL_ATTR_ALT; - info = rpmem_target_parse(target); UT_ASSERTne(info, NULL); @@ -371,7 +370,6 @@ server(const struct test_case *tc, int argc, char *argv[]) ret = rpmemd_obc_status(obc, 0); UT_ASSERTeq(ret, 0); - while (1) { ret = rpmemd_obc_process(obc, &REQ, &arg); if (arg.closing) { diff --git a/src/test/rpmemd_config/README b/src/test/rpmemd_config/README index fe95fa31a..b6cdbd2d9 100644 --- a/src/test/rpmemd_config/README +++ b/src/test/rpmemd_config/README @@ -4,5 +4,3 @@ This is src/test/rpmemd_config/README. This directory contains a unit test for rpmemd command line and config file parsing. - - diff --git a/src/test/rpmemd_dbg/TEST1 b/src/test/rpmemd_dbg/TEST1 index 408f9bc6a..e54a1c3e7 100755 --- a/src/test/rpmemd_dbg/TEST1 +++ b/src/test/rpmemd_dbg/TEST1 @@ -35,7 +35,6 @@ # src/test/rpmemd_dbg/TEST1 -- unit test for rpmemd_log module # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/rpmemd_dbg/TEST2 b/src/test/rpmemd_dbg/TEST2 index a00e254c2..a530ff103 100755 --- a/src/test/rpmemd_dbg/TEST2 +++ b/src/test/rpmemd_dbg/TEST2 @@ -35,7 +35,6 @@ # src/test/rpmemd_dbg/TEST2 -- unit test for rpmemd_log module # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/rpmemd_obc/TEST0 b/src/test/rpmemd_obc/TEST0 index a253e0f97..15cc37b9c 100755 --- a/src/test/rpmemd_obc/TEST0 +++ b/src/test/rpmemd_obc/TEST0 @@ -35,7 +35,6 @@ # src/test/rpmemd_obc/TEST0 -- unit test for rpmemd_obc_process # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/rpmemd_obc/TEST1 b/src/test/rpmemd_obc/TEST1 index 7d82e6bee..101ea60ec 100755 --- a/src/test/rpmemd_obc/TEST1 +++ b/src/test/rpmemd_obc/TEST1 @@ -35,7 +35,6 @@ # src/test/rpmemd_obc/TEST1 -- unit test for rpmemd_obc_process # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/rpmemd_obc/TEST2 b/src/test/rpmemd_obc/TEST2 index c1a6b3f2f..482a3bc3a 100755 --- a/src/test/rpmemd_obc/TEST2 +++ b/src/test/rpmemd_obc/TEST2 @@ -35,7 +35,6 @@ # src/test/rpmemd_obc/TEST2 -- unit test for rpmemd_obc_process # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/rpmemd_obc/TEST3 b/src/test/rpmemd_obc/TEST3 index 97a26f187..596e084e6 100755 --- a/src/test/rpmemd_obc/TEST3 +++ b/src/test/rpmemd_obc/TEST3 @@ -35,7 +35,6 @@ # src/test/rpmemd_obc/TEST3 -- unit test for rpmemd_obc_process # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/rpmemd_obc/TEST4 b/src/test/rpmemd_obc/TEST4 index 828dba0d4..aafee9b7c 100755 --- a/src/test/rpmemd_obc/TEST4 +++ b/src/test/rpmemd_obc/TEST4 @@ -35,7 +35,6 @@ # src/test/rpmemd_obc/TEST4 -- unit test for rpmemd_obc_process # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/rpmemd_obc/rpmemd_obc_test_common.c b/src/test/rpmemd_obc/rpmemd_obc_test_common.c index 6e990b012..9514098d0 100644 --- a/src/test/rpmemd_obc/rpmemd_obc_test_common.c +++ b/src/test/rpmemd_obc/rpmemd_obc_test_common.c @@ -1,5 +1,5 @@ /* - * Copyright 2016-2018, Intel Corporation + * Copyright 2016-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -248,7 +248,6 @@ req_cb_set_attr(struct rpmemd_obc *obc, void *arg, return ret; } - /* * REQ_CB -- request callbacks */ @@ -334,7 +333,6 @@ server_msg_args(struct rpmemd_obc *rpdc, enum conn_wait_close conn, unsigned long long types = args->types; args->types = 0; - ret = rpmemd_obc_process(rpdc, &REQ_CB, args); UT_ASSERTeq(ret, args->ret); UT_ASSERTeq(args->types, types); diff --git a/src/test/set_funcs/set_funcs.c b/src/test/set_funcs/set_funcs.c index 32beacebb..664089752 100644 --- a/src/test/set_funcs/set_funcs.c +++ b/src/test/set_funcs/set_funcs.c @@ -45,7 +45,6 @@ #define BLK 1 #define LOG 2 - static struct counters { int mallocs; int frees; @@ -54,7 +53,6 @@ static struct counters { int strdups; } cnt[5]; - static void * test_malloc(size_t size) { @@ -139,7 +137,6 @@ obj_strdup(const char *s) return test_strdup(s); } - static void * blk_malloc(size_t size) { diff --git a/src/test/tools/bttcreate/bttcreate.c b/src/test/tools/bttcreate/bttcreate.c index e9dd9cb56..aa7b6a009 100644 --- a/src/test/tools/bttcreate/bttcreate.c +++ b/src/test/tools/bttcreate/bttcreate.c @@ -1,5 +1,5 @@ /* - * Copyright 2017-2019, Intel Corporation + * Copyright 2016-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -389,7 +389,6 @@ main(int argc, char *argv[]) /* print results */ print_result(&opts); - error_btt: btt_fini(bttp); if (util_unmap(base, opts.poolsize) < 0) { diff --git a/src/test/tools/cmpmap/cmpmap.c b/src/test/tools/cmpmap/cmpmap.c index e7f4add56..08807a319 100644 --- a/src/test/tools/cmpmap/cmpmap.c +++ b/src/test/tools/cmpmap/cmpmap.c @@ -269,7 +269,6 @@ out_close1: return ret; } - int main(int argc, char *argv[]) { diff --git a/src/test/tools/fip/fip.c b/src/test/tools/fip/fip.c index 4f4bde80e..2a2aad6a4 100644 --- a/src/test/tools/fip/fip.c +++ b/src/test/tools/fip/fip.c @@ -1,5 +1,5 @@ /* - * Copyright 2016, Intel Corporation + * Copyright 2016-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -69,7 +69,6 @@ main(int argc, char *argv[]) struct rpmem_target_info *info; - info = rpmem_target_parse(addr); if (!info) { fprintf(stderr, "error: cannot parse address -- '%s'", addr); diff --git a/src/test/tools/obj_verify/obj_verify.c b/src/test/tools/obj_verify/obj_verify.c index c2eeee222..d7f7e4dfc 100644 --- a/src/test/tools/obj_verify/obj_verify.c +++ b/src/test/tools/obj_verify/obj_verify.c @@ -1,5 +1,5 @@ /* - * Copyright 2018, Intel Corporation + * Copyright 2018-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -162,7 +162,6 @@ do_create(const char *path, const char *layout) pmemobj_close(pop); } - /* * do_verify -- (internal) verify a poolset */ diff --git a/src/test/tools/pmemdetect/pmemdetect.c b/src/test/tools/pmemdetect/pmemdetect.c index 3c53f75e7..5a68f2585 100644 --- a/src/test/tools/pmemdetect/pmemdetect.c +++ b/src/test/tools/pmemdetect/pmemdetect.c @@ -1,5 +1,5 @@ /* - * Copyright 2016-2018, Intel Corporation + * Copyright 2016-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -299,7 +299,6 @@ supports_map_sync(const char *path) if (flags & PMEM_FILE_CREATE && !(flags & PMEM_FILE_TMPFILE)) util_unlink(path); - return ret; } diff --git a/src/test/tools/pmemobjcli/pmemobjcli.c b/src/test/tools/pmemobjcli/pmemobjcli.c index ecd63d4b2..89d8abc22 100644 --- a/src/test/tools/pmemobjcli/pmemobjcli.c +++ b/src/test/tools/pmemobjcli/pmemobjcli.c @@ -1012,7 +1012,6 @@ pocli_pmemobj_pool_by_ptr(struct pocli_ctx *ctx, struct pocli_args *args) enum pocli_ret ret; uint64_t offset; - if ((ret = pocli_args_obj(ctx, args, 1, &oid))) return ret; if ((ret = pocli_args_number(args, 2, &offset))) @@ -2388,7 +2387,6 @@ main(int argc, char *argv[]) goto out; } - break; case 'p': print_only = true; diff --git a/src/test/tools/pmemspoil/README b/src/test/tools/pmemspoil/README index 4f16ed898..e464d4c33 100644 --- a/src/test/tools/pmemspoil/README +++ b/src/test/tools/pmemspoil/README @@ -34,7 +34,6 @@ The pmemspoil supports the following structures: - btt_map - BTT Map entries, see btt_layout.h for details - bttdevice - analogical to pmemblk but for BTT device - Examples: In order to change pool_hdr's signature and start offset of pmemlog pool: diff --git a/src/test/tools/pmemspoil/spoil.c b/src/test/tools/pmemspoil/spoil.c index ea45d8088..4d4fbadd3 100644 --- a/src/test/tools/pmemspoil/spoil.c +++ b/src/test/tools/pmemspoil/spoil.c @@ -1072,7 +1072,6 @@ pmemspoil_process_bttdevice(struct pmemspoil *psp, return PROCESS_RET; } - /* * pmemspoil_process_pmemlog -- process pmemlog fields */ diff --git a/src/test/tools/pmemwrite/write.c b/src/test/tools/pmemwrite/write.c index 5510c856d..7ad922140 100644 --- a/src/test/tools/pmemwrite/write.c +++ b/src/test/tools/pmemwrite/write.c @@ -1,5 +1,5 @@ /* - * Copyright 2014-2018, Intel Corporation + * Copyright 2014-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -58,7 +58,6 @@ struct pmemwrite char **args; /* list of arguments */ }; - static struct pmemwrite pmemwrite = { .fname = NULL, .nargs = 0, diff --git a/src/test/tools/sparsefile/TEST_SPARSE.ps1 b/src/test/tools/sparsefile/TEST_SPARSE.ps1 index 28362a018..9b94af314 100755 --- a/src/test/tools/sparsefile/TEST_SPARSE.ps1 +++ b/src/test/tools/sparsefile/TEST_SPARSE.ps1 @@ -1,5 +1,5 @@ # -# Copyright 2016-2018, Intel Corporation +# Copyright 2016-2019, Intel Corporation # # Redistribution and use in source and binary forms, with or without # modification, are permitted provided that the following conditions @@ -124,7 +124,6 @@ function create_holey_file3 { Write-Host -NoNewline "." } - $start = epoch for ($i=1;$i -lt $count;$i++) { remove_file $path @@ -134,7 +133,6 @@ $end = epoch $t = ($end - $start) / 1000 Write-Host "`nsparsefile: $t seconds" - $start = epoch for ($i=1;$i -lt $count;$i++) { remove_file $path @@ -144,7 +142,6 @@ $end = epoch $t = ($end - $start) / 1000 Write-Host "`npowershell + fsutil: $t seconds" - $start = epoch for ($i=1;$i -lt $count;$i++) { remove_file $path diff --git a/src/test/tools/usc_permission_check/usc_permission_check.c b/src/test/tools/usc_permission_check/usc_permission_check.c index 12e42d350..7bcbdd633 100644 --- a/src/test/tools/usc_permission_check/usc_permission_check.c +++ b/src/test/tools/usc_permission_check/usc_permission_check.c @@ -1,5 +1,5 @@ /* - * Copyright 2018, Intel Corporation + * Copyright 2018-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -39,7 +39,6 @@ #include <stdio.h> #include "os_dimm.h" - /* * This program returns: * - 0 when usc can be read with current permissions diff --git a/src/test/unicode_api/TEST0 b/src/test/unicode_api/TEST0 index f30eb92aa..7b1c7fcb8 100755 --- a/src/test/unicode_api/TEST0 +++ b/src/test/unicode_api/TEST0 @@ -35,7 +35,6 @@ # src/test/unicode_api/TEST0 -- unicode C API check # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/unittest/unittest.h b/src/test/unittest/unittest.h index 44f2c3c30..14211c09a 100644 --- a/src/test/unittest/unittest.h +++ b/src/test/unittest/unittest.h @@ -788,7 +788,6 @@ void __asan_unpoison_memory_region(void const volatile *addr, size_t size); ((void)(addr), (void)(size)) #endif - #ifdef __cplusplus } #endif diff --git a/src/test/unittest/unittest.ps1 b/src/test/unittest/unittest.ps1 index 0bcab11b5..d79ccf800 100644 --- a/src/test/unittest/unittest.ps1 +++ b/src/test/unittest/unittest.ps1 @@ -1024,7 +1024,6 @@ function setup { $Script:DIR = $DIR + "\" + $Env:DIRSUFFIX + "\" + $curtestdir + $Env:UNITTEST_NUM + $Env:SUFFIX - # test type must be explicitly specified if ($req_test_type -ne "1") { fatal "error: required test type is not specified" @@ -1170,7 +1169,6 @@ if (-Not $Env:UNITTEST_NAME) { $Global:REAL_FS = $Env:FS - # choose based on FS env variable switch ($Env:FS) { 'pmem' { @@ -1215,7 +1213,6 @@ switch ($Env:FS) { } } # switch - # Length of pool file's signature sv -Name SIG_LEN 8 diff --git a/src/test/unittest/unittest.sh b/src/test/unittest/unittest.sh index 242900ac1..ae57a3c3f 100644 --- a/src/test/unittest/unittest.sh +++ b/src/test/unittest/unittest.sh @@ -1419,7 +1419,6 @@ require_dax_device_alignments() { require_node_dax_device_alignments -1 $* } - # # require_fs_type -- only allow script to continue for a certain fs type # @@ -1436,7 +1435,6 @@ function require_fs_type() { exit 0 } - # # require_native_fallocate -- verify if filesystem supports fallocate # diff --git a/src/test/unittest/ut.c b/src/test/unittest/ut.c index 37a15c6b4..30c4a61a0 100644 --- a/src/test/unittest/ut.c +++ b/src/test/unittest/ut.c @@ -1042,7 +1042,6 @@ ut_toUTF16(const char *wstr) } #endif - /* * ut_strtoi -- a strtoi call that cannot return error */ diff --git a/src/test/util_badblock/util_badblock.c b/src/test/util_badblock/util_badblock.c index 8a6169814..f2c2b4021 100644 --- a/src/test/util_badblock/util_badblock.c +++ b/src/test/util_badblock/util_badblock.c @@ -145,7 +145,6 @@ do_open(const char *path) util_poolset_close(set, DO_NOT_DELETE_PARTS); } - static void do_fault_injection(const char *path) { diff --git a/src/test/util_ctl/TEST0 b/src/test/util_ctl/TEST0 index 1cc2949f4..37dad28a4 100755 --- a/src/test/util_ctl/TEST0 +++ b/src/test/util_ctl/TEST0 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type short diff --git a/src/test/util_ctl/TEST1 b/src/test/util_ctl/TEST1 index 7ccc38cfd..0dba8d392 100755 --- a/src/test/util_ctl/TEST1 +++ b/src/test/util_ctl/TEST1 @@ -31,7 +31,6 @@ # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. # - . ../unittest/unittest.sh require_test_type medium diff --git a/src/test/util_poolset/TEST0 b/src/test/util_poolset/TEST0 index c5c043dad..2d4daedc7 100755 --- a/src/test/util_poolset/TEST0 +++ b/src/test/util_poolset/TEST0 @@ -150,7 +150,6 @@ check_no_files $DIR/testfile41 $DIR/testfile42\ $DIR/testfile231\ $DIR/testfile252 - $GREP "<1>" $TEST_LOG_FILE | sed -e "s/^.*\][ ]*//g" > ./grep$UNITTEST_NUM.log check diff --git a/src/test/util_poolset/mocks_windows.c b/src/test/util_poolset/mocks_windows.c index dab582800..444acb25f 100644 --- a/src/test/util_poolset/mocks_windows.c +++ b/src/test/util_poolset/mocks_windows.c @@ -1,5 +1,5 @@ /* - * Copyright 2016-2018, Intel Corporation + * Copyright 2016-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -91,7 +91,6 @@ FUNC_MOCK_RUN_DEFAULT { } FUNC_MOCK_END - /* * On Windows libpmem is statically linked to util_poolset test, but we * don't want its ctor to initialize 'out' module. diff --git a/src/test/util_poolset_parse/util_poolset_parse.c b/src/test/util_poolset_parse/util_poolset_parse.c index 11ed1df68..e4b5ec812 100644 --- a/src/test/util_poolset_parse/util_poolset_parse.c +++ b/src/test/util_poolset_parse/util_poolset_parse.c @@ -91,8 +91,6 @@ main(int argc, char *argv[]) CLOSE(fd); } - - common_fini(); DONE(NULL); diff --git a/src/test/util_sds/util_sds.c b/src/test/util_sds/util_sds.c index 79e458876..cd14a788a 100644 --- a/src/test/util_sds/util_sds.c +++ b/src/test/util_sds/util_sds.c @@ -1,5 +1,5 @@ /* - * Copyright 2017-2018, Intel Corporation + * Copyright 2017-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -150,7 +150,6 @@ main(int argc, char *argv[]) DONE(NULL); } - FUNC_MOCK(os_dimm_uid, int, const char *path, char *uid, size_t *len, ...) FUNC_MOCK_RUN_DEFAULT { if (uid_it < uids_size) { diff --git a/src/tools/Makefile.inc b/src/tools/Makefile.inc index 293b3bbc0..e5273c088 100644 --- a/src/tools/Makefile.inc +++ b/src/tools/Makefile.inc @@ -191,7 +191,6 @@ STATIC_DEBUG_LIBS += $(LIBSDIR_DEBUG)/libpmem.a STATIC_NONDEBUG_LIBS += $(LIBSDIR_NONDEBUG)/libpmem.a endif - # If any of these libraries is required, we need to link libpthread ifneq ($(LIBPMEMCOMMON)$(LIBPMEM)$(LIBPMEMPOOL)$(LIBPMEMBLK)$(LIBPMEMLOG)$(LIBPMEMOBJ),) LIBS += -pthread @@ -202,7 +201,6 @@ ifneq ($(LIBPMEMCOMMON)$(LIBPMEMPOOL)$(LIBPMEMOBJ),) LIBS += $(LIBDL) endif - ifeq ($(TOOLS_COMMON), y) vpath %.c $(TOP)/src/tools/pmempool diff --git a/src/tools/pmempool/README b/src/tools/pmempool/README index 8347ff18b..e1c7e975a 100644 --- a/src/tools/pmempool/README +++ b/src/tools/pmempool/README @@ -106,7 +106,6 @@ There is a set of common features for all pool types and a set of features specific for particular pool type. All features are described below. - ** Common features * The basic function of *info* command is to print information about the diff --git a/src/tools/pmempool/create.c b/src/tools/pmempool/create.c index 63c3ea3a1..057636b90 100644 --- a/src/tools/pmempool/create.c +++ b/src/tools/pmempool/create.c @@ -56,7 +56,6 @@ #include "libpmemlog.h" #include "libpmempool.h" - #define DEFAULT_MODE 0664 /* * pmempool_create -- context and args for create command diff --git a/src/tools/rpmemd/rpmemd_obc.c b/src/tools/rpmemd/rpmemd_obc.c index aa197f1d6..d33ce92ff 100644 --- a/src/tools/rpmemd/rpmemd_obc.c +++ b/src/tools/rpmemd/rpmemd_obc.c @@ -1,5 +1,5 @@ /* - * Copyright 2016-2018, Intel Corporation + * Copyright 2016-2019, Intel Corporation * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions @@ -55,7 +55,6 @@ struct rpmemd_obc { int fd_out; }; - /* * rpmemd_obc_check_proto_ver -- check protocol version */ @@ -439,7 +438,6 @@ rpmemd_obc_fini(struct rpmemd_obc *obc) free(obc); } - /* * rpmemd_obc_status -- sends initial status to the client */ diff --git a/src/windows/include/platform.h b/src/windows/include/platform.h index dd01cc177..76542ead1 100644 --- a/src/windows/include/platform.h +++ b/src/windows/include/platform.h @@ -1,5 +1,5 @@ /* - * Copyright 2015-2018, Intel Corporation + * Copyright 2015-2019, Intel Corporation * Copyright (c) 2016, Microsoft Corporation. All rights reserved. * * Redistribution and use in source and binary forms, with or without @@ -90,7 +90,6 @@ extern "C" { #define inline __inline #endif - /* XXX - no equivalents in VC++ */ #define __attribute__(a) #define __builtin_constant_p(cnd) 0 diff --git a/src/windows/win_mmap.c b/src/windows/win_mmap.c index d19bfa2ba..d420c5a28 100644 --- a/src/windows/win_mmap.c +++ b/src/windows/win_mmap.c @@ -283,7 +283,6 @@ mmap(void *addr, size_t len, int prot, int flags, int fd, os_off_t offset) return MAP_FAILED; } - /* XXX shall we use SEC_LARGE_PAGES flag? */ DWORD protect = 0; DWORD access = 0; diff --git a/utils/build-dpkg.sh b/utils/build-dpkg.sh index 0c88da533..cee176f70 100755 --- a/utils/build-dpkg.sh +++ b/utils/build-dpkg.sh @@ -117,7 +117,6 @@ do esac done - # check for mandatory arguments if [ -z "$PACKAGE_VERSION_TAG" -o -z "$SOURCE" -o -z "$WORKING_DIR" -o -z "$OUT_DIR" ] then @@ -125,7 +124,6 @@ then usage fi - PREFIX=usr LIB_DIR=$PREFIX/lib/$(dpkg-architecture -qDEB_HOST_MULTIARCH) INC_DIR=$PREFIX/include @@ -288,7 +286,6 @@ Description: daxio utility EOF } - if [ "${BUILD_PACKAGE_CHECK}" == "y" ] then CHECK_CMD=" @@ -778,7 +775,6 @@ then daxio_install_triggers_overrides; fi - # Convert ChangeLog to debian format CHANGELOG_TMP=changelog.tmp dch --create --empty --package $PACKAGE_NAME -v $PACKAGE_VERSION-$PACKAGE_RELEASE -M -c $CHANGELOG_TMP diff --git a/utils/build-rpm.sh b/utils/build-rpm.sh index ed461e72a..ed64306d5 100755 --- a/utils/build-rpm.sh +++ b/utils/build-rpm.sh @@ -1,6 +1,6 @@ #!/usr/bin/env bash # -# Copyright 2014-2018, Intel Corporation +# Copyright 2014-2019, Intel Corporation # # Redistribution and use in source and binary forms, with or without # modification, are permitted provided that the following conditions @@ -127,7 +127,6 @@ do esac done - # check for mandatory arguments if [ -z "$PACKAGE_VERSION_TAG" -o -z "$SOURCE" -o -z "$WORKING_DIR" -o -z "$OUT_DIR" ] then @@ -149,7 +148,6 @@ then fi fi - if [ "$EXTRA_CFLAGS_RELEASE" = "" ]; then export EXTRA_CFLAGS_RELEASE="-ggdb -fno-omit-frame-pointer" fi @@ -166,7 +164,6 @@ then exit 1 fi - PACKAGE_SOURCE=${PACKAGE_NAME}-${PACKAGE_VERSION} SOURCE=$PACKAGE_NAME PACKAGE_TARBALL=$PACKAGE_SOURCE.tar.gz diff --git a/utils/check-shebang.sh b/utils/check-shebang.sh index f150c0b58..432403c95 100755 --- a/utils/check-shebang.sh +++ b/utils/check-shebang.sh @@ -1,6 +1,6 @@ #!/usr/bin/env bash # -# Copyright 2017, Intel Corporation +# Copyright 2017-2019, Intel Corporation # # Redistribution and use in source and binary forms, with or without # modification, are permitted provided that the following conditions @@ -56,6 +56,3 @@ else fi exit $err_count - - - diff --git a/utils/get_aliases.sh b/utils/get_aliases.sh index 91211729b..445bae8e1 100755 --- a/utils/get_aliases.sh +++ b/utils/get_aliases.sh @@ -46,7 +46,6 @@ # to handle functions and their aliases # - list=("$@") man_child=("$@") -- GitLab