From 9db257dcb40a798c5ee9f06c006d79a0e99ec9c0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marcin=20=C5=9Alusarz?= <marcin.slusarz@intel.com> Date: Fri, 19 Oct 2018 19:16:44 +0200 Subject: [PATCH] test: disable prefault tests on xfs ctl_prefault test verifies that the functionality of prefaulting works by using indirect information, which for xfs returns incorrect information. There's nothing file system-specific in the way prefaulting works, so verifying it works only on one file system (ext4) is enough. --- src/test/tools/fallocate_detect/fallocate_detect.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/test/tools/fallocate_detect/fallocate_detect.c b/src/test/tools/fallocate_detect/fallocate_detect.c index 9a328a2c4..296968ed9 100644 --- a/src/test/tools/fallocate_detect/fallocate_detect.c +++ b/src/test/tools/fallocate_detect/fallocate_detect.c @@ -44,10 +44,6 @@ #include <linux/magic.h> #include <sys/vfs.h> -#ifndef XFS_SUPER_MAGIC -#define XFS_SUPER_MAGIC 0x58465342 -#endif - /* * posix_fallocate on Linux is implemented using fallocate * syscall. This syscall requires file system-specific code on @@ -79,8 +75,7 @@ check_fallocate(const char *file) struct statfs fs; if (!fstatfs(fd, &fs)) { - if (fs.f_type != EXT4_SUPER_MAGIC && /* also ext2, ext3 */ - fs.f_type != XFS_SUPER_MAGIC) { + if (fs.f_type != EXT4_SUPER_MAGIC /* also ext2, ext3 */) { /* * On CoW filesystems, fallocate reserves _amount * of_ space but doesn't allocate a specific block. -- GitLab