From 905a1b58d1081601ed56fe5ba20ad670f3f4a708 Mon Sep 17 00:00:00 2001 From: David Hendriks <davidhendriks93@gmail.com> Date: Wed, 23 Jun 2021 14:21:21 +0100 Subject: [PATCH] updated some comments --- binarycpython/utils/distribution_functions.py | 24 ++++++++++++------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/binarycpython/utils/distribution_functions.py b/binarycpython/utils/distribution_functions.py index 5d388a16d..0fb0037c6 100644 --- a/binarycpython/utils/distribution_functions.py +++ b/binarycpython/utils/distribution_functions.py @@ -940,22 +940,28 @@ def cosmic_SFH_madau_dickinson2014(z): ######################################################################## # Moe & DiStefano 2017 functions +# +# The code below are functions that are used to set up and interpolate +# on the Moe & DiStefano 2017 data. The interpolators take the last +# known value if we try to interpolate outside of the tables. +# There are still some open tasks and improvements that can be made: +# +# TODO: check all the raise ValueErrors to make them more appropriate +# TODO: Put the json checking stuff in a different function +# TODO: Clean up the logging +# TODO: Solve the memory issues that are present. +# Are the interpolators not cleaned? +# TODO: Parallellize the setting up of the interpolators +# TODO: Generalize the code such that we can input other/newer tables + + ######################################################################## import py_rinterpolate -# Tasks -# TODO: check all the raise ValueErrors to make them more appropriate -# TODO: Put the json checking stuff in a different function -# TODO: make function to normalize dictionary of 1 layer deep -# TODO: make use of the @cached_property decorators to make use of cached calls -# TODO: Fix the automatic freeing functions in py_rinterpolate -# TODO: check very well which functions actually need to be part of the population object - # Global dictionary to store values in Moecache = {} - def poisson(lambda_val, n, nmax=None, verbosity=0): """ Function that calculates the poisson value and normalizes -- GitLab